From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3919C433F5 for ; Thu, 27 Jan 2022 15:08:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD45F83883; Thu, 27 Jan 2022 16:06:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="I1UTHylL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C95668349B; Thu, 27 Jan 2022 16:06:27 +0100 (CET) Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E484483809 for ; Thu, 27 Jan 2022 16:06:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x32b.google.com with SMTP id d18-20020a9d51d2000000b005a09728a8c2so2824883oth.3 for ; Thu, 27 Jan 2022 07:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c4zKTkXGcuQs1lnDGwaHJNkRVprpOJWH7k9vWZlHRhk=; b=I1UTHylL0+WEBEdHwgbNaVx6W2gQpkRzt4xPIt0khDlL+lcfg7XKI32uVAACg/D5JT K8wZbcQrMesJxB/5/uUa2qgLhhVu/A8R/GW+gHHXQpgE+obKimaq8eSDJQwUWDjbuE8m x/77zHOtK3TVcWb0eFIsOdLcP1cp5HOCqTY0w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c4zKTkXGcuQs1lnDGwaHJNkRVprpOJWH7k9vWZlHRhk=; b=5kwzGGpKOA72YyFVXUit354Be1ct24F20JZCiDNOUhedJMN/InGgap+2V/afZc5T3j 0/5XZTChUCPh/D2qwjKkMMlomUGDubsUayuT7rEml6kf+nU7cgiCBQvmc3AgLPk+lhbA nXA8YrygMB/BjZIcUTaPyaB128PnqTGG6KW24GUCIALmYrhztAJLTcvZS6VHYfwqfzIn LGAM+8MGhLTsLLEqakUXAbjQaPuD/T7f+WuffbDNESl5sXQ3gvdX5cHJhvt5tA+Us+dD /YsPUz7v8oAgeUDgZOrCuq7NAYB8VKnhnv1d4szkPoBr7ShE652dJsMnReGIeVgQ2nxg LHpQ== X-Gm-Message-State: AOAM532vzVay6pzj26wzkui9kYJMK0vAQBJ5qRaU8ncIrelqxCxM0/N2 YE6+JWC1y3kOyng/lRcJDJu0K3Cqxzc/FAYzt8dlhtsaU14= X-Google-Smtp-Source: ABdhPJw8OGtjVDusLlhu0aukXkT82d2VverC+gLM2tXwxnX7Iva+mzF3Ulsuj38CpPTqq5UiQp5Os8NzWxCWreiAMHo= X-Received: by 2002:a05:6830:2683:: with SMTP id l3mr2300654otu.203.1643295981937; Thu, 27 Jan 2022 07:06:21 -0800 (PST) MIME-Version: 1.0 References: <20220127140314.10264-1-philippe.reynes@softathome.com> <20220127140314.10264-2-philippe.reynes@softathome.com> In-Reply-To: <20220127140314.10264-2-philippe.reynes@softathome.com> From: Simon Glass Date: Thu, 27 Jan 2022 08:06:06 -0700 Message-ID: Subject: Re: [PATCH 2/2] tools: binman: main.py: add /tmp/sandbox sys.path To: Philippe Reynes Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Philippe, On Thu, 27 Jan 2022 at 07:03, Philippe Reynes wrote: > > Adds /tmp/sandbox to sys.path to look for libfdt, > otherwise ci is broken if a py_test uses binman. > > Signed-off-by: Philippe Reynes > --- > tools/binman/main.py | 1 + > 1 file changed, 1 insertion(+) Which test uses /tmp/sandbox to build U-Boot? We might need to use --toolpath for this, or set PYTHONPATH in the caller? > > diff --git a/tools/binman/main.py b/tools/binman/main.py > index f62394043d..7d52482c0c 100755 > --- a/tools/binman/main.py > +++ b/tools/binman/main.py > @@ -42,6 +42,7 @@ sys.path.insert(2, 'scripts/dtc/pylibfdt') > sys.path.insert(2, os.path.join(srctree, 'scripts/dtc/pylibfdt')) > sys.path.insert(2, os.path.join(srctree, 'build-sandbox/scripts/dtc/pylibfdt')) > sys.path.insert(2, os.path.join(srctree, 'build-sandbox_spl/scripts/dtc/pylibfdt')) > +sys.path.insert(2, os.path.join(srctree, '/tmp/sandbox/scripts/dtc/pylibfdt')) > > # When running under python-coverage on Ubuntu 16.04, the dist-packages > # directories are dropped from the python path. Add them in so that we can find > -- > 2.17.1 > Regards, Simon