From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EC03C433F5 for ; Wed, 12 Jan 2022 20:08:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7A3D88365A; Wed, 12 Jan 2022 21:05:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Tfu7C2tC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2731E83531; Wed, 12 Jan 2022 21:04:46 +0100 (CET) Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 98D77833A2 for ; Wed, 12 Jan 2022 21:04:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x330.google.com with SMTP id c3-20020a9d6c83000000b00590b9c8819aso3823271otr.6 for ; Wed, 12 Jan 2022 12:04:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2uu7cQwtM8B8SjErJxFArvbpThMe9ngZ8a4fLNeezt0=; b=Tfu7C2tCxdFdG6MXlew9r1Yi13S6alauRiH/+IKI+Z6ENUWx2hPPYuj+aXmDNyjgwp 5GOBAKJtbXneaePEnaSLa7UK7btE4wv6e6OGixGSw5N3Ciles2ee2TA3jxcDIHdCcsXm 3NqWFG+AzC2uHpXrULACWD2JFDuQJ9v/z2nME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2uu7cQwtM8B8SjErJxFArvbpThMe9ngZ8a4fLNeezt0=; b=CRqe/tTgSS+v5dpLX0XFCpaAsdJPXZa1dO1LGklMpOqIEJIqi1C9zRhDo8k9XCZF02 1W8sP4AAf6qkv4l/w5NGzeKxMxFKlveXTI6vUH52joJnCE1/AIbkNBZ4Bg8vPutCml+5 cf46ueaNc1CxvdXuVUG9EvbrLcuCV00X+BZtuUwCdBNe75dI72ZO7h3cClHnWkKxHYTn vDhaYXRYMwwQyYmgnOaEa04ftMm6WfsSn3OGECuS4Y7HuEDOgn9OGvk5F+cyHtHs1GRC y5vSYNmRNK21iQaqoV9rhX18J+8s5tZstD5pODI7dH3Jb+zDcv602fqVaVg9bGOY9VnI N4Kg== X-Gm-Message-State: AOAM531lTNh1My/Tkoy6ZTWarc1E0rml+WTYRcuiX2YAwFW+776+mVSg QFy47h3wBlYODnFfDBTTr8qFWc0+XGSjrHW4u5Vyxw== X-Google-Smtp-Source: ABdhPJyncc3vZXCZYMW8Lf4HsVwJD/4gh6Ri8BFPDQqmSrh/QOjEIi9yEhFuJJ8AqQKWEdtFakf47uRXLX4GhNlVHpQ= X-Received: by 2002:a9d:6e8d:: with SMTP id a13mr963417otr.269.1642017878028; Wed, 12 Jan 2022 12:04:38 -0800 (PST) MIME-Version: 1.0 References: <20211231161327.24918-1-francis.laniel@amarulasolutions.com> <20211231161327.24918-12-francis.laniel@amarulasolutions.com> In-Reply-To: <20211231161327.24918-12-francis.laniel@amarulasolutions.com> From: Simon Glass Date: Wed, 12 Jan 2022 13:03:31 -0700 Message-ID: Subject: Re: [RFC PATCH v1 11/21] cli: Enables using hush 2021 parser as command line parser. To: Francis Laniel Cc: U-Boot Mailing List , Marek Behun , Michael Nazzareno Trimarchi , Wolfgang Denk , Harald Seiler Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Francis, On Fri, 31 Dec 2021 at 09:14, Francis Laniel wrote: > > If one defines HUSH_2021_PARSER, cli_loop() will jump on hush 2021 parser code. > > Signed-off-by: Francis Laniel > --- > common/cli.c | 14 +++++++++++--- > include/cli_hush.h | 8 ++++++++ > 2 files changed, 19 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass Can you avoid using the preprocessor here? Could be cleaned up later. Regards, Simon