From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53897C433EF for ; Thu, 14 Oct 2021 15:17:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C522560F4A for ; Thu, 14 Oct 2021 15:17:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C522560F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4A1228383C; Thu, 14 Oct 2021 17:13:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="aMP+qD8f"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E0EEB837A6; Thu, 14 Oct 2021 17:12:08 +0200 (CEST) Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A3885837BE for ; Thu, 14 Oct 2021 17:12:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x230.google.com with SMTP id m67so8883017oif.6 for ; Thu, 14 Oct 2021 08:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vSChTjHiqMC80T3WsG5mrKSOF1qt5vo0FfnA2fUIlrE=; b=aMP+qD8fcUR4X4+ygf3kUMYJkwKmFeqYKTCp0ruHgJHloB2ODxjjvW0vKTRX3wG5rM /IrJ+pBmqzPjpPj3SqNski7wOMeOw0LDP/X+Kj9KiJXr4QqA2ftb4DURqVKoYDsUjzI4 pGFme4q73D5STczgiRmmDB9IdxnMdXEAxZGKs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vSChTjHiqMC80T3WsG5mrKSOF1qt5vo0FfnA2fUIlrE=; b=6Acmn7GwG74hbBJf0YJw8EIPteZhp0JNa6xW8XG4GzZGcUCbaen7ShkKT9A8wzR6h1 lyeleZnev1dUE5yzOE57PrmACYzZ4f6QdIxDFZbPqLzA9E2+iOs8huqnPYM3UYD3/o+w A/B1qAy/+lhpy3XWi5nogDWDYQWkKKSKiYBst5H63EJkbzprA2hIqcbHQ2Ol61mQHN67 FCcZiJXRBgZzzLU4PP8sDdqRAMJ+DMIaknWm3iRBojFijBjFmtK+rRQAuriplmhCYvMp A1eFJDlDOhKLego2w9tCHIkBmau1G+Hbwpez8mGJNsrHQ0cCkRfrqLLmSrDDKkQrGyss 0nvw== X-Gm-Message-State: AOAM533o0tf0caTyKtbTfk0arYNSxus9jO42FE1WpLaSAT5CXEXmIG+t 1drnRrEJkJZWcvHf153k7T6/ZqgunklJDs/FY31wew== X-Google-Smtp-Source: ABdhPJxtNulkJO1z2LC5Z/CWYzbCOASi4TcIlBM2ZZM6OPMJlp3kR/51e5vD28OC+I7ORMRpfAUrVZSgYUAgUPFst2c= X-Received: by 2002:a05:6808:189f:: with SMTP id bi31mr4412507oib.150.1634224319189; Thu, 14 Oct 2021 08:11:59 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-8-kabel@kernel.org> In-Reply-To: <20211013154557.28479-8-kabel@kernel.org> From: Simon Glass Date: Thu, 14 Oct 2021 09:11:13 -0600 Message-ID: Subject: Re: [PATCH v2 07/13] env: Inline env_get_char() into it's only user To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > This function is a relic from the past when environment was read from > underlying device one character at a time. > > It is used only in the case when getting an environemnt variable prior > relocation, and the function is simple enough to be inlined there. > > Since env_get_char() is being changed to simple access to an array, we > can drop the failing cases and simplify the code (this could have been > done before, since env_get_char() did not fail even before). > > Signed-off-by: Marek Beh=C3=BAn > --- > cmd/nvedit.c | 28 ++++++++++++++-------------- > env/env.c | 8 -------- > env/nowhere.c | 5 ++--- > include/env.h | 10 ---------- > 4 files changed, 16 insertions(+), 35 deletions(-) > in subject: typo it's should be its Reviewed-by: Simon Glass