From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Sat, 15 May 2021 09:20:04 -0600
Subject: [PATCH 1/2] clk: scmi: register all scmi clock by name with CCF
In-Reply-To: <20210512145424.13184-1-etienne.carriere@linaro.org>
References: <20210512145424.13184-1-etienne.carriere@linaro.org>
Message-ID: <CAPnjgZ2UFe8XBSjyrYR6tCYROC1nHB-c0AWxF2wryC-Ly8kB4g@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On Wed, 12 May 2021 at 08:55, Etienne Carriere
<etienne.carriere@linaro.org> wrote:
>
> From: Patrick Delaunay <patrick.delaunay@st.com>
>
> This patch implements SCMI APIs to retrieve the number and the name of
> SCMI clocks using SCMI_PROTOCOL_ATTRIBUTES messages.
>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
>  drivers/clk/clk_scmi.c   | 101 +++++++++++++++++++++++++++++++++++++++
>  include/scmi_protocols.h |  43 +++++++++++++++++
>  2 files changed, 144 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

I notice that this code uses pointers to return error codes. We tend
to avoid that in U-Boot and use an integer return instead, with the
pointer returned as a parameter. We have things like log_msg_ret() to
help with that. I don't have strong feelings about this if the goal is
to make the code match linux code. But if this code is for U-Boot
only, please do avoid it.

Regards,
Simon