From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE17FC07E96 for ; Sun, 11 Jul 2021 23:00:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E704160FEB for ; Sun, 11 Jul 2021 23:00:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E704160FEB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 449A282C10; Mon, 12 Jul 2021 01:00:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mIfvCmRG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9923282C24; Mon, 12 Jul 2021 01:00:35 +0200 (CEST) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B9BC282C10 for ; Mon, 12 Jul 2021 01:00:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wr1-x431.google.com with SMTP id p8so22484659wrr.1 for ; Sun, 11 Jul 2021 16:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:from:in-reply-to:references:date:message-id :subject:to:cc; bh=hbwfeGYntyssiKy3KCn/gqU62Fa1B0muomG7kU9JEQQ=; b=mIfvCmRGFHLH2wNix/je+7Vd6kydWaLEvpYclr9jsPnQgmj51I8non0omLXqOFS38S xLxE7vjbCpVF+Y73gQtlagKNmqBu4cO5RJvNa3eVrb0NDBpc8O8LEbaEuYvRDndG7kXb wZ9ECbPJF4l9VMfG4845EsVJp5HRIfI52VIXE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:in-reply-to:references :date:message-id:subject:to:cc; bh=hbwfeGYntyssiKy3KCn/gqU62Fa1B0muomG7kU9JEQQ=; b=N9t1dLetLJ2PYOdjcZyeCCngu4A7MITps1Bw0S5TFq4jW/LsV80o8yWe/MCi7QXBKH hUTYigmtoLNbNdYzp0Sy4MKx+VJ3L6jeHTSrnALKrKJXMB7yK67NxnVXAHhYyBhttHeu hYGAR0eesRvelIRi2zxkQeds8cg43DyfaUJgXveNfAZY/uKpHOQcszMRxbeeH5e1K2PS WEnnHtxacwXGO+3xDQBHIEytD+uCbIkxw2s+dyfbBiSE3RCaTjkDGCNMfyhAz1tZmQFJ x12Yy0GvF3D9pZQs2/8EbeJnZU17aJUZh4cQQAe4lks3MDMIU2gS7FG1LLA9rHzMVLsz 4kog== X-Gm-Message-State: AOAM5308c9/3F/VH17M/KS6YXvv4fmWdO8Jd1SbpVFKQWmC0MMhIkpr1 Y35s+W9yHdtMo1ytzMQGThxplaciEf+Aqh34lefV9g== X-Google-Smtp-Source: ABdhPJwoIS0t/cukAMHRcrttF8ZaOmRokCCSC+IB88Q3IkqaKhOweGliouvMsqsvPfdelGAIST/hN9DPknsn47iua4I= X-Received: by 2002:adf:8069:: with SMTP id 96mr11134253wrk.56.1626044431895; Sun, 11 Jul 2021 16:00:31 -0700 (PDT) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Sun, 11 Jul 2021 16:00:30 -0700 MIME-Version: 1.0 From: Simon Glass In-Reply-To: References: <20210704181950.1917106-1-sjg@chromium.org> <20210704181950.1917106-8-sjg@chromium.org> Date: Sun, 11 Jul 2021 16:00:30 -0700 X-Google-Sender-Auth: hiEpyzCn2wtA-7OVDCVZo209Bho Message-ID: Subject: Re: [PATCH 7/8] dtoc: Detect drivers which do not parse correctly To: Walter Lozano Cc: Johan Jonker , Simon Glass , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/4/21 3:19 PM, Simon Glass wrote: > At present if a driver is missing a uclass or compatible stirng, this Most probably it should be "string" > is silently ignored. This makes sense in most cases, particularly for > the compatible string, since it is not required except when the driver > is used with of-platdata. > > But it is also not very helpful. When there is some sort of problem > with a driver, the missing compatible string (for example) may be the > cause. > > Add a warning in this case, showing it only for drivers which are used > by the build. > > Signed-off-by: Simon Glass > --- > > tools/dtoc/src_scan.py | 7 ++++++- > tools/dtoc/test_src_scan.py | 38 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 44 insertions(+), 1 deletion(-) Reviewed-by: Walter Lozano Thanks! Walter > Applied to u-boot-dm, thanks!