From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v11 2/6] efi_loader: Drop setup_ok
Date: Thu, 18 Oct 2018 21:25:37 -0600 [thread overview]
Message-ID: <CAPnjgZ2VZZp930EqS_MHgnvSLsXLs88s+F20MZhHWao8Es=AQA@mail.gmail.com> (raw)
In-Reply-To: <152f1386-6646-46a5-14cf-293d8bc74f3c@gmx.de>
Hi,
On 15 October 2018 at 11:16, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> On 10/15/2018 04:17 PM, Simon Glass wrote:
>> This value is stored in data which appears to be read-only with sandbox on
>> my Ubuntu 18.04 machine. In any case it is not good practice to store
>> run-time data in a build-time linker list.
> Yes this should be changed. Otherwise a reset of the board will not put
> us back into the initial status.
>
>>
>> The value does not seem to be that useful, since tests that fail to setup
>> are likely to fail to run also. Let's drop it for now.
>
> With your change we will run execute() even if setup() fails. This
> contradicts the commit message. Please, find a solution that avoids
> calling execute() after a failed setup().
How about we just exit if setup() fails? It should not fail. The test
can fail, but not the setup.
Regards,
Simon
next prev parent reply other threads:[~2018-10-19 3:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 14:17 [U-Boot] [PATCH v11 0/6] efi_loader: Code refactoring and improvement Simon Glass
2018-10-15 14:17 ` [U-Boot] [PATCH v11 1/6] sandbox: Put CPUs under a cpu-bus node Simon Glass
2018-10-15 17:05 ` Heinrich Schuchardt
2018-10-15 14:17 ` [U-Boot] [PATCH v11 2/6] efi_loader: Drop setup_ok Simon Glass
2018-10-15 17:16 ` Heinrich Schuchardt
2018-10-19 3:25 ` Simon Glass [this message]
2018-10-19 5:53 ` Heinrich Schuchardt
2018-10-15 14:17 ` [U-Boot] [PATCH v11 3/6] sandbox: smbios: Update to support sandbox Simon Glass
2018-10-16 12:55 ` Alexander Graf
2018-10-19 3:25 ` Simon Glass
2018-10-19 7:27 ` Alexander Graf
2018-10-22 17:49 ` Simon Glass
2018-10-22 18:32 ` Alexander Graf
2018-11-04 18:39 ` Simon Glass
2018-10-15 14:17 ` [U-Boot] [PATCH v11 4/6] efi: Split out test init/uninit into functions Simon Glass
2018-10-15 17:34 ` Heinrich Schuchardt
2018-11-04 18:46 ` Simon Glass
2018-10-15 14:17 ` [U-Boot] [PATCH v11 5/6] efi: Create a function to set up for running EFI code Simon Glass
2018-10-15 14:17 ` [U-Boot] [PATCH v11 6/6] efi: Rename bootefi_test_finish() to bootefi_run_finish() Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ2VZZp930EqS_MHgnvSLsXLs88s+F20MZhHWao8Es=AQA@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.