Re: rk3399-gru-kevin: issues on bringup

[Simon Glass <sjg@chromium.org>]

Hi Alpher,

On Mon, 1 Nov 2021 at 17:25, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>
> Hi,
>
> I've had some recent success with my gru-kevin and wanted to update you
> on this. Long story short, I can boot from SPI flash and have the
> display, keyboard, eMMC, microSD card, USB disks all work (however with
> some hacks); but can't boot into Linux. Things seem to hang shortly
> after "Starting kernel..." but I don't know if something fails in U-Boot
> or if I get a kernel panic. (I still have no serial console).
>
> There are three relevant branches on my GitHub repo now, please have a
> look. The first is for what I intend to send upstream soon enough. The
> other two include hacks and additional patches that build on top of the
> first, meant to improve things on a per-board basis:
>
>     https://github.com/alpernebbi/u-boot/tree/rk3399-gru-chromebooks
>     https://github.com/alpernebbi/u-boot/tree/rk3399-gru-kevin
>     https://github.com/alpernebbi/u-boot/tree/rk3399-gru-bob
>
> I have no idea if the gru-bob versions work. I just thought things I did
> for gru-kevin are applicable to it as well and decided I should include
> them in case anyone wants to test.
>
>
> I also want to ask you some things I'm indecisive about, before posting
> the rk3399-gru-chromebooks branch as patches.
>
> Most of the patches are small config and dts changes that I've grouped
> by whatever effect they have. Should I squash them into one commit each
> for config/dts?

Probably best.

>
> Simon, I've edited some of your patches and kept you as author &
> sign-off. Are you OK with the edited versions, am I doing things right? See:
>
>
> https://github.com/alpernebbi/u-boot/commit/8c658b7811f4324cd699bd035e802f9339efa8f7
>
> https://github.com/alpernebbi/u-boot/commit/c2c68f23e10a51b8d34c00764a33fc847d785f60
>
> https://github.com/alpernebbi/u-boot/commit/995454193906e04bfb4e0e38f2bf1a18634a1ebf

LGTM

>
> Marty, your (second) chromebook_kevin support patch didn't have your
> sign-off. Is it OK to add it? See:
>
>
> https://github.com/alpernebbi/u-boot/commit/4cee351e012dc26714640e868069b5cc4b5a8329
>
> I also think I should squash my gru-kevin changes into that commit, add
> a commit message about board status, and keep Marty as author & sign-off
> while adding myself as Co-authored-by & sign-off. Any better ideas on
> how to structure the patches?
>
> Do both of you want to be in /board/google/gru/MAINTAINERS? I have three
> of us listed there right now, but no idea if that's fine with you two.
>
> Hope you can spare time on this.

I actually have bob in my lab but I have not tried the Chrome OS boot
script on it. I could probably add kevin.

$ do-try-int.sh bob
Revision 77680d8f85b94ffe690b8fe1f35767aef8b1415a, board bob

Checking revision 77680d8f85b94ffe690b8fe1f35767aef8b1415a
/vid/software/devel/ubtest
tbot starting ...
├─Parameters:
│     rev        = '77680d8f85b94ffe690b8fe1f35767aef8b1415a'
│     clean      = False
├─Calling uboot_build_and_flash ...
│   ├─bob is on port 9904 and uses /dev/pts/39
│   ├─POWERON (bob)
│   ├─Calling uboot_build ...
│   │   ├─Calling uboot_checkout ...
│   │   │   ├─Builder: bob
│   │   │   └─Done. (1.038s)
│   │   ├─Configuring build ...
│   │   ├─Calling uboot_make ...
│   │   │   └─Done. (9.073s)
│   │   └─Done. (10.454s)
│   ├─Calling uboot_flash ...
│   │   └─Done. (0.677s)
│   ├─POWEROFF (bob)
│   └─Done. (11.868s)
├─────────────────────────────────────────
└─SUCCESS (11.994s)
tbot starting ...
├─Calling interactive_board ...
│   ├─bob is on port 9904 and uses /dev/pts/39
│   ├─POWERON (bob)
│   ├─Entering interactive shell (CTRL+D to exit) ...
�Channel 0: LPDDR3, 933MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
Channel 1: LPDDR3, 933MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
256B stride

U-Boot SPL 2021.10-00181-g77680d8f85b (Nov 02 2021 - 09:07:44 -0600)
Trying to boot from SPI
rockchip_rk3399_pinctrl pinctrl: pinctrl_select_state_full:
uclass_get_device_by_phandle_id: err=-19
rockchip_rk3399_pinctrl pinctrl: pinctrl_select_state_full:
uclass_get_device_by_phandle_id: err=-19
ns16550_serial serial@ff1a0000: pinctrl_select_state_full:
uclass_get_device_by_phandle_id: err=-19


U-Boot 2021.10-00181-g77680d8f85b (Nov 02 2021 - 09:07:44 -0600)

Model: Google Bob
DRAM:  3.9 GiB
Cannot find regulator pwm init_voltage
MMC:   mmc@fe320000: 1, mmc@fe330000: 0
Loading Environment from MMC... *** Warning - bad CRC, using default environment

Got rc -1, expected 100
Failed to probe keyboard 'keyboard-controller'
In:    serial@ff1a0000
Out:   serial@ff1a0000
Err:   serial@ff1a0000
Model: Google Bob
Net:   No ethernet found.
Hit any key to stop autoboot:  0
=>

Regards,
Simon