From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13018C433F5 for ; Mon, 31 Jan 2022 22:59:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6E2CF80882; Mon, 31 Jan 2022 23:59:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="QUGIJtSD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 85B9D80882; Mon, 31 Jan 2022 23:59:24 +0100 (CET) Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4642C801EA for ; Mon, 31 Jan 2022 23:59:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe2e.google.com with SMTP id g23so13879333vsf.7 for ; Mon, 31 Jan 2022 14:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8zkpnysVWcsSunON5yM2bB2NriG8nsLI+LfL0vGsGms=; b=QUGIJtSDM8Vk17EoI2liTJnIlQ2Xhx+cHpJRaoW7LIIMb6QIqZf9wsQc+aclZy70L/ ZajEI9tyOBsqIJPFB04zhIm3Ix0eNaFirb0Trefng1rVQBLN80lFOEOy8SCQUjB30Nyx 0mMquv8onj96Jvt7L8XywpG3dnwGRMDfqjX3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8zkpnysVWcsSunON5yM2bB2NriG8nsLI+LfL0vGsGms=; b=6jclNMKwoDPni8XHokDgm2xR/Sqs1v2UloUIgS0R9+9ufVObHVnEsVTzTYU6TCLpFp H8kbakqxzaPi7EYDkhj9asiPpHb3PBMZWznZjuPYp+vsc5bVXQ7lUzPNhRpfWmy7v/sk z8bWnkuZ+8gYE0sxn0whDMNBcfPWqx1Dmya11Ve/OSMJg2IGcwA5c00auuFPeYzHzrf7 biko0KmMeaODzeVk7vn8rvxCzhbaVe3JyIdcN313KSYxu+yB+DY2Z/RlmG89bkvkvRYN 1SIELueQo/0RDDIUqXHBXYc7ueKvYUdSqQNsrCUvGFJZr3ug/uGESA39p1D3Ov8Oqg6v hKqw== X-Gm-Message-State: AOAM530gVz54YXeYkQc8I0aXEKUEzo+zAlTx2ZaR1cPsitcmgJOQP1Rc Yb5tnKfoWlSRBal49mupJWEZpjUk94HVUvPk561wOQ== X-Google-Smtp-Source: ABdhPJzbwd/hmL9KMEh2sJeS/2UFN28zLG/wve2ai6HzGsZy8La4x6+zMTJLGAt+xbhuuJqt/Jm5TY0Nx30Jbbsiv6I= X-Received: by 2002:a67:e0de:: with SMTP id m30mr8589150vsl.51.1643669959731; Mon, 31 Jan 2022 14:59:19 -0800 (PST) MIME-Version: 1.0 References: <20220130155225.726890-1-sjg@chromium.org> <20220130155225.726890-2-sjg@chromium.org> <20220131142412.GH7515@bill-the-cat> <20220131161544.GZ7515@bill-the-cat> <20220131180001.GC7515@bill-the-cat> <20220131204039.GG7515@bill-the-cat> <20220131220541.GH7515@bill-the-cat> In-Reply-To: <20220131220541.GH7515@bill-the-cat> From: Simon Glass Date: Mon, 31 Jan 2022 15:59:08 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] Makefile: Don't allow new boards with SPL_FIT_GENERATOR To: Tom Rini Cc: U-Boot Mailing List , Michal Simek , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , "NXP i . MX U-Boot Team" , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Tom, (yes Mark I am trying to stop further boards going in that use the shell scripts) On Mon, 31 Jan 2022 at 15:05, Tom Rini wrote: > > On Mon, Jan 31, 2022 at 02:22:41PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 31 Jan 2022 at 13:40, Tom Rini wrote: > > > > > > On Mon, Jan 31, 2022 at 12:57:57PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon, 31 Jan 2022 at 11:00, Tom Rini wrote: > > > > > > > > > > On Mon, Jan 31, 2022 at 10:27:41AM -0700, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > > > > > > > On Mon, 31 Jan 2022 at 09:15, Tom Rini wrote: > > > > > > > > > > > > > > On Mon, Jan 31, 2022 at 09:13:02AM -0700, Simon Glass wrote: > > > > > > > > Hi Tom, > > > > > > > > > > > > > > > > On Mon, 31 Jan 2022 at 07:24, Tom Rini wrote: > > > > > > > > > > > > > > > > > > On Sun, Jan 30, 2022 at 08:52:25AM -0700, Simon Glass wrote: > > > > > > > > > > > > > > > > > > > More than a year after this migration message appeared, we still have new > > > > > > > > > > boards being added with this option. Add a check against this. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > > > > > > > > > > > Please just make this an error in checkpatch.pl instead. > > > > > > > > > > > > > > > > I couldn't think of a way of doing that...do you have an idea? > > > > > > > > > > > > > > Yes, 2f3e8d6a86cb ("checkpatch: report ERROR only on disabling of fdt > > > > > > > and initrd relocation") updates the check I had for fdt_high/initrd_high > > > > > > > being in the file at all to only be for additions. And yes, I check > > > > > > > every PR for new checkpatch ERROR lines and only ignore the ones for > > > > > > > code imported from other projects. > > > > > > > > > > > > Yes, I understand that, but SPL_FIT_GENERATOR defaults to on for > > > > > > certain boards, so there is no need to mention it anywhere in the > > > > > > patch. Also someone could adjust the condition in the Kconfig to add > > > > > > other boards. > > > > > > > > > > Then you want something a bit more like the fdt|initrd_high check now, > > > > > along with updating the help around SPL_FIT_GENERATOR to note that this > > > > > option is deprecated, is the path forward then I think. > > > > > > > > I'm still a bit lost. > > > > > > > > What I want: break the build if someone adds a new board that uses > > > > SPL_FIT_GENERATOR > > > > > > > > What you are offering: checkpatch check for people adding that option > > > > > > > > But the patch doesn't generally include that option. > > > > > > > > I can certainly mention in the Kconfig help that the option is > > > > deprecated, but without checking if it is defined for a NEW board, I > > > > cannot prevent it from growing. > > > > > > > > What am I missing? Can you be more specific? > > > > > > How do you add a new board that enables SPL_FIT_GENERATOR without > > > "SPL_FIT_GENERATOR" being in the resulting patch, other than being > > > ARCH_ZYNQMP/ARCH_ROCKCHIP ? > > > > Well that's the case I am most concerned with, actually. Also, someone > > might add a new condition to SPL_FIT_GENERATOR. > > For the current cases, we just need to get them migrated since it's all > the same logic? So it would I think be a one-and-done thing. For a new Yes I think so and some of them are done. These are what I can find: ./arch/riscv/lib/mkimage_fit_opensbi.sh ./arch/arm/mach-zynqmp/mkimage_fit_atf.sh ./arch/arm/mach-imx/mkimage_fit_atf.sh ./arch/arm/mach-rockchip/make_fit_atf.py but they are not used by that many boards. I feel that the amount of pending migration is somewhat overwhelming and we should take a stronger line in mainline. Perhaps I should send a patch to simply remove the option? Would that be acceptable? Regards, Simon > conditional, it should trip checkpatch by having the words in it, and > also since the help would also say to not do this, and we already > generate a warning, it shouldn't be an issue? > > -- > Tom