From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 15 Oct 2020 09:05:53 -0600 Subject: [PATCH 00/33] stm32: enable logging features In-Reply-To: <20201014091646.4233-1-patrick.delaunay@st.com> References: <20201014091646.4233-1-patrick.delaunay@st.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Patrick, On Wed, 14 Oct 2020 at 03:16, Patrick Delaunay wrote: > > > This patch-set migrates several stm32 drivers to API compatible with > logging features (use dev_...() or log_...() function) and activate > the logging features in STM32MP15 boards. > > The size of U-Boot increased by 19kB (933026 to 952830 on STM32MP157C-EV1 > board for basic defconfig) but the boot time don't change drastically. > > For example on STM32MP157C-EV1 board: > > 1/ Before LOG patchset > > Timer summary in microseconds (12 records): > Mark Elapsed Stage > 0 0 reset > 224,514 224,514 SPL > 961,170 736,656 end SPL > 964,006 2,836 board_init_f > 1,186,986 222,980 board_init_r > 1,651,379 464,393 id=64 > 1,674,463 23,084 id=65 > 1,675,164 701 main_loop > 4,025,806 2,350,642 id=175 > > Accumulated time: > 55,064 dm_f > 66,749 dm_r > 88,796 dm_spl > > 2/ With LOG activated (after this patchset) > > Timer summary in microseconds (12 records): > Mark Elapsed Stage > 0 0 reset > 227,142 227,142 SPL > 984,585 757,443 end SPL > 987,579 2,994 board_init_f > 1,210,091 222,512 board_init_r > 1,673,354 463,263 id=64 > 1,696,073 22,719 id=65 > 1,696,775 702 main_loop > 5,443,104 3,746,329 id=175 > > Accumulated time: > 62,154 dm_f > 66,264 dm_r > 89,376 dm_spl > > For information even with all trace embbeded in U-Boot but not > activated, MAX_LOG_LEVEL=8 and LOG_DEFAULT_LEVEL=6 > > Size increase by 190KB (952830 to 1147918) but > boot time is stable (1,748s vs 1,696s). This seems pretty bad. Is this because of console output, or something else? I understand the size increase, but not the boot time increase. > > STM32MP> bootstage report > Timer summary in microseconds (12 records): > Mark Elapsed Stage > 0 0 reset > 230,028 230,028 SPL > 996,117 766,089 end SPL > 999,082 2,965 board_init_f > 1,220,225 221,143 board_init_r > 1,718,641 498,416 id=64 > 1,746,096 27,455 id=65 > 1,748,202 2,106 main_loop > 4,509,271 2,761,069 id=175 > > Accumulated time: > 58,481 dm_f > 68,881 dm_r > 89,385 dm_spl > > > > Patrick Delaunay (33): > arm: stm32mp: migrate trace to log macro > arm: stm32mp: migrate cmd_stm32prog to log macro > arm: stm32mp: bsec: migrate trace to log macro > pinctrl: stm32: migrate trace to log macro > gpio: stm32-gpio: migrate trace to dev and log macro > remoproc: stm32: migrate trace to log macro > ram: stm32: migrate trace to log macro > ram: stm32mp1: migrate trace to dev or log macro > mmc: stm32_sdmmc2: migrate trace to dev and log macro > timer: stm32: migrate trace to log macro > hwspinlock: stm32: migrate trace to log macro > rtc: stm32: migrate trace to log macro > watchdog: stm32mp: migrate trace to dev macro > power: regulator: stm32-verfbuf: define LOG_CATEGORY > misc: rcc: migrate trace to dev macro > misc: rcc: keep the rcc device name for subnode > clk: stm32mp1: migrate trace to dev and log macro > clk: clk_stm32f: migrate trace to dev and log macro > clk: clk_stm32h7: migrate trace to dev and log macro > reset: stm32-reset: migrate trace to dev and log macro > mailbox: stm32-ipcc: migrate trace to dev and log macro > i2c: stm32f7_i2c: migrate trace to dev and log macro > phy: stm32-usbphyc: migrate trace to dev and log macro > spi: stm32_spi: migrate trace to dev and log macro > spi: stm32_qspi: migrate trace to dev and log macro > mtd: stm32_fmc2: migrate trace to dev and log macro > memory: stm32-fmc2: migrate trace to dev and log macro > serial: stm32: define LOG_CATEGORY > video: stm32_ltdc: migrate trace to dev and log macro > video: stm32_dsi: migrate trace to dev and log macro > board: st: stm32mp1: migrate trace to dev and log macro > board: st: common: migrate trace to dev and log macro > configs: stm32mp15: enable LOG features > > arch/arm/mach-stm32mp/boot_params.c | 8 +- > arch/arm/mach-stm32mp/bsec.c | 38 +++-- > arch/arm/mach-stm32mp/cmd_stm32key.c | 3 +- > .../cmd_stm32prog/cmd_stm32prog.c | 4 +- > .../mach-stm32mp/cmd_stm32prog/stm32prog.c | 112 ++++++------- > .../mach-stm32mp/cmd_stm32prog/stm32prog.h | 2 +- > .../cmd_stm32prog/stm32prog_serial.c | 24 +-- > .../cmd_stm32prog/stm32prog_usb.c | 14 +- > arch/arm/mach-stm32mp/cpu.c | 18 ++- > arch/arm/mach-stm32mp/dram_init.c | 8 +- > arch/arm/mach-stm32mp/fdt.c | 17 +- > arch/arm/mach-stm32mp/pwr_regulator.c | 2 + > arch/arm/mach-stm32mp/spl.c | 16 +- > board/st/common/stm32mp_dfu.c | 3 +- > board/st/common/stm32mp_mtdparts.c | 5 +- > board/st/common/stpmic1.c | 5 +- > board/st/common/stusb160x.c | 2 + > board/st/stm32mp1/stm32mp1.c | 134 ++++++++-------- > configs/stm32mp15_basic_defconfig | 2 + > configs/stm32mp15_trusted_defconfig | 1 + > drivers/clk/clk_stm32f.c | 39 ++--- > drivers/clk/clk_stm32h7.c | 70 +++++---- > drivers/clk/clk_stm32mp1.c | 147 +++++++++--------- > drivers/gpio/stm32_gpio.c | 4 +- > drivers/hwspinlock/stm32_hwspinlock.c | 2 + > drivers/i2c/stm32f7_i2c.c | 74 ++++----- > drivers/mailbox/stm32-ipcc.c | 16 +- > drivers/memory/stm32-fmc2-ebi.c | 30 ++-- > drivers/misc/stm32_rcc.c | 10 +- > drivers/mmc/stm32_sdmmc2.c | 85 +++++----- > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 40 +++-- > drivers/phy/phy-stm32-usbphyc.c | 18 ++- > drivers/pinctrl/pinctrl_stm32.c | 30 ++-- > drivers/power/regulator/stm32-vrefbuf.c | 2 + > drivers/ram/stm32_sdram.c | 10 +- > drivers/ram/stm32mp1/stm32mp1_ddr.c | 36 +++-- > drivers/ram/stm32mp1/stm32mp1_interactive.c | 4 +- > drivers/ram/stm32mp1/stm32mp1_ram.c | 37 +++-- > drivers/ram/stm32mp1/stm32mp1_tests.c | 19 ++- > drivers/ram/stm32mp1/stm32mp1_tuning.c | 124 +++++++-------- > drivers/remoteproc/stm32_copro.c | 3 +- > drivers/reset/stm32-reset.c | 13 +- > drivers/rtc/stm32_rtc.c | 3 + > drivers/serial/serial_stm32.c | 3 + > drivers/spi/stm32_qspi.c | 46 +++--- > drivers/spi/stm32_spi.c | 31 ++-- > drivers/timer/stm32_timer.c | 2 + > drivers/video/stm32/stm32_dsi.c | 18 ++- > drivers/video/stm32/stm32_ltdc.c | 33 ++-- > drivers/watchdog/stm32mp_wdt.c | 9 +- > 50 files changed, 731 insertions(+), 645 deletions(-) > > -- > 2.17.1 > Regards, Simon