All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] regulator: Factor out common enable code
Date: Sat, 22 Jun 2019 20:10:21 +0100	[thread overview]
Message-ID: <CAPnjgZ2a+sLxNeKPLGJj4--xGUxrGEqpbDEtv6tGmTAuuknKvA@mail.gmail.com> (raw)
In-Reply-To: <20190612082617.24634-1-sven.schwermer@disruptive-technologies.com>

Hi,

On Wed, 12 Jun 2019 at 09:26, Sven Schwermer
<sven.schwermer@disruptive-technologies.com> wrote:
>
> In preparation of being able to enable/disable GPIO regulators, the
> code that will be shared among the two kinds to regulators is factored
> out into its own source files.
>
> Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
> ---
>  drivers/power/regulator/Kconfig            | 10 +++
>  drivers/power/regulator/Makefile           |  1 +
>  drivers/power/regulator/common-regulator.c | 80 ++++++++++++++++++++++
>  drivers/power/regulator/common-regulator.h | 27 ++++++++
>  drivers/power/regulator/fixed.c            | 75 ++------------------
>  5 files changed, 124 insertions(+), 69 deletions(-)
>  create mode 100644 drivers/power/regulator/common-regulator.c
>  create mode 100644 drivers/power/regulator/common-regulator.h

This looks fine but I think regulator_common.c (and the regulator
functions too) would be better.

Reviewed-by: Simon Glass <sjg@chromium.org>

  parent reply	other threads:[~2019-06-22 19:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 13:17 [U-Boot] fsl_esdhc: GPIO regulator as VQMMC supply? Sven Schwermer
2019-06-04  2:42 ` Peng Fan
2019-06-12  8:26   ` [U-Boot] [PATCH 1/2] regulator: Factor out common enable code Sven Schwermer
2019-06-12  8:26     ` [U-Boot] [PATCH 2/2] regulator: Allow enabling GPIO regulator Sven Schwermer
2019-06-22 19:10       ` Simon Glass
2019-06-22 19:10     ` Simon Glass [this message]
2019-06-12  8:39   ` [U-Boot] [PATCH 1/2] regulator: Factor out common enable code sven at svenschwermer.de
2019-06-12  8:39     ` [U-Boot] [PATCH 2/2] regulator: Allow enabling GPIO regulator sven at svenschwermer.de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ2a+sLxNeKPLGJj4--xGUxrGEqpbDEtv6tGmTAuuknKvA@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.