From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D2FFC4338F for ; Sun, 1 Aug 2021 19:20:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EBB060EE9 for ; Sun, 1 Aug 2021 19:20:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6EBB060EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4D55D832D4; Sun, 1 Aug 2021 21:19:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="aMgXe09b"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 67FFE8327C; Sun, 1 Aug 2021 21:19:46 +0200 (CEST) Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6713C83191 for ; Sun, 1 Aug 2021 21:19:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x333.google.com with SMTP id o2-20020a9d22020000b0290462f0ab0800so15483194ota.11 for ; Sun, 01 Aug 2021 12:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NNg+yl39fewQS/tYiDGcgrGSrq7/yz7xtjoIIVhBHMU=; b=aMgXe09b13dup1R/22XpjLKjybZKn8mJUxS3P5h+esOl5QwhnVtPApWtFsQtRc/KYj 6UbCH3leXd17n28TCGzEirWeTP2lbdSLQiZsupq6f7qsXo2edz7Wy/c+6cX26Bht/pqU tyOiqIvmyctIRavTRmsCiTDhY35YzqgvBEFcs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NNg+yl39fewQS/tYiDGcgrGSrq7/yz7xtjoIIVhBHMU=; b=lux2VXci+Z5pC3KilU/GGHgeobgbDyeRMvVs5oOyj9zb20HDvQz8UOblynzUmHOOy5 GQAQoXOnSy6TjEjIV2IV+WYIJfNe7+Btj+9RIjMXuvaCkXbGRQ8zuKaO1/pLTbblnh10 3HsA5JVCoHLf05VeeSZODU4b+6nvzWMdMTb5ZddwoF8HqPz9HFFC/yT/NtEJqtpzxVgZ iaN8rp/EF0tIWcnJOOjpYLdFcv8iYCqVIZnglOQdG1i6lMVMtUmbwQFn65F3dR2mTW/I HpUHjpZnHNKrWhbcPBQy56Crji+Ei2GxX2AincGaUlURUxncs0KzwJAMGy1wW3KPWZXp +/xQ== X-Gm-Message-State: AOAM533hxtC4XdkUQpoJ7qiaIryn4LiV6rrBpYTX8UgB5o1rQbv7U7SJ 1/AUpJ9oYpFvEhddr0dzp5JjJDDAZztJYQF9lgdV5w== X-Google-Smtp-Source: ABdhPJzO3ekztQA1OMnTtTz2X5yd/H2wFK2UGuE7dyQiHrAV9WyjTngK0Pqsj+Uw3igerCwqk+XwnZkXrEALu61MsUk= X-Received: by 2002:a05:6830:2317:: with SMTP id u23mr9162574ote.88.1627845581484; Sun, 01 Aug 2021 12:19:41 -0700 (PDT) MIME-Version: 1.0 References: <20210731084529.7524-1-bmeng.cn@gmail.com> <20210731084529.7524-6-bmeng.cn@gmail.com> In-Reply-To: <20210731084529.7524-6-bmeng.cn@gmail.com> From: Simon Glass Date: Sun, 1 Aug 2021 13:19:29 -0600 Message-ID: Subject: Re: [PATCH 5/7] x86: cmd: hob: Fix the command usage and help messages To: Bin Meng Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > At present the hob command usage and help messages are messed up > in a single line. They should be separated. > > This was a regression introduced when [seq] and [-v] were added > to the command. > > Fixes: d11544dfa9f4 ("x86: hob: Add way to show a single hob entry") > Fixes: 51af144eb7a0 ("x86: Allow showing details about a HOB entry") > Signed-off-by: Bin Meng > --- > > cmd/x86/hob.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass Tested on chromebook_coral, chromebook_samus, chromebook_link, minnowmax Tested-by: Simon Glass