From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34ABEC433F5 for ; Tue, 12 Oct 2021 14:08:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 237D760EFE for ; Tue, 12 Oct 2021 14:08:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 237D760EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1496A815B7; Tue, 12 Oct 2021 16:08:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="lYHd7WT3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DE09083477; Tue, 12 Oct 2021 16:08:31 +0200 (CEST) Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8AF7B80D28 for ; Tue, 12 Oct 2021 16:08:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92d.google.com with SMTP id h19so7264214uax.5 for ; Tue, 12 Oct 2021 07:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=aAGfrjwZe7Zzx/KiI7akPYwqwXaR2EBibOYqnTEts50=; b=lYHd7WT3YJMXbGzTj/u/J4SokAF0YR8Qk74nuvPkRfslDJzlCQlFdmqebPjp/oJ9+w t0v0PAoDsiuarFtJM5d7v2a+X53QtXZkawlmdgZiIZy97z7cBasFM/aeCCUO5I90ktO3 35opqGzXWBeuyeiMygFUYSmidDGyPeCfP5UQA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=aAGfrjwZe7Zzx/KiI7akPYwqwXaR2EBibOYqnTEts50=; b=V4of0VqwyFyVsHV+w6w0UcNgvPjxM+bTiRgIn7s24oeK2fiUBeEVJFZsd7VDcLmBUJ FYGCkFWKyU3Zabir6RS2Hor9Zmg3odURehXr/Fm79cNQXIbHIXBWJ1ZT5PniNFZa0GZn 7kvP4adRv6QRVwgHfc9K4cISTTk4OjRf8V1W5w16CGmE5g6fbLPPbU60HKJPgR6rHb7H RRK6+MH19DLtD0MtKIdIxpVkTNMrvgm8MsuSA/0yf6db5LuMdHysLlk1SQfG+CMeunk6 tWKFpDK7lMeYBLktPevTeaXB3qvq+GQTA0brVnP7V2I+zdad/NbBFaOuOj4iydEeLpl7 zL2A== X-Gm-Message-State: AOAM531Vy/DKb1VzMlUSLUwhtZiAu/BAtq0EvNHdxMx2CsG1cWYIgyaI 6dWaCBXF0Owpay3F59UdAqRN5TyILT+fQ0T8Jj1FVA== X-Google-Smtp-Source: ABdhPJx8Ir+aNidc7q26nGJqqGFxJbgEbjxSBnqPMipX47L3IG/0iiQtorNkFWQ3ixMJqZEKa9bK26s8Txe2nUQfQNI= X-Received: by 2002:a05:6102:38c6:: with SMTP id k6mr5724158vst.59.1634047705166; Tue, 12 Oct 2021 07:08:25 -0700 (PDT) MIME-Version: 1.0 References: <20211001050228.55183-1-takahiro.akashi@linaro.org> <20211001050228.55183-29-takahiro.akashi@linaro.org> <20211011065227.GI44356@laputa> <20211012010907.GA38222@laputa> In-Reply-To: <20211012010907.GA38222@laputa> From: Simon Glass Date: Tue, 12 Oct 2021 08:08:14 -0600 Message-ID: Subject: Re: [RFC 14/22] efi_loader: disk: a helper function to create efi_disk objects from udevice To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , Alex Graf , Ilias Apalodimas , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Akashi, On Mon, 11 Oct 2021 at 19:09, AKASHI Takahiro wrote: > > Simon, > > On Mon, Oct 11, 2021 at 08:54:06AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Mon, 11 Oct 2021 at 00:52, AKASHI Takahiro > > wrote: > > > > > > On Sun, Oct 10, 2021 at 08:14:21AM -0600, Simon Glass wrote: > > > > On Thu, 30 Sept 2021 at 23:04, AKASHI Takahiro > > > > wrote: > > > > > > > > > > Add efi_disk_create() function. > > > > > > > > > > Any UEFI handle created by efi_disk_create() can be treated as a efi_disk > > > > > object, the udevice is either a UCLASS_BLK (a whole raw disk) or > > > > > UCLASS_PARTITION (a disk partition). > > > > > > > > > > So this function is expected to be called every time such an udevice > > > > > is detected and activated through a device model's "probe" interface. > > > > > > > > > > Signed-off-by: AKASHI Takahiro > > > > > --- > > > > > include/efi_loader.h | 2 + > > > > > lib/efi_loader/efi_disk.c | 92 +++++++++++++++++++++++++++++++++++++++ > > > > > 2 files changed, 94 insertions(+) > > > > > > > > > > > > > Reviewed-by: Simon Glass > > > > > > > > But some nits below. > > > > > > > > Don't worry about !CONFIG_BLK - that code should be removed. > > > > > > Yes. I added a tentative patch to remove !CONFIG_BLK code in efi_disk > > > in patch#13. > > > > > > > > > > > diff --git a/include/efi_loader.h b/include/efi_loader.h > > > > > index c440962fe522..751fde7fb153 100644 > > > > > --- a/include/efi_loader.h > > > > > +++ b/include/efi_loader.h > > > > > @@ -517,6 +517,8 @@ efi_status_t EFIAPI efi_convert_pointer(efi_uintn_t debug_disposition, > > > > > void efi_carve_out_dt_rsv(void *fdt); > > > > > /* Called by bootefi to make console interface available */ > > > > > efi_status_t efi_console_register(void); > > > > > +/* Called when a block devices has been probed */ > > > > > +int efi_disk_create(struct udevice *dev); > > > > > > > > Please buck the trend in this file and add a full function comment. In > > > > this case it needs to cover @dev and the return value and also explain > > > > what the function does. > > > > > > OK. > > > > > > > > /* Called by bootefi to make all disk storage accessible as EFI objects */ > > > > > efi_status_t efi_disk_register(void); > > > > > /* Called by efi_init_obj_list() to install EFI_RNG_PROTOCOL */ > > > > > diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c > > > > > index cd5528046251..3fae40e034fb 100644 > > > > > --- a/lib/efi_loader/efi_disk.c > > > > > +++ b/lib/efi_loader/efi_disk.c > > > > > @@ -10,6 +10,7 @@ > > > > > #include > > > > > #include > > > > > #include > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > @@ -484,6 +485,7 @@ error: > > > > > return ret; > > > > > } > > > > > > > > > > +#ifndef CONFIG_BLK > > > > > /** > > > > > * efi_disk_create_partitions() - create handles and protocols for partitions > > > > > * > > > > > @@ -531,6 +533,96 @@ int efi_disk_create_partitions(efi_handle_t parent, struct blk_desc *desc, > > > > > > > > > > return disks; > > > > > } > > > > > +#endif /* CONFIG_BLK */ > > > > > + > > > > > +/* > > > > > + * Create a handle for a whole raw disk > > > > > + * > > > > > + * @dev uclass device > > > > > > > > ?? what type of device? > > > > > > (Will fix: UCLASS_BLK) > > > > > > > > > > > + * @return 0 on success, -1 otherwise > > > > > + */ > > > > > +static int efi_disk_create_raw(struct udevice *dev) > > > > > +{ > > > > > + struct efi_disk_obj *disk; > > > > > + struct blk_desc *desc; > > > > > + const char *if_typename; > > > > > + int diskid; > > > > > + efi_status_t ret; > > > > > + > > > > > + desc = dev_get_uclass_plat(dev); > > > > > + if_typename = blk_get_if_type_name(desc->if_type); > > > > > + diskid = desc->devnum; > > > > > + > > > > > + ret = efi_disk_add_dev(NULL, NULL, if_typename, desc, > > > > > + diskid, NULL, 0, &disk); > > > > > + if (ret != EFI_SUCCESS) { > > > > > > > > if (ret) > > > > > > > > is much shorter and easier to read > > > > > > Yeah, but I don't want to assume EFI_SUCCESS is *zero*. > > > > It is defined as 0 in 'Appendix D - Status Code' and cannot change, as > > I understand it. This is one of the things I don't like about the EFI > > code in U-Boot. Presumably the people who wrote the spec defined it as > > 0 to make use of C constructs. > > Yeah, I confirmed that, but still want to keep the code > as "ret != EFI_SUCCESS" is used everywhere in UEFI code :) OK that can be a clean-up for another day, along with the overly long types and naming in general. At least we managed to avoid all the capital letters and camel case... Regards, Simon