From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 4 Sep 2014 12:25:25 -0600 Subject: [U-Boot] [PATCH v9 0/14] Add some missing buildman features and deprecate MAKEALL In-Reply-To: References: <1408982315-18610-1-git-send-email-sjg@chromium.org> <20140825185459.GN19374@bill-the-cat> <20140825202118.GM19374@bill-the-cat> <20140828124801.GX19374@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On 31 August 2014 23:07, Simon Glass wrote: > Hi Tom, > > On 28 August 2014 05:48, Tom Rini wrote: > > On Tue, Aug 26, 2014 at 08:54:03PM -0600, Simon Glass wrote: > >> Hi Tom, > >> > >> On 25 August 2014 14:21, Tom Rini wrote: > >> > On Mon, Aug 25, 2014 at 01:00:05PM -0600, Simon Glass wrote: > >> >> Hi Tom, > >> >> > >> >> On 25 August 2014 12:54, Tom Rini wrote: > >> >> > On Mon, Aug 25, 2014 at 09:58:21AM -0600, Simon Glass wrote: > >> >> > > >> >> >> Buildman has been around for a little over a year and is used by > a fair > >> >> >> number of U-Boot developers. However quite a few people still use > MAKEALL. > >> >> >> > >> >> >> Buildman was intended to replace MAKEALL, so perhaps now is a > good time to > >> >> >> start that process. > >> >> >> > >> >> >> The reasons to deprecate MAKEALL are: > >> >> >> - We don't want to maintain two build systems > >> >> >> - Buildman is typically faster > >> >> >> - Buildman has a lot more features > >> >> >> > >> >> >> This series adds a few features to buildman to fill some gaps, > adds some > >> >> >> information into the README on how to migrate from MAKEALL, and > adds a > >> >> >> deprecation message to MAKEALL. > >> >> > > >> >> > I'm testing this out again in the Ubuntu 10.04 / LSF environment I > have > >> >> > access to but so far I'm still finding that test for --no-decorate > isn't > >> >> > working and I have to manually set it to False. > >> >> > >> >> Oh dear. I wrote a test for this in the second series. So if you > apply > >> >> that series, do the tests pass? It is in func_test.py and is called > >> >> testGitSetup(). > >> > > >> > With my local kludge removed yes, all tests pass. > >> > >> It's quite mysterious. I installed Ubuntu 10.04 and it runs python > 2.6.5. > >> > >> The --no-decorate patch does work, although it does print an error. I > >> could suppress that easily enough, just adding another arg > >> 'capture_stderr=True' to the RunPipe() call in gitutil.py.Setup(). > >> > >> I see a problem with timedelta not having total_seconds. After that > >> the threading dies. So I'm quite impressed you can get buildman to run > >> at all. Are you using one of the later 10.04 releases? > > > > *shakes fist at corporate IT* > > > > The box I use to launch jobs is Ubuntu 10.04.4. The boxes the jobs run > > on are actually Ubuntu 12.04.1 (I had assumed it was all the same for > > some reason. > > > > They also have git 1.7.9.5. > > Well they obviously can't make it *too* easy. So where does this leave > us in trying to figure this out? > It feels like we should probably get the current patches in and see where this leaves us. I'll work on a pull request, unless you think we should wait. Regards, Simon