From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E80BC07E9C for ; Mon, 5 Jul 2021 15:30:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12D8B61995 for ; Mon, 5 Jul 2021 15:30:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12D8B61995 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4EC9882C06; Mon, 5 Jul 2021 17:30:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ACpuxvFw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9C57082BF3; Mon, 5 Jul 2021 17:30:15 +0200 (CEST) Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6C5A482BF7 for ; Mon, 5 Jul 2021 17:30:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oo1-xc2a.google.com with SMTP id o3-20020a4a84c30000b0290251d599f19bso1915273oog.8 for ; Mon, 05 Jul 2021 08:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MxdJQZQ5cIbOFgZXMCKpjGTkFt3fUspa2S721i3MN4Y=; b=ACpuxvFwGwFkfhJNiO35Xc5uZuoZuH/+pic/opBb5W/fZm3RBrMcK7+klWuYDB1hhI un3eFz964HijqKjoCdXQJ7RXfnnK4KY5T55ZHeXAvm6bo8Mo5m/mM6gtZkwpEuHxNjvO /CVnMkR86lms0UTUk7TM8ySfYXD1HpJXFuBCs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MxdJQZQ5cIbOFgZXMCKpjGTkFt3fUspa2S721i3MN4Y=; b=XAXe7UopLqNvzUA22thalAA0izC6L1HTTw9C95z+x4ZVSqa2SBQlRHQ7UJRRIw3Gow W4nEaShnlX9mIylXrQqBw0E1GVdNVaGzTyT1jjyAYiPiBIZLuwMlnSTjoxJLCigeBoIR 4jTpCuL3NluyzS46CRiP9PlwbvC508dHFCXF9HTCcOoRZbv85VONG43Y6i1sN83+iCxp GikOK6e2sJnkuP94ZpgDpyzAp6pnIZBOw9aK/s2gsBgXonbdklSd9jcBw031C6xq+Zw8 t41Z9smoTW7eQQo5GeS+26WfQ6M2dIgJ2d9JUK/rNIpzbUQNzIIBowKdp8LRetO6908D +1AA== X-Gm-Message-State: AOAM532P9eK/Fq363yMwY8urivp4Rkq8OGYV5zOuT5D68seot2CACpAa nhVDwb+G8By+0NY9/O9QccExdOqYl/UgeRTxAV+CEw== X-Google-Smtp-Source: ABdhPJyzNrj7MybwGzSRdkI1GjTASpZkAOCUam3Cmo82FtNNpqop6+I5TLpQGFEFzp1Zp5ls9WRO6zMsKnPPgOpduBQ= X-Received: by 2002:a4a:b203:: with SMTP id d3mr10385674ooo.55.1625499008540; Mon, 05 Jul 2021 08:30:08 -0700 (PDT) MIME-Version: 1.0 References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-14-seanga2@gmail.com> In-Reply-To: <20210701061611.957918-14-seanga2@gmail.com> From: Simon Glass Date: Mon, 5 Jul 2021 09:29:52 -0600 Message-ID: Subject: Re: [RFC PATCH 13/28] cli: lil: Wire up LIL to the rest of U-Boot To: Sean Anderson Cc: U-Boot Mailing List , Tom Rini , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Wolfgang Denk , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Sean, On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > This sets the shell to LIL when CONFIG_LIL is enabled. Repeated commands > are not supporteed. Neither are partial commands a la Hush's secondary > prompt. Setting and getting environmental variables is done through > callbacks to assist with testing. > > Signed-off-by: Sean Anderson > --- > > cmd/Kconfig | 12 +++++-- > common/cli.c | 84 +++++++++++++++++++++++++++++++++++++++--------- > common/cli_lil.c | 32 ++++++++++++++++++ > 3 files changed, 111 insertions(+), 17 deletions(-) Can you try using if() instead of #ifdef in here? Regards, Simon