All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH 5/5] clk: add enable() callback
Date: Mon, 28 Dec 2015 07:20:44 -0700	[thread overview]
Message-ID: <CAPnjgZ2hHnv84wEdiLFmrTN0h9Lt_qsvV1xicf3_bi2WmR9m1g@mail.gmail.com> (raw)
In-Reply-To: <1450778671-21134-6-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

On 22 December 2015 at 03:04, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> The most basic thing for clock is to enable it, but it is missing
> in this uclass.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  include/clk.h | 9 +++++++++
>  1 file changed, 9 insertions(+)

Acked-by: Simon Glass <sjg@chromium.org>

Thinking ahead, should we have disable() also, or maybe replacing both
with set_enable(bool enable) would be better?

>
> diff --git a/include/clk.h b/include/clk.h
> index 518cb47..ce2db41 100644
> --- a/include/clk.h
> +++ b/include/clk.h
> @@ -33,6 +33,15 @@ struct clk_ops {
>         ulong (*set_rate)(struct udevice *dev, ulong rate);
>
>         /**
> +        * enable() - Enable the clock for a peripheral
> +        *
> +        * @dev:        clock provider
> +        * @periph:     Peripheral ID to enable
> +        * @return zero on success, or -ve error code
> +        */
> +       int (*enable)(struct udevice *dev, int periph);
> +
> +       /**
>          * get_periph_rate() - Get clock rate for a peripheral
>          *
>          * @dev:        Device to check (UCLASS_CLK)
> --
> 1.9.1
>

Regards,
Simon

  reply	other threads:[~2015-12-28 14:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22 10:04 [U-Boot] [RESEND PATCH 0/5] clk: some fixes, device tree support, new features Masahiro Yamada
2015-12-22 10:04 ` [U-Boot] [RESEND PATCH 1/5] clk: fix comments in include/clk.h Masahiro Yamada
2015-12-28  4:19   ` Simon Glass
2015-12-22 10:04 ` [U-Boot] [RESEND PATCH 2/5] clk: add needed include and declaration to include/clk.h Masahiro Yamada
2015-12-28  4:19   ` Simon Glass
2015-12-22 10:04 ` [U-Boot] [RESEND PATCH 3/5] clk: add function to get peripheral ID Masahiro Yamada
2015-12-28 14:20   ` Simon Glass
2015-12-28 17:05     ` Masahiro Yamada
2015-12-22 10:04 ` [U-Boot] [RESEND PATCH 4/5] clk: add device tree support for clock framework Masahiro Yamada
2015-12-28  4:23   ` Simon Glass
2015-12-28 14:20     ` Simon Glass
2015-12-28 17:06       ` Masahiro Yamada
2016-01-15 13:22         ` Simon Glass
2015-12-22 10:04 ` [U-Boot] [RESEND PATCH 5/5] clk: add enable() callback Masahiro Yamada
2015-12-28 14:20   ` Simon Glass [this message]
2015-12-28 17:06     ` Masahiro Yamada
2015-12-22 20:27 ` [U-Boot] [RESEND PATCH 0/5] clk: some fixes, device tree support, new features Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ2hHnv84wEdiLFmrTN0h9Lt_qsvV1xicf3_bi2WmR9m1g@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.