All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 07/10] binman: Support reading an image with entry args
Date: Sat, 23 Jan 2021 09:27:05 -0800	[thread overview]
Message-ID: <CAPnjgZ2hah2HrLbYPh6WwEmvR4RkKqEAy=KaLaFwAV5SL9Z2XQ@mail.gmail.com> (raw)
In-Reply-To: <20210106213503.7.I1e24d731dc789a02dc72134d1beac84f24830eb8@changeid>

Normally when an entry is created, any entry arguments it has are required
to be provided, so it can actually generate its contents correctly.

However when an existing image is read, Entry objects are created for each
of the entries in the image. This happens as part of the process of
reading the image into binman.

In this case we don't need the entry arguments, since we do not intend to
regenerate the entries, or at least not unless requested. So there is no
sense in reporting an error for missing entry arguments.

Add a new property for the Image to handle this case. Update the error
reporting to be conditional on this property.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/binman/entry.py                    |  3 +--
 tools/binman/etype/section.py            | 15 +++++++++++++++
 tools/binman/ftest.py                    | 19 +++++++++++++++++++
 tools/binman/image.py                    | 10 ++++++++--
 tools/binman/test/188_image_entryarg.dts | 21 +++++++++++++++++++++
 5 files changed, 64 insertions(+), 4 deletions(-)
 create mode 100644 tools/binman/test/188_image_entryarg.dts

Applied to u-boot-dm, thanks!

  parent reply	other threads:[~2021-01-23 17:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  4:35 [PATCH 00/10] binman: Various minor fixes and improvement Simon Glass
2021-01-07  4:35 ` [PATCH 01/10] dtoc: binman: Drop Python 2 code Simon Glass
2021-01-07  4:35 ` [PATCH 02/10] patman: Correct lz4 compression parameters Simon Glass
2021-01-07  4:35 ` [PATCH 03/10] binman: Update the TODO list Simon Glass
2021-01-07  4:35 ` [PATCH 04/10] binman: Show the size when writing entries Simon Glass
2021-01-07  4:35 ` [PATCH 05/10] binman: Fix a few file comments Simon Glass
2021-01-07  4:35 ` [PATCH 06/10] binman: Support finding symbols in sub-sections Simon Glass
2021-01-07  4:35 ` [PATCH 07/10] binman: Support reading an image with entry args Simon Glass
2021-01-07  4:35 ` [PATCH 08/10] binman: Allow vblock to include devicetree blobs Simon Glass
2021-01-07  4:35 ` [PATCH 09/10] binman: Support alignment of files Simon Glass
2021-01-07  4:35 ` [PATCH 10/10] binman: Allow for skip_at_start when reading entries Simon Glass
2021-01-23 17:27 ` Simon Glass
2021-01-23 17:27 ` [PATCH 09/10] binman: Support alignment of files Simon Glass
2021-01-23 17:27 ` [PATCH 08/10] binman: Allow vblock to include devicetree blobs Simon Glass
2021-01-23 17:27 ` Simon Glass [this message]
2021-01-23 17:27 ` [PATCH 05/10] binman: Fix a few file comments Simon Glass
2021-01-23 17:27 ` [PATCH 06/10] binman: Support finding symbols in sub-sections Simon Glass
2021-01-23 17:27 ` [PATCH 04/10] binman: Show the size when writing entries Simon Glass
2021-01-23 17:27 ` [PATCH 03/10] binman: Update the TODO list Simon Glass
2021-01-23 17:27 ` [PATCH 02/10] patman: Correct lz4 compression parameters Simon Glass
2021-01-23 17:27 ` [PATCH 01/10] dtoc: binman: Drop Python 2 code Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ2hah2HrLbYPh6WwEmvR4RkKqEAy=KaLaFwAV5SL9Z2XQ@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.