From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37CCAC433EF for ; Mon, 11 Oct 2021 14:54:47 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ED0E60ED4 for ; Mon, 11 Oct 2021 14:54:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4ED0E60ED4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6C6F2836F3; Mon, 11 Oct 2021 16:54:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="BLUDGTdv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 489D083196; Mon, 11 Oct 2021 16:54:23 +0200 (CEST) Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E913F831DB for ; Mon, 11 Oct 2021 16:54:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x933.google.com with SMTP id r17so5044890uaf.8 for ; Mon, 11 Oct 2021 07:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=R0VK9BQf/f1+SlY4R+dexhy1QfOSEHA2/Jj0uR3lGqM=; b=BLUDGTdvVA2WZnte5lJ0yav8Au/7edXiXs1taW10Am3piMfNywyDziEUs8+FKBbtSu peyDBC1mUKKobKWa0JhH7eei393YMAoSQ1SCq6F716rpDXuemFnvZG+VFbr0A1e1bGvx BCCtJDNXawPC5zRlGqfczROLkILzwsStbWCJY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=R0VK9BQf/f1+SlY4R+dexhy1QfOSEHA2/Jj0uR3lGqM=; b=0v4Tb/Ho4AEK4ZZH5l0eQH0uaIOpp8eQ6VLUBXLUwajHoFi2fVDxQ6jrCvBh7m+fh6 Kc8wXlfbJ6EWlKLNI0lkn1XhhQlXssNROW9sUipuaUKRZJhGLLbKl7o6znluTN20HsV8 eAJiufTykfeLVZP/WNpjegIkNRYPJDthb+NAFMlN9KgYITKzGASSBcQ9hJBPGl2paxeB OGC6bf0/M+9XUFdWzwrTCVoIDiWogyyDioWdgO+rtM97Ek5Mq0CqROuIhR+WWD8zKt4x cmQSHD9Tp8MXFb4HyhHFzL/14ekomB3Prjp9F0zM8IInl0ceoBQnHAm9uSWKJBsolons hRUw== X-Gm-Message-State: AOAM531/MMTNzq18wKuZN/igI807mhqWvYi0O7F8KPaCVmjHr3R3b9VA 36A+cn17WoXowTUYTj7U+cF80HRULxO4rBQkPAaIEQ== X-Google-Smtp-Source: ABdhPJyjb7V9+YYvq4Ev6p1FPDHlcr8RjeKQwOxE34xxKngkuRsaJkJM8jin3zyvz6blZq1tivNEzaWWKOd2/y23rLo= X-Received: by 2002:a67:f801:: with SMTP id l1mr23379922vso.59.1633964058358; Mon, 11 Oct 2021 07:54:18 -0700 (PDT) MIME-Version: 1.0 References: <20211001050228.55183-1-takahiro.akashi@linaro.org> <20211001050228.55183-29-takahiro.akashi@linaro.org> <20211011065227.GI44356@laputa> In-Reply-To: <20211011065227.GI44356@laputa> From: Simon Glass Date: Mon, 11 Oct 2021 08:54:06 -0600 Message-ID: Subject: Re: [RFC 14/22] efi_loader: disk: a helper function to create efi_disk objects from udevice To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , Alex Graf , Ilias Apalodimas , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Takahiro, On Mon, 11 Oct 2021 at 00:52, AKASHI Takahiro wrote: > > On Sun, Oct 10, 2021 at 08:14:21AM -0600, Simon Glass wrote: > > On Thu, 30 Sept 2021 at 23:04, AKASHI Takahiro > > wrote: > > > > > > Add efi_disk_create() function. > > > > > > Any UEFI handle created by efi_disk_create() can be treated as a efi_disk > > > object, the udevice is either a UCLASS_BLK (a whole raw disk) or > > > UCLASS_PARTITION (a disk partition). > > > > > > So this function is expected to be called every time such an udevice > > > is detected and activated through a device model's "probe" interface. > > > > > > Signed-off-by: AKASHI Takahiro > > > --- > > > include/efi_loader.h | 2 + > > > lib/efi_loader/efi_disk.c | 92 +++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 94 insertions(+) > > > > > > > Reviewed-by: Simon Glass > > > > But some nits below. > > > > Don't worry about !CONFIG_BLK - that code should be removed. > > Yes. I added a tentative patch to remove !CONFIG_BLK code in efi_disk > in patch#13. > > > > > diff --git a/include/efi_loader.h b/include/efi_loader.h > > > index c440962fe522..751fde7fb153 100644 > > > --- a/include/efi_loader.h > > > +++ b/include/efi_loader.h > > > @@ -517,6 +517,8 @@ efi_status_t EFIAPI efi_convert_pointer(efi_uintn_t debug_disposition, > > > void efi_carve_out_dt_rsv(void *fdt); > > > /* Called by bootefi to make console interface available */ > > > efi_status_t efi_console_register(void); > > > +/* Called when a block devices has been probed */ > > > +int efi_disk_create(struct udevice *dev); > > > > Please buck the trend in this file and add a full function comment. In > > this case it needs to cover @dev and the return value and also explain > > what the function does. > > OK. > > > > /* Called by bootefi to make all disk storage accessible as EFI objects */ > > > efi_status_t efi_disk_register(void); > > > /* Called by efi_init_obj_list() to install EFI_RNG_PROTOCOL */ > > > diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c > > > index cd5528046251..3fae40e034fb 100644 > > > --- a/lib/efi_loader/efi_disk.c > > > +++ b/lib/efi_loader/efi_disk.c > > > @@ -10,6 +10,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -484,6 +485,7 @@ error: > > > return ret; > > > } > > > > > > +#ifndef CONFIG_BLK > > > /** > > > * efi_disk_create_partitions() - create handles and protocols for partitions > > > * > > > @@ -531,6 +533,96 @@ int efi_disk_create_partitions(efi_handle_t parent, struct blk_desc *desc, > > > > > > return disks; > > > } > > > +#endif /* CONFIG_BLK */ > > > + > > > +/* > > > + * Create a handle for a whole raw disk > > > + * > > > + * @dev uclass device > > > > ?? what type of device? > > (Will fix: UCLASS_BLK) > > > > > + * @return 0 on success, -1 otherwise > > > + */ > > > +static int efi_disk_create_raw(struct udevice *dev) > > > +{ > > > + struct efi_disk_obj *disk; > > > + struct blk_desc *desc; > > > + const char *if_typename; > > > + int diskid; > > > + efi_status_t ret; > > > + > > > + desc = dev_get_uclass_plat(dev); > > > + if_typename = blk_get_if_type_name(desc->if_type); > > > + diskid = desc->devnum; > > > + > > > + ret = efi_disk_add_dev(NULL, NULL, if_typename, desc, > > > + diskid, NULL, 0, &disk); > > > + if (ret != EFI_SUCCESS) { > > > > if (ret) > > > > is much shorter and easier to read > > Yeah, but I don't want to assume EFI_SUCCESS is *zero*. It is defined as 0 in 'Appendix D - Status Code' and cannot change, as I understand it. This is one of the things I don't like about the EFI code in U-Boot. Presumably the people who wrote the spec defined it as 0 to make use of C constructs. [..] Regards, Simon