From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F3EC433EF for ; Tue, 19 Oct 2021 16:15:14 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A31616113D for ; Tue, 19 Oct 2021 16:15:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A31616113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EC6D283278; Tue, 19 Oct 2021 18:15:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="b60img+s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6BE1383296; Tue, 19 Oct 2021 18:15:04 +0200 (CEST) Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 74B0F81197 for ; Tue, 19 Oct 2021 18:14:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92f.google.com with SMTP id f3so945375uap.6 for ; Tue, 19 Oct 2021 09:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yNOovfs+TZ5Bwq2itBOZIZuZD1p0i+BnQI9tVu5VJFk=; b=b60img+s+YAPMU2AImILyy5m4l56u2NaK5Z/p/db8bcA+gA4aEuq/zibKBPzDkLtNR lTZ7cf/ZJlFdD3y4c5ts5NGT0bZdR9aDYsUoUwDM2IZsR3Rinx3oqQbJXmauoPPyRTXB K5jE6U8HuTuogpXEqRx1RqmHUOqalcWP1U7nM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yNOovfs+TZ5Bwq2itBOZIZuZD1p0i+BnQI9tVu5VJFk=; b=iQsWTaeFQeRBTSMRe2vzvO4+7B3/GOpUTYnQYZrgR/tOFm1jT9WsA42i65cUiUmA2i UH0BSDgJqfATPkbWpxATSf8eUytyBkzvLodf4lE3v3Oopqbihyxbmv6dhr6atYAfLsf3 4gqOswaEOnvq9k808YqdTNmkFY2Mg4ZCGSfx1gChWd+qDMbY1C1Q3CAfRoW+WoYUsNCF MkL7wFSescI/xl/XyZI10OYLRZoV4jpMiIkgNIRL3TZ91l57UZtksBe4POI+p1e+qRS4 oG6jyB/bF3Xs8J9QdZId1X2laYzXBoz5fOZaVD/H8lHfZE0tqPeGemcbYqsQSGpXj+9i +f+A== X-Gm-Message-State: AOAM533Bz+LeXyOKOx13BDYQiCyPUMlPuWtDJNV6HcyzkyTHetTJrDum 4X3C8COPzaoOo7oVPgBOLqJDLLrdHzhZs+Jp2gMcLg== X-Google-Smtp-Source: ABdhPJycQm3oiiGiQNQKwlcFemmcC+0igr2MXM2zW5LZKykXzT8+mFQC301uI+kT2yJZmh7UltL2bhpLYLIEoYPs1q0= X-Received: by 2002:ab0:5b99:: with SMTP id y25mr902605uae.47.1634660095943; Tue, 19 Oct 2021 09:14:55 -0700 (PDT) MIME-Version: 1.0 References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> <3496103.1634558337@gemini.denx.de> <3546427.1634640369@gemini.denx.de> <3573552.1634659743@gemini.denx.de> In-Reply-To: <3573552.1634659743@gemini.denx.de> From: Simon Glass Date: Tue, 19 Oct 2021 10:14:44 -0600 Message-ID: Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file To: Wolfgang Denk Cc: U-Boot Mailing List , Heinrich Schuchardt , Tom Rini , Joe Hershberger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Wolfgang, On Tue, 19 Oct 2021 at 10:09, Wolfgang Denk wrote: > > Dear Simon, > > In message you wrote: > > > > I thought you were trying to use + at the end of a variable. > > > > I used: > > > > fred\+=aaa > > > > and got > > > > cc1: warning: unknown escape sequence: '\='' > > > > You can try it yourself by editing sandbox.env in the > > u-boot-dm/env-working tree. > > Hmmm... > > -> cat foo.c > #define A ampersand > #define B berta > > foo\+=B; > -> gcc -E foo.c > # 0 "foo.c" > # 0 "" > # 0 "" > # 1 "/usr/include/stdc-predef.h" 1 3 4 > # 0 "" 2 > # 1 "foo.c" > > > > foo\+=berta; > > > > -> cat bar.c > fred\+=aaa > -> gcc -E bar.c > # 0 "bar.c" > # 0 "" > # 0 "" > # 1 "/usr/include/stdc-predef.h" 1 3 4 > # 0 "" 2 > # 1 "bar.c" > fred\+=aaa > > > I do not see this problem... Would you mind actually trying it in the env file, as I suggested? Regards, Simon