From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54AC4C433F5 for ; Sun, 24 Oct 2021 19:56:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C526360EE3 for ; Sun, 24 Oct 2021 19:56:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C526360EE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 46F5783549; Sun, 24 Oct 2021 21:55:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="cWi0dNcA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EADE2834CD; Sun, 24 Oct 2021 21:54:07 +0200 (CEST) Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D3B4282EBB for ; Sun, 24 Oct 2021 21:53:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92b.google.com with SMTP id k28so13702903uaa.10 for ; Sun, 24 Oct 2021 12:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xRjwpAhosF2HxesygupYFSoQJezga5MzIu04i+U7awg=; b=cWi0dNcA1431nDlzGcaFDyR9JLQ3sGiuiVSS98CVZkR0QEXtJOop8/v4WBrF7QXORs /Xl8+0oVDq7EQXzabRsN9hUD0CWHLrR6yj/CBivWgSACDyI5gDdG91Y58DO5Zz803wgX oYKHJIGjaz9Vi/XxrE6yCrW4nkIBr5LGmMHsk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xRjwpAhosF2HxesygupYFSoQJezga5MzIu04i+U7awg=; b=u8/hmNkMLYy0ZYPAjMv17WhI6GWiCpi8RB2twf4TVKdGKDvBRdtPiBNZ1TQyB4pcjI hHAySUM+i7okQ2NuwTYx/tKnxBhk8M/0xJtKWbeV/0SoBpFWz1hCrEcgZuSPRn7ggQyn HRH9KOZmYf3+S2/QbPIagLV1oMscZz0oimT7XNW+dhA0laWxW/kLujbC43qh0R8cNjXQ nMr6V8k6rbDOrYPh/cE7g0+sImam1RUfKYkPSB22VqsJ20g8gEt6o41MOcGr4iyUkdNh SdtkDrOZJrqVgdD0NXjcMjWndmNSce+mQ7lmYQBJYJMcTZ7IS1u9uzw053FlLREySOmv 7lmA== X-Gm-Message-State: AOAM532asj/JiOQ2SdTTPxICGyMykV4mt7nGrNDgdIIT3ny26KY0wnln /Nk20C/dJsDJ49+vpuV7JPPvfjWsNtIdWF5zozk/Lw== X-Google-Smtp-Source: ABdhPJyHPrBleITx6Ev2Z62pEjDeQGF2BrP/orruyZzDMZGZjs8mvQnHERdZUToUE8DKrfun04ixYftRJvxu8U7rdic= X-Received: by 2002:a05:6130:305:: with SMTP id ay5mr406161uab.140.1635105236533; Sun, 24 Oct 2021 12:53:56 -0700 (PDT) MIME-Version: 1.0 References: <20211014182257.468649-1-sjg@chromium.org> <20211014182257.468649-6-sjg@chromium.org> <3343692.1634309144@gemini.denx.de> In-Reply-To: <3343692.1634309144@gemini.denx.de> From: Simon Glass Date: Sun, 24 Oct 2021 13:53:43 -0600 Message-ID: Subject: Re: [PATCH v6 7/7] bootm: Tidy up use of autostart env var To: Wolfgang Denk Cc: U-Boot Mailing List , Heinrich Schuchardt , Tom Rini Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Wolfgang, On Fri, 15 Oct 2021 at 08:45, Wolfgang Denk wrote: > > Dear Simon Glass, > > In message <20211014182257.468649-6-sjg@chromium.org> you wrote: > > This has different semantics in different places. Go with the bootm method > > and put it in a common function so that the behaviour is consistent in > > U-Boot. Update the docs. > > > > Signed-off-by: Simon Glass > > Suggested-by: Wolfgang Denk > > It should be noted that this commit changes the behaviour of U-Boot > for "autostart" users, thus it has the potential of breaking > existent systems. > > The problematic cases are in do_bootelf() [cmd/elf.c] and > do_bootm_standalone() [common/bootm_os.c]; the 3rd place where this > is used - bootm_maybe_autostart() [cmd/bootm.c] - does not change. > > Or am I missing something? Just to reply here, I sent an updated patch explaining that this does in fact change behaviour, but only in a case that seems safe enough. Regards, Simon