From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4CDBC61DA4 for ; Wed, 15 Mar 2023 14:09:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BC01885E42; Wed, 15 Mar 2023 15:09:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Ui8CQJOg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A7C5D86263; Wed, 15 Mar 2023 15:09:23 +0100 (CET) Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3954385E42 for ; Wed, 15 Mar 2023 15:09:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-536af432ee5so371577967b3.0 for ; Wed, 15 Mar 2023 07:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1678889352; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4HvxiaL7gUHJmxyYk1SD8uWPm1GIJumbdk+mHW0fRds=; b=Ui8CQJOgDf9v8vadaYq8L5JWk6jWZKVvWDn8eOE2ajDlnqO4/0HH018m2Rp5JLadYn oTOOcfwCNcL+dfsSyLzRBCdp7ke1Z7i1IiWg7YNLDo1vb9DN+OUDZ0kneThTOnfQzeko 1wbIt04pKriDFafZUP6wtt5p/xP7VncHEBQgg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678889352; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4HvxiaL7gUHJmxyYk1SD8uWPm1GIJumbdk+mHW0fRds=; b=OxdO0DUFNlVbDOtTR05ZyqNR7pn/UA4VBShxfHzJMoBYS2XjYJwjjo8xe+6VFi+tqF slQH+F9nMiNWnNb0nwKT0h2PFAZlCKT9bPqr1+CT3KLYSJsEvMZWhFa9hgn2q/JeSZSy kPH+uPcGkelGguBph/ukjRQkpJN6C/2Oicqn5IHQPGX3jqW9+mDGOXqI46WumO4OQLRV nbquTuvHbk7fej4C2wmpyRSonDVkMjtP9Cw31pI6l104t8jA5dLpFD1nCMWyR1PJcdx3 cTiZmS5EAKZECL1J40WspcqPgCtoPBAe3etDQZGt+NjY8E9aSA2O+TULFmJ5DoarQbnC CO9A== X-Gm-Message-State: AO0yUKUfoqsWDsqFo+V6/gshhTNsr0dfa+k5GWhCoPcjMBpJPPotEtJM nTQ81FYA2Z3Bra/CmktA/vH3f4qqJsQJZjMWjOYN8Q== X-Google-Smtp-Source: AK7set/N1VjY3GbT0ej+oDxuvQ5BZ8FahklushOxWgxcNVH+aN1OyOYLHFd+P+pqbjbal5mie1HQ8iPakaEFpM5yt5o= X-Received: by 2002:a81:ed06:0:b0:540:e6c5:5118 with SMTP id k6-20020a81ed06000000b00540e6c55118mr36428ywm.2.1678889351660; Wed, 15 Mar 2023 07:09:11 -0700 (PDT) MIME-Version: 1.0 References: <20230313101459.58986-1-n-jain1@ti.com> In-Reply-To: From: Simon Glass Date: Wed, 15 Mar 2023 08:08:59 -0600 Message-ID: Subject: Re: [PATCH 0/9] Enable splash screen To: Nikhil M Jain Cc: u-boot@lists.denx.de, agust@denx.de, devarsht@ti.com, trini@konsulko.com, vigneshr@ti.com, nsekhar@ti.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Nikhil, On Wed, 15 Mar 2023 at 00:07, Nikhil M Jain wrote: > > Hi Simon, > > On 15/03/23 03:38, Simon Glass wrote: > > Hi Nikhil, > > > > On Mon, 13 Mar 2023 at 04:15, Nikhil M Jain wrote: > >> > >> To enable splash screen at SPL stage move video driver and splash screen > >> framework at SPL, which will bring up image on display very quickly and > >> thus have early display support in SPL. > >> > >> Nikhil M Jain (9): > >> drivers: video: Kconfig: Necessary configs for video at SPL > >> drivers: video: tidss: Kconfig: Configs to enable TIDSS at SPL > >> cmd: Kconfig: Add necessary configs for splash screen at SPL > >> drivers: video: Makefile: Compile video driver files at SPL > >> drivers: video: tidss: Makefile: Add condition to compile TIDSS at SPL > >> cmd: Makefile: Add rules to build bmp.c and read.c at SPL > >> common: splash: Enable splash_display at SPL stage > >> drivers: video: video-uclass: Disable u-boot logo at SPL > >> board: ti: am62x: evm: OSPI support for splash screen > >> > >> board/ti/am62x/evm.c | 6 ++++++ > >> cmd/Kconfig | 17 +++++++++++++++++ > >> cmd/Makefile | 2 ++ > >> common/splash.c | 2 +- > >> drivers/video/Kconfig | 32 ++++++++++++++++++++++++++++---- > >> drivers/video/Makefile | 6 ++++++ > >> drivers/video/tidss/Kconfig | 6 ++++++ > >> drivers/video/tidss/Makefile | 1 + > >> drivers/video/video-uclass.c | 2 +- > >> include/splash.h | 2 +- > >> 10 files changed, 69 insertions(+), 7 deletions(-) > > > > I'm not necessarily arguing against this, but what is the need for > > this? How many milliseconds earlier does the image appear with this > > patch? What is the bottleneck? We should be able to get to U-Boot > > proper very quickly. > > > There is a significant difference in time, by adding support in SPL > splash screen comes up by approx 650ms and at u-boot proper it comes at > 2.6s, measured from first print in console as seen on AM62x. Also we > plan to skip u-boot proper and load kernel directly. Yes that really is terrible. It should be under a second for U-Boot proper! Have you tried using bootstage to report the numbers? Have you tried using tracing to figure out what is wrong? Is it just slow storage? Regards, Simon