All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/10] Move board_init_f_mem() into a common location
Date: Fri, 17 Apr 2015 16:55:00 -0600	[thread overview]
Message-ID: <CAPnjgZ2kCaMQXxe2ZnTEM80vJKSo22JGodL-Yr_uZG4pfJp5tQ@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNAQDCpJvhh9J4=-X78pPvH2FEQKjsNft3JsEbnzAzZ9Xnw@mail.gmail.com>

Hi Masahiro,

On 17 April 2015 at 10:37, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Hi Simon,
>
>
> 2015-04-16 10:14 GMT+09:00 Simon Glass <sjg@chromium.org>:
>> This function will be used by both SPL and U-Boot proper. So move it into
>> a common place.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>>  Makefile                  |  1 +
>>  common/board_f.c          | 22 +---------------------
>>  common/init/Makefile      |  7 +++++++
>>  common/init/global_data.c | 33 +++++++++++++++++++++++++++++++++
>>  scripts/Makefile.spl      |  1 +
>>  5 files changed, 43 insertions(+), 21 deletions(-)
>>  create mode 100644 common/init/Makefile
>>  create mode 100644 common/init/global_data.c
>>
>> diff --git a/Makefile b/Makefile
>> index 343f416..7f6af72 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -659,6 +659,7 @@ libs-y += drivers/usb/musb-new/
>>  libs-y += drivers/usb/phy/
>>  libs-y += drivers/usb/ulpi/
>>  libs-y += common/
>> +libs-y += common/init/
>>  libs-$(CONFIG_API) += api/
>>  libs-$(CONFIG_HAS_POST) += post/
>>  libs-y += test/
>
> [snip]
>
>> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
>> index fcacb7f..60042ea 100644
>> --- a/scripts/Makefile.spl
>> +++ b/scripts/Makefile.spl
>> @@ -51,6 +51,7 @@ HAVE_VENDOR_COMMON_LIB = $(if $(wildcard $(srctree)/board/$(VENDOR)/common/Makef
>>  libs-y += $(if $(BOARDDIR),board/$(BOARDDIR)/)
>>  libs-$(HAVE_VENDOR_COMMON_LIB) += board/$(VENDOR)/common/
>>
>> +libs-y += common/init/
>>  libs-$(CONFIG_SPL_FRAMEWORK) += common/spl/
>>  libs-$(CONFIG_SPL_LIBCOMMON_SUPPORT) += common/
>>  libs-$(CONFIG_SPL_LIBDISK_SUPPORT) += disk/
>
>
> Please do not increase the top-level entry any more.
>
> How about adding "obj-y += init/" into common/Makefile ?

The problem I had was that common/ is not included for SPL unless you
enable CONFIG_SPL_LIBCOMMON_SUPPORT. Is there another way?

Regards,
Simon

  reply	other threads:[~2015-04-17 22:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16  1:13 [U-Boot] [PATCH 0/10] Make more use of board_init_f_mem() Simon Glass
2015-04-16  1:14 ` [U-Boot] [PATCH 01/10] Move board_init_f_mem() into a common location Simon Glass
2015-04-16  9:32   ` Jeroen Hofstee
2015-04-17 22:56     ` Simon Glass
2015-04-17 16:37   ` Masahiro Yamada
2015-04-17 22:55     ` Simon Glass [this message]
2015-04-16  1:14 ` [U-Boot] [PATCH 02/10] board_init_f_mem(): Don't require memset() Simon Glass
2015-04-16  4:25   ` Wolfgang Denk
2015-04-19 14:22     ` Simon Glass
2015-04-21  3:42   ` Masahiro Yamada
2015-04-21  3:47     ` Simon Glass
2015-04-21  4:30       ` Masahiro Yamada
2015-04-24  4:15         ` Simon Glass
2015-04-16  1:14 ` [U-Boot] [PATCH 03/10] board_init_f_mem(): Round down for stack alignment Simon Glass
2015-04-16  1:14 ` [U-Boot] [PATCH 04/10] board_init_f_mem(): Don't create an unused early malloc() area Simon Glass
2015-04-20 12:12   ` Masahiro Yamada
2015-04-16  1:14 ` [U-Boot] [PATCH 05/10] arm: Adjust start-up code to use board_init_f_mem() Simon Glass
2015-04-16  1:14 ` [U-Boot] [PATCH 06/10] arm64: " Simon Glass
2015-04-16  1:14 ` [U-Boot] [PATCH 07/10] x86: Add a TODO to call board_init_f_mem() Simon Glass
2015-04-16  1:14 ` [U-Boot] [PATCH 08/10] microblaze: " Simon Glass
2015-04-16  1:14 ` [U-Boot] [PATCH 09/10] zynq: Move SPL console init out of board_init_f() Simon Glass
2015-04-20 12:15   ` Masahiro Yamada
2015-04-16  1:14 ` [U-Boot] [PATCH 10/10] Revert "ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot" Simon Glass
2015-04-20 12:08   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ2kCaMQXxe2ZnTEM80vJKSo22JGodL-Yr_uZG4pfJp5tQ@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.