From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF26C4338F for ; Fri, 30 Jul 2021 18:56:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 619C5604D7 for ; Fri, 30 Jul 2021 18:56:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 619C5604D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E193983157; Fri, 30 Jul 2021 20:55:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="FSJweVap"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D947A83167; Fri, 30 Jul 2021 20:55:57 +0200 (CEST) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77F5983134 for ; Fri, 30 Jul 2021 20:55:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wr1-x430.google.com with SMTP id p5so12523463wro.7 for ; Fri, 30 Jul 2021 11:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Y7n9K3qBXZCp3WoIfLPd7TvSsbT2AXQ84Rp1eJz8CUc=; b=FSJweVapV3H/Va0W31Xi0FlIPnOglHqYh9eX1d00H3rFjMaehHdXsU16Tdye1D1gPf ycy652B7kEahWWDmPg8SVpsbqO6KjURIq8QgUo/vPj4wuVZP2wKjNBuPUBlez3NwGgQJ WAOz5Eovc2pwms9l8MtG7Dk6dqcB3RV/VIvzg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Y7n9K3qBXZCp3WoIfLPd7TvSsbT2AXQ84Rp1eJz8CUc=; b=Sh6tL5fD/zLuu+p0pAnVKkMmrM7yvhVAD3iSyrAKgp+gynqKv4bO5HgmFCTbctQ2Ad XUTPQg1ThUPay6UFeJ4FjcLSpknES3w3/PLTbCzkU/KbP4SXYZzNHpcPXak1VPqOLcRe 3n8lNje3iPS8N8nV2yuHUDJsxhPoQ7vcy6vOu0bUz90MmoJrVishhgqsIouThgcgQaOm gt15+blsxTOVBXPChArUFQTT6WouEdxXkfTJBp1ZWTY886WF4ft/riVn4Zl0YMU8fdMR trHLx9xPTlXv0WnKQlmeLd/JyFvJ4T5knXMaSH9DjnBbp7mcph/W+4D8hZ6C1l5XLc3d w6IQ== X-Gm-Message-State: AOAM530s2+SAktdsEvNUBXIlxm7M2u+XsUVYThL6kcUC7eacxaqerge1 HoWOqQjiXXj7Mm1euTC9evio6o/FCytYZGxPBCGScQ== X-Google-Smtp-Source: ABdhPJzDbklVd+i7kU3fHI1jvk+AdArNy3QuiD68xTaQQ2AscJLsQAGoYt18EHHO4KBSupgz7ctID8DYc1IBVuuV3jY= X-Received: by 2002:adf:f8c8:: with SMTP id f8mr1383358wrq.204.1627671353723; Fri, 30 Jul 2021 11:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20210725211033.GH9379@bill-the-cat> <20210729132209.GN9379@bill-the-cat> <20210730151031.GC9379@bill-the-cat> <20210730172651.GD9379@bill-the-cat> In-Reply-To: <20210730172651.GD9379@bill-the-cat> From: Simon Glass Date: Fri, 30 Jul 2021 12:55:42 -0600 Message-ID: Subject: Re: Debugging dtoc? To: Tom Rini Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Fri, 30 Jul 2021 at 11:26, Tom Rini wrote: > > On Fri, Jul 30, 2021 at 10:59:22AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 30 Jul 2021 at 09:10, Tom Rini wrote: > > > > > > On Fri, Jul 30, 2021 at 08:44:29AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Thu, 29 Jul 2021 at 07:22, Tom Rini wrote: > > > > > > > > > > On Wed, Jul 28, 2021 at 07:27:08PM -0600, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > > > > > > > On Wed, 28 Jul 2021 at 17:28, Simon Glass wr= ote: > > > > > > > > > > > > > > Hi again, > > > > > > > > > > > > > > On Mon, 26 Jul 2021 at 08:06, Simon Glass = wrote: > > > > > > > > > > > > > > > > Hi Tom, > > > > > > > > > > > > > > > > On Sun, 25 Jul 2021 at 15:10, Tom Rini = wrote: > > > > > > > > > > > > > > > > > > So, I'm trying to fix the problem on am335x_evm (and some= family > > > > > > > > > configs) with needing SPL_OF_CONTROL enabled. This is mo= stly fine just > > > > > > > > > enabling the option, except on am335x_evm itself, which i= s the > > > > > > > > > kitchen-sink config and overflows memory. I've gone with= switching to > > > > > > > > > SPL_OF_PLATDATA there as am335x in general has all of the= U_BOOT_DRVINFO > > > > > > > > > entries it needs I believe. But, with the following patc= h: > > > > > > > > > > > > > > > > > > diff --git a/arch/arm/dts/am335x-evm-u-boot.dtsi b/arch/a= rm/dts/am335x-evm-u-boot.dtsi > > > > > > > > > index 4cf5f9928d58..514f682cac99 100644 > > > > > > > > > --- a/arch/arm/dts/am335x-evm-u-boot.dtsi > > > > > > > > > +++ b/arch/arm/dts/am335x-evm-u-boot.dtsi > > > > > > > > > @@ -8,6 +8,7 @@ > > > > > > > > > &l4_per { > > > > > > > > > > > > > > > > > > segment@300000 { > > > > > > > > > + u-boot,dm-pre-reloc; > > > > > > > > > > > > > > > > > > target-module@e000 { > > > > > > > > > u-boot,dm-pre-reloc; > > > > > > > > > diff --git a/configs/am335x_boneblack_vboot_defconfig b/c= onfigs/am335x_boneblack_vboot_defconfig > > > > > > > > > index a0baeec79edd..ffeefd1a0087 100644 > > > > > > > > > --- a/configs/am335x_boneblack_vboot_defconfig > > > > > > > > > +++ b/configs/am335x_boneblack_vboot_defconfig > > > > > > > > > @@ -31,6 +31,7 @@ CONFIG_CMD_SPL=3Dy > > > > > > > > > # CONFIG_CMD_SETEXPR is not set > > > > > > > > > CONFIG_BOOTP_DNS2=3Dy > > > > > > > > > CONFIG_OF_CONTROL=3Dy > > > > > > > > > +CONFIG_SPL_OF_CONTROL=3Dy > > > > > > > > > CONFIG_ENV_OVERWRITE=3Dy > > > > > > > > > CONFIG_ENV_IS_IN_MMC=3Dy > > > > > > > > > CONFIG_SYS_REDUNDAND_ENVIRONMENT=3Dy > > > > > > > > > diff --git a/configs/am335x_evm_defconfig b/configs/am335= x_evm_defconfig > > > > > > > > > index a33efff42a74..f35b2a02f56b 100644 > > > > > > > > > --- a/configs/am335x_evm_defconfig > > > > > > > > > +++ b/configs/am335x_evm_defconfig > > > > > > > > > @@ -37,13 +37,16 @@ CONFIG_MTDIDS_DEFAULT=3D"nand0=3Dnand= .0" > > > > > > > > > CONFIG_MTDPARTS_DEFAULT=3D"mtdparts=3Dnand.0:128k(NAND.S= PL),128k(NAND.SPL.backup1),128k(NAND.SPL.backup2),128k(NAND.SPL.backup3),25= 6k(NAND.u-boot-spl-os),1m(NAND.u-boot),128k(NAND.u-boot-env),128k(NAND.u-bo= ot-env.backup1),8m(NAND.kernel),-(NAND.file-system)" > > > > > > > > > # CONFIG_SPL_EFI_PARTITION is not set > > > > > > > > > CONFIG_OF_CONTROL=3Dy > > > > > > > > > +CONFIG_SPL_OF_CONTROL=3Dy > > > > > > > > > CONFIG_OF_LIST=3D"am335x-evm am335x-bone am335x-boneblac= k am335x-evmsk am335x-bonegreen am335x-icev2 am335x-pocketbeagle" > > > > > > > > > +CONFIG_SPL_OF_PLATDATA=3Dy > > > > > > > > > CONFIG_ENV_OVERWRITE=3Dy > > > > > > > > > CONFIG_SYS_RELOC_GD_ENV_ADDR=3Dy > > > > > > > > > CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=3Dy > > > > > > > > > CONFIG_SPL_ENV_IS_NOWHERE=3Dy > > > > > > > > > CONFIG_VERSION_VARIABLE=3Dy > > > > > > > > > CONFIG_BOOTP_SEND_HOSTNAME=3Dy > > > > > > > > > +# CONFIG_SPL_SIMPLE_BUS is not set > > > > > > > > > CONFIG_BOOTCOUNT_LIMIT=3Dy > > > > > > > > > CONFIG_CLK=3Dy > > > > > > > > > CONFIG_CLK_CDCE9XX=3Dy > > > > > > > > > diff --git a/configs/am335x_evm_spiboot_defconfig b/confi= gs/am335x_evm_spiboot_defconfig > > > > > > > > > index 8f0c330674a9..4a2a56a9af9e 100644 > > > > > > > > > --- a/configs/am335x_evm_spiboot_defconfig > > > > > > > > > +++ b/configs/am335x_evm_spiboot_defconfig > > > > > > > > > @@ -32,6 +32,7 @@ CONFIG_BOOTP_DNS2=3Dy > > > > > > > > > CONFIG_CMD_MTDPARTS=3Dy > > > > > > > > > # CONFIG_SPL_EFI_PARTITION is not set > > > > > > > > > CONFIG_OF_CONTROL=3Dy > > > > > > > > > +CONFIG_SPL_OF_CONTROL=3Dy > > > > > > > > > CONFIG_OF_LIST=3D"am335x-evm am335x-bone am335x-boneblac= k am335x-evmsk am335x-bonegreen am335x-icev2 am335x-pocketbeagle" > > > > > > > > > CONFIG_ENV_OVERWRITE=3Dy > > > > > > > > > # CONFIG_ENV_IS_IN_FAT is not set > > > > > > > > > > > > > > > > > > I get the following failure and I don't see how to debug = this: > > > > > > > > > DTOC spl/dts/dt-plat.c > > > > > > > > > Traceback (most recent call last): > > > > > > > > > File "./tools/dtoc/dtoc", line 115, in > > > > > > > > > args.phase, instantiate=3Dargs.instantiate) > > > > > > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc= /dtb_platdata.py", line 1223, in run_steps > > > > > > > > > outfile.method(plat) > > > > > > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc= /dtb_platdata.py", line 1081, in generate_plat > > > > > > > > > self.output_node_plat(node) > > > > > > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc= /dtb_platdata.py", line 1023, in output_node_plat > > > > > > > > > self._output_values(node) > > > > > > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc= /dtb_platdata.py", line 812, in _output_values > > > > > > > > > self._output_prop(node, node.props[pname]) > > > > > > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc= /dtb_platdata.py", line 798, in _output_prop > > > > > > > > > self._output_list(node, prop) > > > > > > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc= /dtb_platdata.py", line 628, in _output_list > > > > > > > > > vals.append(get_value(prop.type, val)) > > > > > > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc= /dtb_platdata.py", line 126, in get_value > > > > > > > > > val =3D '%#x' % fdt_util.fdt32_to_cpu(value) > > > > > > > > > File "/home/trini/work/u-boot/u-boot/tools/dtoc/../dtoc= /fdt_util.py", line 28, in fdt32_to_cpu > > > > > > > > > return struct.unpack('>I', val)[0] > > > > > > > > > TypeError: a bytes-like object is required, not 'bool' > > > > > > > > > scripts/Makefile.spl:352: recipe for target 'spl/dts/dt-p= lat.c' failed > > > > > > > > > make[1]: *** [spl/dts/dt-plat.c] Error 1 > > > > > > > > > make[1]: *** Deleting file 'spl/dts/dt-plat.c' > > > > > > > > > Makefile:1999: recipe for target 'spl/u-boot-spl' failed > > > > > > > > > make: *** [spl/u-boot-spl] Error 2 > > > > > > > > > > > > > > > > That seems like a bug, where perhaps it is seeing a propert= y with no > > > > > > > > value so it thinks it is a bool, but then somehow tries to = gets its > > > > > > > > int value. > > > > > > > > > > > > > > > > I added a print to _output_list() > > > > > > > > > > > > > > > > else: > > > > > > > > print('node', node.path, prop.name) > > > > > > > > for val in prop.value: > > > > > > > > vals.append(get_value(prop.type, val)) > > > > > > > > > > > > > > > > and see that it is the 'ranges' property. Definitely seems = like a bug > > > > > > > > but I'll have to dig into it I think. The Prop() class sele= cts a bool > > > > > > > > type when the value is empty, but somehow that isn't happen= ing. > > > > > > > > > > > > > > This is actually a little tricky, but I'm looking at it. > > > > > > > > > > > > OK I think I have figured this out. I sent a series. > > > > > > > > > > That gets everything building, thanks! It also shows that some p= arts of > > > > > the kitchen-sink config there depend on OF_CONTROL features, real= ly. > > > > > What I'm going to prove out next (but will require a little bit o= f time > > > > > due to having to set up lab stuff and dig out notes) is that for = this > > > > > case, we can just go with however ROM configured the PHY. We wer= e also > > > > > still over SRAM space, with PLATDATA enabled too. > > > > > > > > OK good. I think more users would help reduce the number of rough e= dges . > > > > > > > > Can you please point me to the tree with before/after? I would like= to > > > > look at SRAM space just in case I can see something. > > > > > > With SPL_OF_CONTROL, we're 4900 bytes over (and it's just adding > > > SPL_OF_CONTROL to the current config). PLATDATA isn't an option sinc= e > > > both omap_hsmmc.c and drivers/net/ti/cpsw.c need gpio by name/etc > > > > Actually we can handle this - see for example how > > clk_get_by_driver_info() works. > > > > > functionality. The mmc case could be kludged (assume card is writabl= e > > > if needed) but cpsw is harder at first glance. > > > > I think we should figure out how to enable of-platdata on this board. > > The MMC case can be fixed a few ways. It's "find the GPIO for > card-change or write-protect" and just leaving that in the state ROM has > it, is fine here. The driver can really just be built with this off. > The network driver seems a bit more complex. > drivers/net/ti/cpsw-common.c::ti_cm_get_macid_addr() and similar need to > workout with PLATDATA instead. For that case where we can use one SPL > and one DTB to boot a platform (or, family of platforms), something > could be worked out so that we figure it all out at build-time what path > will be taken. But the CPSW driver is an example of something that > fairly mirrors the linux kernel driver and does as much via the DT as > possible. I'm not sure how we rework this. I'll have a look too. If we cannot make of-platdata work in all reasonable situations, then it isn't really fair to ask people to use it. Regards, Simon