From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B6BC433F5 for ; Thu, 9 Sep 2021 08:57:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D9D3610A3 for ; Thu, 9 Sep 2021 08:57:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6D9D3610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4A1E583205; Thu, 9 Sep 2021 10:57:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="TGqHRUGe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4A06E83116; Thu, 9 Sep 2021 10:57:24 +0200 (CEST) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E19ED8311F for ; Thu, 9 Sep 2021 10:57:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wr1-x429.google.com with SMTP id q26so1421879wrc.7 for ; Thu, 09 Sep 2021 01:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tuF5l/cxbvAK2MLv0fCv+7i8MkHzqOzVhy1qydnFDCs=; b=TGqHRUGe3QFGSH8YW4wANHUHDgwwqhsw0Dl7A9UXsQwQzPFCNvKWLXhvPB6zpS0ICQ RyhWZ4Um6vgCzj3s1xCP0YgHiBDYVViF0ek1Cky6F55VPKzQ09PDZq4DfGP0gYjPVb0j yFDM6mcUmTeI+dUPvnbtoH6AOE/19YJQXEJl4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tuF5l/cxbvAK2MLv0fCv+7i8MkHzqOzVhy1qydnFDCs=; b=ixLHNC/b0rdjRazt5qJZpyjrikn5jXkozi0BhrH2skZ3wlVuPPrcWRtfhjMtAA44kl 0xutB8XfpXO3/LUeRyU1CrF4WhIpncaaEwOW9T888ORPBVB4JbgTHr0B5b88CbQCLni2 N0Y3vmnvQLJovL3SYhoNpKA+UC7mmLLR74O2t9a/1by8P0o1CG70bTTLMNfdgseGGPSB QEay6QUTQVKMEsCDijFJR8niBFK1zrsR3iBJ+qecgoXQPsmrUxR/NhVDcwb8P6sw+LrY xjb7JdLd2J6bN8yAi5zrdQOBNNHryYt2Oh+9eyTBSAoKU//kz2gHEbYHczpa2/UV+65I +E7Q== X-Gm-Message-State: AOAM531x/6PRUdHuAM+Mz3dXzfdRb2of0elVPv/bpfyFKjr0+y5EaZn4 CDMJAfIifjgy8bssiHF6VUmB6uPPZ1pSSh4SNbrZNA== X-Google-Smtp-Source: ABdhPJwlqf5c8SnqgEANZG3cqVKAsxssjN7dS8YSGRw5X4SKtZp9PQpJOjhEHzgL0xxNvqfm6qjGWHrsPBAne0WEzJA= X-Received: by 2002:adf:b7c5:: with SMTP id t5mr2178458wre.322.1631177837026; Thu, 09 Sep 2021 01:57:17 -0700 (PDT) MIME-Version: 1.0 References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.34.I2eff1cd4f12753d0d86e9751fa350458ef5789e0@changeid> <6cf95832-b162-bdfd-b8d2-901ba7e63b74@gmx.de> In-Reply-To: <6cf95832-b162-bdfd-b8d2-901ba7e63b74@gmx.de> From: Simon Glass Date: Thu, 9 Sep 2021 02:57:04 -0600 Message-ID: Subject: Re: [PATCH 34/35] efi: Show when allocated pages are used To: Heinrich Schuchardt Cc: Ilias Apalodimas , Bin Meng , Tom Rini , Christian Melki , Alexander Graf , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Wed, 8 Sept 2021 at 12:25, Heinrich Schuchardt wrote: > > > > On 9/8/21 3:34 PM, Simon Glass wrote: > > Add a message here so that both paths of memory allocation are reported. > > > > Signed-off-by: Simon Glass > > --- > > > > lib/efi/efi_app.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/efi/efi_app.c b/lib/efi/efi_app.c > > index e0666d1fae2..c8f4784eb7d 100644 > > --- a/lib/efi/efi_app.c > > +++ b/lib/efi/efi_app.c > > @@ -97,6 +97,7 @@ static efi_status_t setup_memory(struct efi_priv *priv) > > return ret; > > priv->use_pool_for_malloc = true; > > } else { > > + printf("(using allocated RAM address %lx) ", (ulong)addr); > > Shouldn't this be log_debug()? It matches the one a few lines higher. I suppose it could be a debug statement, but allocation is an area that seems to different on different UEFIs, so I have it more prominent for the moment, until we figure it out. Regards, Simon