From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Fri, 28 Jun 2013 00:12:51 -0700
Subject: [U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce
 code duplication
In-Reply-To: <51CD358B.8020709@denx.de>
References: <1370974493-21822-1-git-send-email-sjg@chromium.org>
	<1370974493-21822-16-git-send-email-sjg@chromium.org>
	<51CC40D4.8070703@denx.de>
	<CAPnjgZ2RPRjJoibbABeNw1RaUq88yhaPfw0FSBsGK8OpcCB+ng@mail.gmail.com>
	<CAPnjgZ1NBtNjXmm62x97j19j=btQ_T-S=bD87iOHre+gdQqQNA@mail.gmail.com>
	<51CD0D24.70600@denx.de>
	<CAPnjgZ0fS9J1T2AoH-_bXGuzcuFTjopXBwoMCF9qWc5FLcm=Cg@mail.gmail.com>
	<51CD358B.8020709@denx.de>
Message-ID: <CAPnjgZ2oxbsqSr-MCQUOjQZbE89Nb4OJ1FvGNGTBMsRGUDOr6g@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefan,

On Fri, Jun 28, 2013 at 12:04 AM, Stefan Roese <sr@denx.de> wrote:

> On 06/28/2013 08:58 AM, Simon Glass wrote:
> >     One idea: It might have something to do with the interrupt
> disabling, as
> >     powerpc compresses to 0. And thats the location of the interrupt
> vectors
> >     (timer?). Just an idea. Do you remember shuffling the
> >     disable_interrupts() call around?
> >
> >
> > Hmmm yes I did shuffle them around, figuring that the interrupts needed
> > to be disabled before booting the OS but not before loading it. It seems
> > like I made a bad assumption here.
>
> Yes, I already found that one as well. But moving this disable before
> kernel loading unfortunately doesn't fix this issue completely. gunzip
> now finished with "... OK". But Linux Kernel booting still does not work.
>

Well actually that is progress, since now it is similar to Tom's ARM
platform. I will post the patch soon once buildman finishes.

>
> > I have been through the code multiple times and I cannot see a
> > difference in operation. Also it does work correctly on the ARM
> > platforms I have tried. It is broken on Tom's ARM platform, but perhaps
> > that could be an interrupt issue also.
> >
> > I am going to post a patch to restore the interrupt code to where it
> > was, hoping that this shows some difference for your error. I will also
> > post a couple of revert patches for those who are blocked on this. We
> > will have to apply reverts fairly soon if the solution doesn't present
> > itself.
> >
> >
> >     I'll check myself in a few hours.
> >
> >
> > OK please let me know if you find anything else. Thanks for your help.
> > Refactoring code is a tricky business...I much prefer the new bootm
> > code, if it can work on all platforms.
>
> I'm still at it. Will keep you informed. Stay tuned...
>

Thanks very much!

Regards,
Simon