From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 3/6] rtc: fall back to ->{read,write}8_array if ->{read,write}8 are not provided
Date: Tue, 5 May 2020 21:42:36 -0600 [thread overview]
Message-ID: <CAPnjgZ2pocHx81XFcyQAV1ZRPWOf2WtDRPQX1=3qo9us_PyjLw@mail.gmail.com> (raw)
In-Reply-To: <20200504212032.3759-4-rasmus.villemoes@prevas.dk>
On Mon, 4 May 2020 at 15:20, Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
>
> Similar to how the rtc_{read,write}8_array functions fall back to
> using the {read,write}8 methods, do the opposite in the
> rtc_{read,write}8 functions.
>
> This way, each driver only needs to provide either ->read8 or
> ->read8_array to make both rtc_read8() and rtc_read8_array() work -
> without this, a driver that provides rtc_read8_array() would most
> likely just duplicate the logic here for implementing a ->read8()
> method in term of its ->read8_array() method. The same remarks of
> course apply to the write case.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
> drivers/rtc/rtc-uclass.c | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
Please make sure you add tests for these methods.
next prev parent reply other threads:[~2020-05-06 3:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 21:20 [PATCH 0/6] rtc: add rtc_{read,write}8_array and rtc command Rasmus Villemoes
2020-05-04 21:20 ` [PATCH 1/6] rtc: add rtc_read8_array helper and ->read8_array method Rasmus Villemoes
2020-05-06 3:42 ` Simon Glass
2020-05-06 8:13 ` Rasmus Villemoes
2020-05-04 21:20 ` [PATCH 2/6] rtc: add rtc_write8_array() helper Rasmus Villemoes
2020-05-06 3:42 ` Simon Glass
2020-05-04 21:20 ` [PATCH 3/6] rtc: fall back to ->{read, write}8_array if ->{read, write}8 are not provided Rasmus Villemoes
2020-05-06 3:42 ` Simon Glass [this message]
2020-05-04 21:20 ` [PATCH 4/6] rtc: pcf2127: provide ->read8_array method Rasmus Villemoes
2020-05-06 3:42 ` Simon Glass
2020-05-04 21:20 ` [PATCH 5/6] rtc: pcf2127: provide ->write8_array method Rasmus Villemoes
2020-05-06 3:42 ` Simon Glass
2020-05-04 21:20 ` [PATCH 6/6] rtc: add rtc command Rasmus Villemoes
2020-05-06 3:42 ` Simon Glass
2020-05-19 22:01 ` [PATCH v2 00/10] new rtc methods, rtc command, and tests Rasmus Villemoes
2020-05-19 22:01 ` [PATCH v2 01/10] rtc: add rtc_read helper and ->read method Rasmus Villemoes
2020-05-19 22:01 ` [PATCH v2 02/10] rtc: add rtc_write() helper Rasmus Villemoes
2020-05-19 22:01 ` [PATCH v2 03/10] rtc: fall back to ->{read, write} if ->{read, write}8 are not provided Rasmus Villemoes
2020-05-19 22:01 ` [PATCH v2 04/10] rtc: pcf2127: provide ->read method Rasmus Villemoes
2020-05-19 22:01 ` [PATCH v2 05/10] rtc: pcf2127: provide ->write method Rasmus Villemoes
2020-05-19 22:01 ` [PATCH v2 06/10] rtc: add rtc command Rasmus Villemoes
2020-05-31 14:07 ` Simon Glass
2020-06-02 9:13 ` Rasmus Villemoes
2020-06-02 13:22 ` Simon Glass
2020-06-02 14:36 ` Rasmus Villemoes
2020-06-02 19:29 ` Simon Glass
2020-05-19 22:01 ` [PATCH v2 07/10] rtc: sandbox-rtc: fix set method Rasmus Villemoes
2020-05-31 14:07 ` Simon Glass
2020-05-19 22:01 ` [PATCH v2 08/10] rtc: i2c_rtc_emul: catch any write to the "reset" register Rasmus Villemoes
2020-05-31 14:07 ` Simon Glass
2020-05-19 22:01 ` [PATCH v2 09/10] test: dm: rtc: add test of rtc_read, rtc_write Rasmus Villemoes
2020-05-31 14:07 ` Simon Glass
2020-05-19 22:01 ` [PATCH v2 10/10] test: dm: rtc: add tests of rtc shell command Rasmus Villemoes
2020-05-31 14:07 ` Simon Glass
2020-06-02 9:15 ` Rasmus Villemoes
2020-06-02 18:40 ` [PATCH v2 00/10] new rtc methods, rtc command, and tests Rasmus Villemoes
2020-06-02 19:29 ` Simon Glass
2020-06-02 19:44 ` Rasmus Villemoes
2020-06-02 20:56 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ2pocHx81XFcyQAV1ZRPWOf2WtDRPQX1=3qo9us_PyjLw@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.