From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35637C433EF for ; Mon, 20 Sep 2021 03:18:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9C7460FF2 for ; Mon, 20 Sep 2021 03:18:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A9C7460FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BE01C8325E; Mon, 20 Sep 2021 05:18:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="H2QZYfVT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B209F8326B; Mon, 20 Sep 2021 05:18:17 +0200 (CEST) Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6E7EB83252 for ; Mon, 20 Sep 2021 05:18:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe29.google.com with SMTP id z62so15203803vsz.9 for ; Sun, 19 Sep 2021 20:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5laNcXgsJ5NFTx1kds8gr6OdAwuhoSCo7QJworNsfaA=; b=H2QZYfVTvB15dPRnkBAuPYlRfcNaOwvc3VGervWnUslJLNTqiEdMZt9Kl8oEboTSKK C0LMJjkrd7aOgvX/gnAWJMXBY6S6WHPsySsggna5yVReqGdDDqUAhlglnNIgUZJGUiwe gkQzvtAhNB/NdXKzakRkJdYClBNG4qLsPjdR8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5laNcXgsJ5NFTx1kds8gr6OdAwuhoSCo7QJworNsfaA=; b=KLOS95H+wHk9GJyzuesjwAf9BzDhnacuu1uHIFI/Lok/zZXtR5Z7pMlXaRQYhR7Fr9 8Dz0Bf/jxZMytxZhjJ4X+T/7eFPMz/tAKfDhhPwABPUphlkOCfhgDliZNw9kb3855VzF jnwCqPuQzH5kGRmqgSSYZ2H7uEyAbbknDiRAtx/yITfwAcPNSUDPfc3ZcwIKex0XHT7x JoglCDPhZOc3KVvpaBWHuO6ztZaBc+nkRbS43nV+8ZHSj6WFkOHzdJpYxEHMZv2RFjyJ BAme3JQVZitBbCiSjHKVgJnOpQIHHH9EeB+64lYSwEHzbBN0CZFyz3mUkbQNkyl+pmQt hcRQ== X-Gm-Message-State: AOAM531Zou1Y0Jn59ExH+I3gYsylRj1IlXyq5usfweYn2fZHDYp9Ram+ 2T6wwKfRQJl/0V4WXpJhmmN/XBz+LqaYzA87Gc6TRw== X-Google-Smtp-Source: ABdhPJySNd5eq2UUEkBqsDpdW11yWAjgkI5Mg7tUsF3AglK7OjZ0NXGIVCSJ2i0ybvMDZpiY0a6SM+90ltIy+DI0b9c= X-Received: by 2002:a67:e30a:: with SMTP id j10mr1766913vsf.58.1632107893040; Sun, 19 Sep 2021 20:18:13 -0700 (PDT) MIME-Version: 1.0 References: <20210819034033.1617201-1-sjg@chromium.org> <20210818214022.10.I42087e8088f8d9fb704821d73f17d7ae246a2e69@changeid> <20210916184039.GA2826@bill-the-cat> <20210918131628.GL8579@bill-the-cat> In-Reply-To: From: Simon Glass Date: Sun, 19 Sep 2021 21:18:01 -0600 Message-ID: Subject: Re: [PATCH 10/11] sandbox: mmc: Support a backing file To: Tom Rini Cc: U-Boot Mailing List , Jaehoon Chung , Peng Fan Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Sat, 18 Sept 2021 at 10:31, Simon Glass wrote: > > Hi Tom, > > On Sat, 18 Sept 2021 at 07:16, Tom Rini wrote: > > > > On Sat, Sep 18, 2021 at 03:34:54AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 16 Sept 2021 at 12:40, Tom Rini wrote: > > > > > > > > On Wed, Aug 18, 2021 at 09:40:32PM -0600, Simon Glass wrote: > > > > > > > > > Provide a way for sandbox MMC to present data from a backing file. This > > > > > allows a filesystem to be created on the host and easily served via an > > > > > emulated mmc device. > > > > > > > > > > Signed-off-by: Simon Glass > > > > > Reviewed-by: Jaehoon Chung > > > > > --- > > > > > > > > > > doc/device-tree-bindings/mmc/sandbox,mmc.txt | 18 ++++++++ > > > > > drivers/mmc/sandbox_mmc.c | 46 ++++++++++++++++---- > > > > > 2 files changed, 55 insertions(+), 9 deletions(-) > > > > > create mode 100644 doc/device-tree-bindings/mmc/sandbox,mmc.txt > > > > > > > > As is, this breaks how I've always run pytests on sandbox. > > > > > > How does it break it? Do you get an error? The feature is supposed to > > > be optional. > > > > Without doing anything to enable it, a few of the mmc unit tests failed. > > I don't have the logs handy right now (I made that sometimes bad > > decision to test 2 series at once, and now I'm waiting a bit more on > > final feedback on the changes the timestamp cleanup needed before I push > > that + the rest of this series). > > Oh dear, I will take a look and see what is going on there. The problem seems to me something going wrong with malloc(). I'm not really sure what but I have seen it before. Basically the mallinfo struct becomes corrupted somehow and from there everything goes haywire. It actually happens today in normal operation, but somehow it doesn't cause problems. I looked at it a while back and did not make progress. Anyway I will see if I can dig into it again. Regards, Simon