From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 27 Feb 2020 15:40:43 -0800 Subject: [PATCH] common/board_f.c: use #ifdefs a little more consistently In-Reply-To: <20200227081825.11039-1-rasmus.villemoes@prevas.dk> References: <20200227081825.11039-1-rasmus.villemoes@prevas.dk> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Rasmus, On Thu, 27 Feb 2020 at 00:18, Rasmus Villemoes wrote: > > Some init functions, e.g. print_resetinfo(), are conditionally defined > depending on some config options, and are correspondingly > conditionally included in the init_sequence_f[] array. > > Others are unconditionally defined and included in init_sequence_f[], > but have their entire body, sans a mandatory "return 0", conditionally > compiled. > > For the simple cases, switch to the former model, making it a bit more > consistent. This also makes the U-Boot image very slightly smaller and > avoids a few useless calls to no-op functions during board_init_f. Can you check if it definitely does change the size? The reason I ask is that it inlines those function calls in the normal case, at least from my inspection. Using if() is preferable to #if if there is no cost. > > Signed-off-by: Rasmus Villemoes > --- > common/board_f.c | 54 ++++++++++++++++++++++++++++++++---------------- > 1 file changed, 36 insertions(+), 18 deletions(-) Regards, Simon