From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 387C7C433F5 for ; Sun, 10 Oct 2021 14:18:18 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABBD8610C7 for ; Sun, 10 Oct 2021 14:18:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ABBD8610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1376A8370A; Sun, 10 Oct 2021 16:17:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="aNjD3YLD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 183C7836B6; Sun, 10 Oct 2021 16:15:27 +0200 (CEST) Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 45026836A7 for ; Sun, 10 Oct 2021 16:15:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x32e.google.com with SMTP id c26-20020a056830349a00b0054d96d25c1eso18138708otu.9 for ; Sun, 10 Oct 2021 07:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WBYeSpYo4IXIEgxc69+eYW6mS8XAbEsGMPAs8BOqu6Y=; b=aNjD3YLDfVHt3GJIIwrhQ0LifkY/dsnIj91V06LVsrJlaDxt/nZDnO6OWt62U4jBxy Ic5xvum4AfQ+ateT3LZ8JW5xvh0nscm5Q1VkZJ05YhDgkwIfVLIjNmpu2Y5SgU8UXez3 cGfQHE7WtQ8NC18CW7FdGp16xkGPL+K+ujKQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WBYeSpYo4IXIEgxc69+eYW6mS8XAbEsGMPAs8BOqu6Y=; b=y4MQ8GtalYlY1152amWgS3xB0oG6+Z7/YiEgygEY5+BTqwQambXxJrTp6MLylV4LTK dbOseHNsRoC0ljcTwhtuvj7peKO62jon1j5TI7ngjSDx9x3tF9l4w3KT/7HBpzd41JTo 8dumZnlD6nIivyMQLlQsom+gmC+tEhUaJzEuqG5FYgYP6f0SaCppAR0sJUb6Rsf0i51k WUHLFKPX951IODwX/9aJNpZN22cIkc98FTIpcT+0Bxff7ZssNrcFE7oXkdcBIfCfOAef yU3Rln7GVBXrzgQFPGYXpQiB/HBJBMWCQE1kDDfKcl4ZE+qDHGxJkc9+DOvYmdIwcXSl +jXg== X-Gm-Message-State: AOAM5329XDnLNZlxNz6qoK/kyRaXbb0NM9VuB1e1pPZYSFNoZaQQBU+w ++xH4tfb2ZTOS1dNeyV3l7oCuxkSP2oQgb6EBz2gKw== X-Google-Smtp-Source: ABdhPJwFaxVvgPc/+cEMbmZ3HY6Nw1VqfAiB5B+ZlY37uzrc66igjX5xsMaJ8jGisvz5hObPZGmNOeqXeD/wpakvptA= X-Received: by 2002:a05:6830:3093:: with SMTP id f19mr3864191ots.97.1633875313715; Sun, 10 Oct 2021 07:15:13 -0700 (PDT) MIME-Version: 1.0 References: <20211001050228.55183-1-takahiro.akashi@linaro.org> <20211001050228.55183-14-takahiro.akashi@linaro.org> In-Reply-To: <20211001050228.55183-14-takahiro.akashi@linaro.org> From: Simon Glass Date: Sun, 10 Oct 2021 08:14:13 -0600 Message-ID: Subject: Re: [RFC 07/22] block: ide: call device_probe() after scanning To: AKASHI Takahiro Cc: Heinrich Schuchardt , Alex Graf , Ilias Apalodimas , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 30 Sept 2021 at 23:03, AKASHI Takahiro wrote: > > Every time an ide bus/port is scanned and a new device is detected, > we want to call device_probe() as it will give us a chance to run additional > post-processings for some purposes. > > In particular, support for creating partitions on a device will be added. > > Signed-off-by: AKASHI Takahiro > --- > drivers/block/ide.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Simon Glass I'm starting to wonder if you can create a function that does the probe and unbind? Something in the blk interface, perhaps? It would reduce the duplicated code and provide a standard way of bringing up a new device. Perhaps blk_device_complete() ? Regards, Simon