From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41FB6C433EF for ; Wed, 9 Feb 2022 17:16:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6840883E9C; Wed, 9 Feb 2022 18:16:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="MnPFKm+K"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BE83683A1E; Wed, 9 Feb 2022 18:16:31 +0100 (CET) Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 562D983A1E for ; Wed, 9 Feb 2022 18:16:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oo1-xc2d.google.com with SMTP id k13-20020a4a948d000000b003172f2f6bdfso3226987ooi.1 for ; Wed, 09 Feb 2022 09:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cNKQ+f9W6oNqk5eakJO0o72GeDC3IuabtKDj9eO/fk8=; b=MnPFKm+KFQi7T+7WDfv3lKRWenCfGj5qfMx4m1b/WT7SOoilqNaHNH3JcCnI/Eksvd kxSICD6R0tqXfzpTxXUSWJMxN23SZ80ypBLmajwFbrm6ahftwn3bAlFzWsmF8q/4yYoC cg8VWVdE9DtyFr8tso0cXcYyhpaQepZdv5R5s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cNKQ+f9W6oNqk5eakJO0o72GeDC3IuabtKDj9eO/fk8=; b=k+2rCEMghSlYjYlyM6sv/480Z8F66dzRYI7HmpDbUk6WtlbNM4fwAXTBvJ4ijWfh/e VJk60uQFQShHfGdEYgeC9kUR2Q2eAHMYFJoLy7csaBek+UWT4Hr7L1cXhBm6gMSNUaOF qMjdH03N1hq7lPVgp6nTeNPmcHkVUt8ypu0QfypnLnx49P8fk40KnYB3iPO+A0pREe3N 0HcdyY9AXeW942Du4pRch2UN1oFqx8+Vcs3G2A71yx73enD3nI00Lr+JfTCPcFRVW27R EgpCRn36bxRvvcEvG53+MTfp1m4U2RwZfdB70T7eRdCCLMp1CewpEaKLrB/kMhkF8pC3 qwfA== X-Gm-Message-State: AOAM531C92eUhi2R9sdHDJSvlg8hLk/heFPfa28u8GunWfpI60FYc7uY sM/cX4P3jsPOMztAgviZrfQtrgN0AiCRRuTZ7A6SmA== X-Google-Smtp-Source: ABdhPJx9SylDAPHBHSUUlsiMpYbH4IfCAjAcaMhz5UTBUacDAMTY58wzCDXng1LHZEQ+edbejZMli1Q/47iI3QUtzvM= X-Received: by 2002:a05:6870:e502:: with SMTP id y2mr1238039oag.91.1644426986608; Wed, 09 Feb 2022 09:16:26 -0800 (PST) MIME-Version: 1.0 References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.7.Id5595981cd99201c6a2d8b714254d775436a3483@changeid> <20220209123219.GZ7515@bill-the-cat> In-Reply-To: <20220209123219.GZ7515@bill-the-cat> From: Simon Glass Date: Wed, 9 Feb 2022 10:16:14 -0700 Message-ID: Subject: Re: [PATCH v3 07/18] pxe: Move pxe_utils files To: Tom Rini Cc: Adam Ford , U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi, On Wed, 9 Feb 2022 at 05:32, Tom Rini wrote: > > On Wed, Feb 09, 2022 at 05:40:03AM -0600, Adam Ford wrote: > > On Thu, Oct 14, 2021 at 1:50 PM Simon Glass wrote: > > > > > > Move the header file into the main include/ directory so we can use it > > > from the bootmethod code. Move the C file into boot/ since it relates to > > > booting. > > > > > +cc lokeshvutla@ti.com > > > > Simon, > > > > I can't explain why, but with git bisect, it appears this patch breaks > > my omap3_logic board (DM3730) by making it wrongly think there is 4GB > > of RAM, when in reality there is only 256MB. We have both 256MB and > > 512MB parts, and the automatic memory detection has always 'just > > worked' in the past. > > > > With this patch now, I see: > > U-Boot 2022.01-rc1-00185-g262cfb5b15 (Feb 09 2022 - 05:23:42 -0600) > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > DRAM: 4 GiB > > > > > > With the previous commit, 8018b9af57b5 ("pxe: Tidy up the is_pxe > > global"), it properly detects the RAM and fully boots. > > > > U-Boot 2022.01-rc1-00184-g8018b9af57 (Feb 09 2022 - 05:21:39 -0600) > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > DRAM: 256 MiB > > NAND: 512 MiB > > MMC: OMAP SD/MMC: 0 > > Loading Environment from NAND... OK > > OMAP die ID: 619e00029ff800000168300f1502501f > > Net: eth0: ethernet@08000000 > > Hit any key to stop autoboot: 0 > > OMAP Logic # > > > > I have CONFIG_CMD_BOOTM, CONFIG_CMD_PXE and CONFIG_CMD_SYSBOOT all > > defined, so I am having a hard time understanding why this would > > change behavior or stomp on the the structure that knows the memory > > size. > > > > If I jump ahead to the current 'master' 531c0089457:("Merge branch > > '2022-02-08-TI-platform-updates') and revert this patch, my board > > boots correctly again, but I am struggling to understand why. > > > > Do you have any suggestions for me to try? > > I would suggest objdump disassemble U-Boot before/after and see what > functions have changed. Keep an eye out for a BSS variable that is used before relocation, perhaps? Regards, Simon