From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Tue, 16 Mar 2021 05:58:26 +0000
Subject: [PATCH v2 1/1] sandbox: allow cross-compiling sandbox
In-Reply-To: <CAPnjgZ22UfzG=MVsUxXzGhE5E7ynmHLmFPsoduOPcON13i5huw@mail.gmail.com>
References: <CAPnjgZ22UfzG=MVsUxXzGhE5E7ynmHLmFPsoduOPcON13i5huw@mail.gmail.com>
 <20210210175425.264251-1-xypron.glpk@gmx.de>
 <CAPnjgZ22FbGcdF-=8B-Kh44e_MGKuVrSZn6UfeTU_fx-n7Fb5w@mail.gmail.com>
Message-ID: <CAPnjgZ2wYs67be3a8yd5x4g+sKtz5crzuBgR9x_jnVP0q4bJaw@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

HI Heinrich,

On Thu, 11 Feb 2021 at 10:34, Simon Glass <sjg@chromium.org> wrote:
>
> On Wed, 10 Feb 2021 at 10:59, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> > UEFI test files like helloworld.efi require an architecture specific
> > PE-COFF header.
> >
> > Currently this does not work for cross compiling. If $CROSS_COMPILE is set,
> > use the first part of the architecture triplet from the variable to
> > choose the PE-COFF header.
> >
> > Now we can cross-compile the sandbox, e.g.
> >
> >     make sandbox_defconfig NO_SDL=1
> >     CROSS_COMPILE=/opt/bin/aarch64-linux-gnu- NO_SDL=1 MK_ARCH=aarch64 make
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> > v2:
> >         use $CROSS_COMPILE instead of an extra environment variable
> > ---
> >  Makefile | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
>

With this patch if I try to build sandbox with CROSS_COMPILE=/bin/ it fails.

In fact 'buildman -A sandbox' will return '/bin/' so I'd like your
thoughts on what to do about this. Should we modify your patch or
perhaps make buildman return something else with -A sandbox?

Regards,
Simon

> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm/next, thanks!