All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 7/8] x86: efi: Add a hello world test program
Date: Mon, 7 Nov 2016 07:46:00 -0800	[thread overview]
Message-ID: <CAPnjgZ2xTXxh-jipj=ow1+gxAdYjKeMxh3jvHnRjYz7t6EHO4A@mail.gmail.com> (raw)
In-Reply-To: <cd8cad07-cf50-32fd-b17e-67af9f3e6dac@suse.de>

Hi Alex,

On 19 October 2016 at 01:09, Alexander Graf <agraf@suse.de> wrote:
>
>
> On 18/10/2016 22:37, Simon Glass wrote:
>> Hi Alex,
>>
>> On 18 October 2016 at 01:14, Alexander Graf <agraf@suse.de> wrote:
>>> On 10/18/2016 04:29 AM, Simon Glass wrote:
>>>>
>>>> It is useful to have a basic sanity check for EFI loader support. Add a
>>>> 'bootefi hello' command which loads HelloWord.efi and runs it under
>>>> U-Boot.
>>>>
>>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>>> ---
>>>>
>>>> Changes in v3:
>>>> - Include a link to the program instead of adding it to the tree
>>>
>>>
>>> So, uh, where is the link?
>>
>> I put it in the README (see the arm patch).
>>
>>>
>>> I'm really not convinced this command buys us anything yet. I do agree that
>>> we want automated testing - but can't we get that using QEMU and a
>>> downloadable image file that we pass in as disk and have the distro boot do
>>> its magic?
>>
>> That seems very heavyweight as a sanity check, although I agree it is useful.
>
> It's not really much more heavy weight. The "image file" could simply
> contain your hello world binary. But with this we don't just verify
> whether "bootefi" works, but also whether the default boot path works ok.

I don't think I understand what you mean by 'image file'. Is it
something other than the .efi file? Do you mean a disk image?

>
>> Here I am just making sure that EFI programs can start, print output
>> and exit. It is a test that we can easily run without a lot of
>> overhead, much less than a full distro boot.
>
> Again, I don't think it's much more overhead and I do believe it gives
> us much cleaner separation between responsibilities of code (tests go
> where tests are).

You are talking about a functional test, something that tests things
end to end. I prefer to at least start with a smaller test. Granted it
takes a little more work but it means there are fewer things to hunt
through when something goes wrong.

Regards,
Simon

  reply	other threads:[~2016-11-07 15:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18  2:29 [U-Boot] [PATCH v3 1/8] x86: Add implementations of setjmp() and longjmp() Simon Glass
2016-10-18  2:29 ` [U-Boot] [PATCH v3 2/8] efi: Use asmlinkage for EFIAPI Simon Glass
2016-10-18  7:12   ` Alexander Graf
2016-10-18 20:37     ` Simon Glass
2016-10-19  7:11       ` Alexander Graf
2016-11-07 15:45         ` Simon Glass
2016-10-18  2:29 ` [U-Boot] [PATCH v3 3/8] efi: Fix missing EFIAPI specifiers Simon Glass
2016-10-18  2:29 ` [U-Boot] [PATCH v3 4/8] x86: Tidy up selection of building the EFI stub Simon Glass
2016-10-18  3:07   ` Bin Meng
2016-10-18  2:29 ` [U-Boot] [PATCH v3 5/8] arm: efi: Add a hello world test program Simon Glass
2016-10-18  2:29 ` [U-Boot] [PATCH v3 6/8] x86: efi: Add EFI loader support for x86 Simon Glass
2016-10-18  2:29 ` [U-Boot] [PATCH v3 7/8] x86: efi: Add a hello world test program Simon Glass
2016-10-18  3:06   ` Bin Meng
2016-10-18  7:14   ` Alexander Graf
2016-10-18 20:37     ` Simon Glass
2016-10-19  7:09       ` Alexander Graf
2016-11-07 15:46         ` Simon Glass [this message]
2016-11-07 16:32           ` Alexander Graf
2016-11-11 16:17             ` Simon Glass
2016-11-12  6:23               ` Alexander Graf
2016-11-14 20:44                 ` Simon Glass
2016-11-14 20:46                   ` Alexander Graf
2016-11-14 20:58                     ` Simon Glass
2016-11-14 21:24                       ` Alexander Graf
2016-11-14 21:35                         ` Simon Glass
2016-10-18  2:29 ` [U-Boot] [PATCH v3 8/8] x86: Enable EFI loader support Simon Glass
2016-10-18  3:02 ` [U-Boot] [PATCH v3 1/8] x86: Add implementations of setjmp() and longjmp() Bin Meng
2016-10-18  3:20   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ2xTXxh-jipj=ow1+gxAdYjKeMxh3jvHnRjYz7t6EHO4A@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.