From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F423C433EF for ; Sun, 24 Oct 2021 20:00:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFF5160EDF for ; Sun, 24 Oct 2021 20:00:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CFF5160EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7F2F283601; Sun, 24 Oct 2021 21:58:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="hvH3Qnv5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B83C983531; Sun, 24 Oct 2021 21:55:24 +0200 (CEST) Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AD8328350D for ; Sun, 24 Oct 2021 21:55:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x22f.google.com with SMTP id y207so12665580oia.11 for ; Sun, 24 Oct 2021 12:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zjFC2OhPKcA96CDi8gOd2cy6nujE6gqymoBgT3hhVtw=; b=hvH3Qnv5Z/a8A0fYgJGU5c5PcZAP3Y/aLX5k8M/SHRC9uJS+qxcVeVcjb+y7GwDs4K FAzDs9aCpfykJWhlJ/8PBGMKBb068ron7rPZ06xWRJhdUrcxjTLct16btQ2zXWbuO3MW d8gvMbD4JNrRyBmLPzTBSHFAL27CbRahxBRJc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zjFC2OhPKcA96CDi8gOd2cy6nujE6gqymoBgT3hhVtw=; b=JRmEHrNCNRkKC9TyBr+k/KXvm6+XveReNmxBYC6/mjZGQOTvgBvi/Uq5e22g0mK+Bo 7cd0VnE+efH/JHnzc4CV00LHgsrCwMNNRe9C79YjWwScWSaiVTK5fXgN09lzScEIiiAl EIecJGZsczYzXDJ7vpl7cS58qioc6g8tvwzJDeSP8WaPjynkvHR9V0K63JAlMUgHF/Gx aq0pBFExdvvz2uT1ZAWlN2aB9P5AX/XqJDu3qNnS8SJs3csJKcet67O4KvLobydwBoMV QJ7Wo6kfJ2CEeQh4n6y7+aKfwz/Uc3RVF+6fMf2PPI6tY43dQl21r7D4Z8raYXID4dnk lYog== X-Gm-Message-State: AOAM530rK6elYEpMiCwfx5P4jaMm2egFMydCrc0nLLQQqc7bU6+ZMU6h nDGDm9p6lh3xPcHRF+qYFPzGekWUNcMypcMu+iNeUQ== X-Google-Smtp-Source: ABdhPJzX2MJ9kLMPRGxUhTBe0UraOhPv+b87pCRsnlWAxTkOK6Z+O5C82sqliH/FZsgPfLPtHtPQcOoAdcbetf3yZ30= X-Received: by 2002:aca:ab15:: with SMTP id u21mr9214930oie.53.1635105306644; Sun, 24 Oct 2021 12:55:06 -0700 (PDT) MIME-Version: 1.0 References: <20211014180824.10681-1-heiko.thiery@gmail.com> <20211014180824.10681-2-heiko.thiery@gmail.com> In-Reply-To: From: Simon Glass Date: Sun, 24 Oct 2021 13:54:03 -0600 Message-ID: Subject: Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support To: Heiko Thiery Cc: Stefano Babic , U-Boot Mailing List , Fabio Estevam , "NXP i . MX U-Boot Team" , Peng Fan , Ye Li , Patrick Wildt , Michael Walle , =?UTF-8?Q?Thomas_Sch=C3=A4fer?= Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heiko, On Fri, 22 Oct 2021 at 11:54, Heiko Thiery wrote: > > Hi Simon, > > Am Fr., 22. Okt. 2021 um 18:07 Uhr schrieb Simon Glass : > > > > Hi Heiko, > > > > On Fri, 22 Oct 2021 at 07:24, Heiko Thiery wrote: > > > > > > Hi, > > > > > > Am Fr., 22. Okt. 2021 um 14:37 Uhr schrieb Stefano Babic : > > > > > > > > Hi Heiko, > > > > > > > > On 22.10.21 10:19, Heiko Thiery wrote: > > > > > Hi Stefano, Hi Simon, > > > > > > > > > > Am Do., 21. Okt. 2021 um 15:57 Uhr schrieb Heiko Thiery > > > > > : > > > > >> > > > > >> Hi Stefano, Hi Simon, > > > > >> > > > > >> > > > > >> Am Do., 21. Okt. 2021 um 15:29 Uhr schrieb Stefano Babic : > > > > >>> > > > > >>> On 21.10.21 15:17, Heiko Thiery wrote: > > > > >>>> Hi Stefano, > > > > >>>> > > > > >>>> > > > > >>>> Am Do., 21. Okt. 2021 um 13:31 Uhr schrieb Stefano Babic : > > > > >>>>> > > > > >>>>> Hi Heiko, > > > > >>>>> > > > > >>>>> On 14.10.21 20:08, Heiko Thiery wrote: > > > > >>>>>> The Kontron pitx-imx8m is an NXP i.MX8MQ based board in the pITX > > > > >>>>>> form factor. > > > > >>>>>> > > > > >>>>> > > > > >>>>> There is still something using binman that does not work with CI. > > > > >>>>> Without CI, we load all firmware including signed_hdmi_imx8m.bin. > > > > >>>>> > > > > >>>>> But on CI, file is not loaded, but instead of warnings, build for this > > > > >>>>> board fails with : > > > > >>>>> > > > > >>>>> +Image 'main-section' is missing external blobs and is non-functional: > > > > >>>>> blob-ext@1 blob-ext@2 blob-ext@3 blob-ext@4 > > > > >>>>> +binman: Error 1 running 'mkimage -d ./mkimage.spl.mkimage -n > > > > >>>>> spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000 > > > > >>>>> ./mkimage-out.spl.mkimage': signed_hdmi_imx8m.bin: Can't open: No such > > > > >>>>> file or directory > > > > >>>>> + > > > > >>>>> > > > > >>>>> Could you take a look ? > > > > >>>> > > > > >>>> Sure. Could you point me to the right CI configuration? > > > > >>>> > > > > >>> > > > > >>> Configuration is in .gitlab-ci.yml. For thsi board, buildman is called > > > > >>> as part of aarch64 target, that is > > > > >>> > > > > >>> buildman -o /tmp -P -E -W arm -x aarch64 > > > > >>> > > > > >>>> I need to understand how the required imx-firmware files are copied to > > > > >>>> the u-boot dir. This seems to work already for e. g. the imx8mm > > > > >>>> boards. These require the lpdd* train fw files. > > > > >> > > > > >> Here we seem to hit an issue with the CI. blobs (lpddr*) are required > > > > >> for the imx8mm boards. Binman reports the missing files only as a > > > > >> warning and buildman does not care about that: > > > > >> ---- > > > > >> +WARNING 'mkimage.flash.mkimage' not found, resulting binary is not-functional > > > > >> ---- > > > > >> > > > > >> With the imx8mq boards switching to binman we also need an additional > > > > >> fw part (signed_hdmi_imx8m.bin). But other than the lpddr firmware as > > > > >> blob the signed_hmdi'_imx8m.bin is passed to mkimage and mkimage exits > > > > >> with an error. Thats leads to the error: > > > > >> ---- > > > > >> binman: Error 1 running 'mkimage -d ./mkimage.spl.mkimage -n > > > > >> spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000 > > > > >> ./mkimage-out.spl.mkimage': signed_hdmi_imx8m.bin: Can't open: No such > > > > >> file or directory > > > > >> ---- > > > > >> > > > > >> Currently I do not have an idea how to handle that. Anyone else? > > > > If I understand correctly: > > > > 1.You don't have these blobs in the tree so don't want to fail a build > > in CI, which is why binman's blob-ext is used > > Correct, for the imx8mq e.g. the signed_hdmi_imx8m.bin is required > that comes from NXP and has to be copied to the u-boot build dir. > > > 2. You sometimes need to ensure that they do exist > > For the build the "signed_hdmi_imx8m.bin" is required to successfully build. > > > Should we add a cmdline flag to binman to require all external blobs? > > I do not understand that. What should happen if this flag is present? > > > Could we drop the blobs and add code to generate them, or put the date > > in a C struct? > > No, this is not possible because they are delivered by NXP from the > firmware-imx package and has to be copied from there. Perhaps they should upstream that stuff and turn it into code in U-Boot? Anyway, I think you are working on this, per the irc chat. [..] Regards, Simon