All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] x86: qemu: Drop our own ACPI implementation
Date: Wed, 20 Apr 2016 08:37:49 -0600	[thread overview]
Message-ID: <CAPnjgZ3-QZ73WdwgLQuggSK+2VCkYXWHEqJCSsQqCjA-0_u8VA@mail.gmail.com> (raw)
In-Reply-To: <CAEUhbmUAzN3juqaFapAFrjSt-ecy1omC283yg0g0TVTeDTgONw@mail.gmail.com>

Hi Bin,

On 20 April 2016 at 07:45, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Simon,
>
> On Wed, Apr 20, 2016 at 9:13 PM, Simon Glass <sjg@chromium.org> wrote:
> > Hi Bin,
> >
> > On 13 April 2016 at 01:52, Bin Meng <bmeng.cn@gmail.com> wrote:
> >> Our own ACPI implementation (when CONFIG_QEMU_ACPI_TABLE is not set)
> >> does not build anymore after x86 has been fully converted to DM PCI.
> >> Instead of trying to fix the build errors, given we now have the ACPI
> >> support via QEMU's fw_cfg interface, which is a more reliable way to
> >> generate correct ACPI tables then by ourselves, hence drop our own
> >> ACPI implementation.
> >>
> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >>
> >> ---
> >>
> >> arch/x86/cpu/qemu/Makefile | 3 -
> >> arch/x86/cpu/qemu/acpi.c | 176 --------------
> >> arch/x86/cpu/qemu/acpi/cpu-hotplug.asl | 80 -------
> >> arch/x86/cpu/qemu/acpi/dbug.asl | 25 --
> >> arch/x86/cpu/qemu/acpi/hpet.asl | 31 ---
> >> arch/x86/cpu/qemu/acpi/isa.asl | 102 --------
> >> arch/x86/cpu/qemu/acpi/pci-crs.asl | 61 -----
> >> arch/x86/cpu/qemu/dsdt.asl | 412 ---------------------------------
> >> 8 files changed, 890 deletions(-)
> >> delete mode 100644 arch/x86/cpu/qemu/acpi.c
> >> delete mode 100644 arch/x86/cpu/qemu/acpi/cpu-hotplug.asl
> >> delete mode 100644 arch/x86/cpu/qemu/acpi/dbug.asl
> >> delete mode 100644 arch/x86/cpu/qemu/acpi/hpet.asl
> >> delete mode 100644 arch/x86/cpu/qemu/acpi/isa.asl
> >> delete mode 100644 arch/x86/cpu/qemu/acpi/pci-crs.asl
> >> delete mode 100644 arch/x86/cpu/qemu/dsdt.asl
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> > My only concern is that this was supposed to lead to ACPI support for real
> > hardware. If you drop this, does it make it harder?
>
> No, the infrastructure is still there. Only the QEMU ASL (manual) part
> was removed. I am going to add ACPI support to BayTrail soon
> (hopefully).

OK, that's fine.

Regards,
Simon

  reply	other threads:[~2016-04-20 14:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  7:52 [U-Boot] [PATCH] x86: qemu: Drop our own ACPI implementation Bin Meng
2016-04-20  7:34 ` Bin Meng
2016-04-20 13:13 ` Simon Glass
2016-04-20 13:34   ` Saket Sinha
2016-04-20 13:45   ` Bin Meng
2016-04-20 14:37     ` Simon Glass [this message]
2016-04-20 14:40     ` Stefan Roese
2016-04-20 14:42       ` Bin Meng
2016-04-20 14:56         ` Saket Sinha
2016-04-22  3:25   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3-QZ73WdwgLQuggSK+2VCkYXWHEqJCSsQqCjA-0_u8VA@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.