From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D8F7C433F5 for ; Wed, 24 Nov 2021 17:49:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7C73983744; Wed, 24 Nov 2021 18:49:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Lx30SjBX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B38CC83679; Wed, 24 Nov 2021 18:48:12 +0100 (CET) Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CD8C5830E7 for ; Wed, 24 Nov 2021 18:48:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x930.google.com with SMTP id l24so6816826uak.2 for ; Wed, 24 Nov 2021 09:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:from:in-reply-to:references:date:message-id :subject:to:cc; bh=9Tv2eTI3APUWVkkJ90ebTaKh8HVVM2YjkBvgvl0ja6w=; b=Lx30SjBXDLgKVpFMGe+M6MEhtmyHpLMSGaYkSCBmEs9KNk47tdI+qfesRW4XaFwPqj 3jb4MZgBaVZMbZGqzTUhyAfjo3tAt6MxKy1ld2Xc48xxnIZiACeRQf5q7PdGbo3xYOq4 zSXgRyBCT8w9tHIkFVSbLuMsn9dSmlecrkNOM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:sender:from:in-reply-to:references :date:message-id:subject:to:cc; bh=9Tv2eTI3APUWVkkJ90ebTaKh8HVVM2YjkBvgvl0ja6w=; b=xC1x7/gSOjr092wVbi7tK32gSUsQouKZKiQVl99ha1H7HNMpsQUcKuHK/pJqEfIVFk E5vb71vIbijI45pGwBZoYIL7olyYfk1sjsAnxCcKHMwEB1jYWmGdFLWl235DjisqTAkM +fh+7uq4ESGYNp+fBb6qXURIJO7QWlrpukvl7mngFYIQUIRtB9je5OSTOlmTfoZgiTbn ShfVP0qCMlY3T5ShAgFeIYIBhZCZbbCg/ZFbbdUiZvLrmlj7+tgkDrgc2WnwGgb0d+y5 yLxcMEsu6ICGjF1qlUeXpMKOptMOe9+eFLUJ+7HJPC6O3XI1p+kaRdk+7xTHDGDtEm3z n50w== X-Gm-Message-State: AOAM530bEYwr3e+1jnVXWnA4Egx6AMY10245btDoJwDydiFLyRJf7wFZ EygSzwztTrzovcJUna9IIcGihPYTVbOL7Ix8A041yA== X-Google-Smtp-Source: ABdhPJxx5Gv8bCRCMvADGiH7jy6MeCOosSxa5kNhFqvtsGONRSyUhQMHggtI6fMkTB+TVxEQF9nu4bZmHPLtaWergf0= X-Received: by 2002:a67:db0b:: with SMTP id z11mr25475238vsj.59.1637776079360; Wed, 24 Nov 2021 09:47:59 -0800 (PST) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Wed, 24 Nov 2021 12:47:58 -0500 MIME-Version: 1.0 From: Simon Glass In-Reply-To: References: <89fdf34f-5403-ac21-1c78-ed4d766d648e@gmx.de> <20210919214937.3829422-1-sjg@chromium.org> <20210919214937.3829422-2-sjg@chromium.org> Date: Wed, 24 Nov 2021 12:47:58 -0500 X-Google-Sender-Auth: ugSU63lUS9n8mo4h_zpRMvGmmdk Message-ID: Subject: Re: [PATCH v4 1/5] command: Use a constant pointer for the help To: Simon Glass Cc: Jagan Teki , U-Boot Mailing List , Heinrich Schuchardt Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/19/21 23:49, Simon Glass wrote: > This text should never change during execution, so it makes sense to > use a const char * so that it can be declared as const in the code. > Update struct cmd_tbl with a const char * pointer for 'help'. > > We cannot make usage const because of the bmode command, used on mx53ppd > for example. > > Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v2) > > Changes in v2: > - Explain why 'usage' cannot be const > > include/command.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to u-boot-dm, thanks! Applied to u-boot-dm/next, thanks!