From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78644C636CC for ; Tue, 7 Feb 2023 04:04:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3ECB985D4A; Tue, 7 Feb 2023 05:04:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="TjpvSx+V"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 91F5885D38; Tue, 7 Feb 2023 05:04:31 +0100 (CET) Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B55B85D46 for ; Tue, 7 Feb 2023 05:04:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5258f66721bso132609167b3.1 for ; Mon, 06 Feb 2023 20:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tFoiXBz7xarv0r1j19ykuTNBcxGcLRgl3TPYNn/s0uw=; b=TjpvSx+VpjE/BmLFDmFqKU0SUNOooaSsxu/7NnWvtn7SvkpWd0JmwanA2SoVhMrKS+ 4f3sHEfFIdLCGYKSPM+eDJ6PYOoQop8VDcHIhbxCRHCAWqq6ZNlMswY/9L4DjttyT+uT f/0+FK1oAIDlBulOYfEz8djQjD53K6xXPn6is= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tFoiXBz7xarv0r1j19ykuTNBcxGcLRgl3TPYNn/s0uw=; b=si0J0U4oCkU2o8l6lpg+5b30fWUolXY/X3CZV9IVmeQ8Rz/KUHIr6bZJjTPe0pltcs kLiA7WeTlA5h8eLLG6Ix8H1OOs9YG3FBu2Dhiv+goOdJLpl2tnSDYFiRum6XbvuEmlxj 6SsDV5IREhSE91vkfPnc7Uq3SR4ZBKWDOoGes7BtT9HQe25Vo+hovj31Ai1j4mOUL90S /PIrEt0AIFhcH8NxqrGf+Rr7sVCZQpV5jCG4EMyBF90XcNu6HpQVaWNI4/eQMWMCf/tC krtT+gNJhww+nfjVP8N9rk2JOpAf8qVVkxxNeQkBEiXLjNX3yijnsGnNQTcrFyNwMG9f +a/Q== X-Gm-Message-State: AO0yUKWU+/O0T3gvo9KiIa/WbZ0YSO7UpqyWu3Oje11XevIqaXqewQla rnxr9i9fYF+5KQAgyKJAU4BRWpj/LKCr+X2x+bEnlw== X-Google-Smtp-Source: AK7set/joxzYqHVqi5xTHS0Ye1XgKKirhvWdW7CdNAAy8xykDByFdPc5haJa90kBELGQSWsHms1amKVk+TFFwQPn6zs= X-Received: by 2002:a81:9111:0:b0:50f:929a:878e with SMTP id i17-20020a819111000000b0050f929a878emr176104ywg.217.1675742656955; Mon, 06 Feb 2023 20:04:16 -0800 (PST) MIME-Version: 1.0 References: <20230205235021.355410-1-souajih@baylibre.com> <20230205235021.355410-10-souajih@baylibre.com> In-Reply-To: <20230205235021.355410-10-souajih@baylibre.com> From: Simon Glass Date: Mon, 6 Feb 2023 21:02:34 -0700 Message-ID: Subject: Re: [PATCH v3 09/19] android: boot: add vendor boot image to prepare for v3,v4 support To: Safae Ouajih Cc: u-boot@lists.denx.de, sean.anderson@seco.com, r.stratiienko@gmail.com, mkorpershoek@baylibre.com, glaroque@baylibre.com, khilman@baylibre.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sun, 5 Feb 2023 at 16:50, Safae Ouajih wrote: > > Introduce vendor boot image for version 3 and 4 of boot image header. > The vendor boot image will hold extra information about kernel, dtb > and ramdisk. > > This is done to prepare for boot image version 3 and 4 support. > > Signed-off-by: Safae Ouajih > --- > boot/bootm.c | 8 +++---- > boot/image-android.c | 54 ++++++++++++++++++++++++++++---------------- > boot/image-board.c | 3 +-- > boot/image-fdt.c | 3 ++- > cmd/abootimg.c | 4 ++-- > include/image.h | 48 ++++++++++++++++++++++++++++++--------- > 6 files changed, 81 insertions(+), 39 deletions(-) I don't see a change log but I see some comments. Not sure what else I said on the review. Reviewed-by: Simon Glass