From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFA09C001DC for ; Fri, 28 Jul 2023 01:54:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EF1DD868B2; Fri, 28 Jul 2023 03:54:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="jMuhGCpE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A41D3865DD; Fri, 28 Jul 2023 03:52:53 +0200 (CEST) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E262F867D8 for ; Fri, 28 Jul 2023 03:52:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-c4cb4919bb9so1544824276.3 for ; Thu, 27 Jul 2023 18:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690509156; x=1691113956; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OocXhwWQ7O80b77OE0PHg2/2/8o6Capj2E0mzSwH8CY=; b=jMuhGCpEWCM/qKInS8P5pL7dUih6GTkfeI2IxhlnXO3D2CeQXkE67aTTzCt6u9wr06 KReh9dGEaiZLKlW+4vXibW5ZTnDbW8fuZMcG5qc7dzhBvEpNMpAxeuUyEjKrygqhQGyG 195lla9dT+7/tP0nDq2rW9WD0I/l0rzDSKqhcg96MSr/6KWpSffIgCLfUhuKwvHXBibM /zLz5Cw6hYaGdjC2uX9BvMH0mJR6w4Pqy6xL5Cav62wr1s8cIqwXAkSlObHRX5Jl0UWu ptvrL964tK7t+rBiBBBfXfM2CnlNq9QFIB8cUqKQkRrzXSP2hhJuOHADi2cyG4LmlzGC dpFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690509156; x=1691113956; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OocXhwWQ7O80b77OE0PHg2/2/8o6Capj2E0mzSwH8CY=; b=MaqcXv0NozHrBUyBfbNnxy5ql1QtxLFbR+1rV9VLBwjBBi4vYaOc7lt+RFFgLe+DB1 Z9p2Caf8fq878YvgA2RvLBiyelg8GD4oOgzi90bgqaPfqXV5OW6+Qw8P496/DQ3clsvd rABZQEWyOk51xlRqX9h4FgXGHCwvne+5ZFpw5k/Idv2kgrvZQZmgco+WBLoMbDqAbj0z 69pLlUVRJs1j0NZAFRzpLaRf9kHLDyUGuw/ZUjiLyHN/AZO52kt/+jdn8ZDFf/RWooF/ 5MSe2sU+bFqhgd/GFrk2QoMvVxmEq+INTJ8jWxzKxvfYRLdy5QTzRgyQKnvJKn6xkE8E ml0Q== X-Gm-Message-State: ABy/qLYmzY2Sraf+LJYnHX4HZt3Dbr2gHWcmre8jR7eNvNnAjtwh0mHT Wy9N/aFYxcu/AE6DVDeKVbQZxXGcdB1odUIGiVk0+w== X-Google-Smtp-Source: APBJJlGH5TN0W/N97/TIAmEyyuLOaOLzcdRcVUNnzGzMv0rGv4s1dgY8nCoot9xARUqHcS2YsMlUmQNkaImLoDAiNnA= X-Received: by 2002:a25:850e:0:b0:c4c:bff1:2f87 with SMTP id w14-20020a25850e000000b00c4cbff12f87mr321342ybk.15.1690509155923; Thu, 27 Jul 2023 18:52:35 -0700 (PDT) MIME-Version: 1.0 References: <20220329151659.16894-1-abdellatif.elkhlifi@arm.com> <20220329151659.16894-3-abdellatif.elkhlifi@arm.com> <14abbf36-f536-fb8c-2ac7-833c62f7fb4b@gmx.de> <20230727090027.GA23053@e130802.arm.com> In-Reply-To: <20230727090027.GA23053@e130802.arm.com> From: Simon Glass Date: Thu, 27 Jul 2023 19:52:00 -0600 Message-ID: Subject: Re: [PATCH 2/6] arm_ffa: introduce armffa command To: Abdellatif El Khlifi Cc: Heinrich Schuchardt , nd@arm.com, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Abdellatif, On Thu, 27 Jul 2023 at 03:00, Abdellatif El Khlifi wrote: > > Hi Heinrich, > > On Thu, Jul 27, 2023 at 07:51:42AM +0200, Heinrich Schuchardt wrote: > > On 3/29/22 17:16, abdellatif.elkhlifi@arm.com wrote: > > > From: Abdellatif El Khlifi > > > > > > Provide armffa command showcasing the use of the FF-A driver > > > > > > The armffa command allows to query secure partitions data from > > > the secure world and exchanging messages with the partitions. > > > > > > Signed-off-by: Abdellatif El Khlifi > > > Cc: Tom Rini > > > --- > > > MAINTAINERS | 1 + > > > cmd/Kconfig | 10 ++ > > > cmd/Makefile | 2 + > > > cmd/armffa.c | 266 ++++++++++++++++++++++++++++++++++++++++ > > > drivers/arm-ffa/Kconfig | 1 + > > > > We want to have all commands to be documented in /doc/usage/cmd/. > > > > Could you, please, provide the missing /doc/usage/cmd/armffa.rst file. > > > > It's here [1]. I'd suggest mentioning that in the commit message for this patch, or even putting the testin the same patch, along with the test for the command. I find it hard to keep track of this too. > > [1]: https://lore.kernel.org/all/20230726094503.100497-6-abdellatif.elkhlifi@arm.com/#Z31doc:usage:cmd:armffa.rst > > Cheers, > Abdellatif Regards, Simon