Re: [PATCH 2/3] cmd: fdt: allow standalone "fdt move"

From: Simon Glass <sjg@chromium.org>
To: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>,
	 Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	 Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH 2/3] cmd: fdt: allow standalone "fdt move"
Date: Sun, 17 Jul 2022 04:12:57 -0400	[thread overview]
Message-ID: <CAPnjgZ33r=AX6AiJMTuLkJQjg_PESpQPtcny_BnfnGRPwW1b_w@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ0J1Vbtj-PvUe1w2NZ_CnunZy3ivE6J6p_WxxaMpvV8nw@mail.gmail.com>

On Tue, 5 Jul 2022 at 11:14, Andre Przywara <andre.przywara@arm.com> wrote:
>
> At the moment every subcommand of "fdt", except "addr" itself, requires
> the DT address to be set first. We explicitly check for that before even
> comparing against the subcommands' string.
> This early bailout also affects the "move" subcommand, even though that
> does not require or rely on a previous call to "fdt addr". In fact it
> even sets the FDT address to the target of the move command, so is a
> perfect beginning for a sequence of fdt commands.
>
> Move the check for a previously set FDT address to after we handle the
> "move" command also, so we don't need a dummy call to "fdt addr" first,
> before being able to move the devicetree.
>
> This skips one pointless "fdt addr" call in scripts which aim to alter
> the control DT, but need to copy it to a safe location first (for
> instance to $fdt_addr_r).
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  cmd/fdt.c | 28 +++++++++++++++++-----------
>  1 file changed, 17 insertions(+), 11 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!