From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Tue, 23 Mar 2021 13:56:40 +1300 Subject: [PATCH 02/16] drivers: reset: Handle gracefully NULL pointers In-Reply-To: References: <20210309122748.31842-1-kishon@ti.com> <20210309122748.31842-3-kishon@ti.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Kishon, On Mon, 22 Mar 2021 at 18:11, Kishon Vijay Abraham I wrote: > > Hi Simon, > > On 12/03/21 10:15 am, Simon Glass wrote: > > Hi Kishon, > > > > On Tue, 9 Mar 2021 at 05:27, Kishon Vijay Abraham I wrote: > >> > >> From: Jean-Jacques Hiblot > >> > >> Prepare the way for a managed reset API by handling NULL pointers without > >> crashing nor failing. > >> > >> Signed-off-by: Jean-Jacques Hiblot > >> Signed-off-by: Vignesh Raghavendra > >> Signed-off-by: Kishon Vijay Abraham I > >> --- > >> drivers/reset/reset-uclass.c | 30 +++++++++++++++++------------- > >> 1 file changed, 17 insertions(+), 13 deletions(-) > > > > Why do you want this? This patch is missing the motivation which > > should be at the start of the commit message. > > This is for "optional" reset controllers used by peripheral drivers. > This will help avoid adding checks in peripheral drivers. Can you please be more specific? Reset drivers are required to have operations. Only a very few uclasses allow the operations pointer to be NULL. Regards, Simon