All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH v3 11/22] common: Drop init.h from common header
Date: Mon, 11 May 2020 14:28:52 -0600	[thread overview]
Message-ID: <CAPnjgZ37F8Dt13Q0ijqXMPbn1RWRQJ6UUBdOuE7wt7s=EMvWaA@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNARkc6jOvYK1fvG7-HF3mm4fOp0=J04ec69e+Pf5FJPm=A@mail.gmail.com>

Hi Masahiro,

On Mon, 11 May 2020 at 01:05, Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Mon, May 11, 2020 at 3:44 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Simon,
> >
> > On Mon, May 11, 2020 at 7:58 AM Simon Glass <sjg@chromium.org> wrote:
> > >
> > > Move this uncommon header out of the common header.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> >
> > Why are you adding <init.h> to
> > arch/arm/mach-uniphier/cpu-info.c,
> > which does not include <common.h>
> > in the first place?
> >
> >
> > This seems a wrong conversion.
> >
> > For uniphier, NACK.
>
>
>
> Hmm, are you fixing -Wmissing-prototypes,
> which is displayed with W=1 builds.

I wonder how bad it would be if we enabled that option?

>
> If so, adding <init.h> to arch/arm/mach-uniphier/cpu-info.c
> makes sense although it is unclear from commit log.
>
>
> But, I still do not understand why you are adding <init.h> to
> arch/arm/mach-uniphier/dram/umc-pxs2.c
>
> It looks fine to me as-is.

Yes it is not needed - the dram_init() is throwing things off.

However given the scale of this series this seems like a small problem.

Regards,
Simon

  reply	other threads:[~2020-05-11 20:28 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 17:39 [PATCH v3 00/22] common: Further reduce the size of common.h Simon Glass
2020-05-10 17:39 ` [PATCH v3 01/22] common: Drop uuid.h from common header Simon Glass
2020-05-19 17:31   ` Tom Rini
2020-05-10 17:39 ` [PATCH v3 02/22] flash: Tidy up coding style for flash functions Simon Glass
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:39 ` [PATCH v3 03/22] common: Drop flash.h from common header Simon Glass
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:39 ` [PATCH v3 04/22] arm: Don't include common.h in header files Simon Glass
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:39 ` [PATCH v3 05/22] common: Drop net.h from common header Simon Glass
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:39 ` [PATCH v3 06/22] part: Drop disk_partition_t typedef Simon Glass
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:39 ` [PATCH v3 07/22] common: Drop part.h from common header Simon Glass
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:39 ` [PATCH v3 08/22] bootstage: Use BOOTSTAGE instead of BOOTSTATE Simon Glass
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 09/22] common: Drop bootstage.h from common header Simon Glass
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 10/22] common: Drop image.h " Simon Glass
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 11/22] common: Drop init.h " Simon Glass
2020-05-11  6:44   ` Masahiro Yamada
2020-05-11  7:04     ` Masahiro Yamada
2020-05-11 20:28       ` Simon Glass [this message]
2020-05-19 17:32   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 12/22] command: Remove the cmd_tbl_t typedef Simon Glass
2020-05-19 17:33   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 13/22] Fix some checkpatch warnings in calls to debug() Simon Glass
2020-05-19 17:33   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 14/22] common: Drop log.h from common header Simon Glass
2020-05-19 17:33   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 15/22] common: Drop asm/ptrace.h " Simon Glass
2020-05-19 17:33   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 16/22] common: Drop asm_offsets.h " Simon Glass
2020-05-19 17:33   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 17/22] common: Drop linux/bug.h " Simon Glass
2020-05-19 17:33   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 18/22] common: Drop linux/stringify.h " Simon Glass
2020-05-19 17:33   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 19/22] Fix some checkpatch warnings in calls to udelay() Simon Glass
2020-05-19 17:33   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 20/22] common: Drop linux/delay.h from common header Simon Glass
2020-05-19 17:34   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 21/22] Use __ASSEMBLY__ as the assembly macros Simon Glass
2020-05-11  4:56   ` Masahiro Yamada
2020-05-11 20:28     ` Simon Glass
2020-05-11 21:15       ` Tom Rini
2020-05-19 17:34   ` Tom Rini
2020-05-10 17:40 ` [PATCH v3 22/22] common: Drop linux/bitops.h from common header Simon Glass
2020-05-19 17:34   ` Tom Rini
2020-05-15 21:02 ` [PATCH v3 00/22] common: Further reduce the size of common.h Simon Glass
2020-05-15 21:13   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ37F8Dt13Q0ijqXMPbn1RWRQJ6UUBdOuE7wt7s=EMvWaA@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.