From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] asm-generic: global_data: change timebase_l/h to unsigned int
Date: Tue, 2 May 2017 05:27:39 -0600 [thread overview]
Message-ID: <CAPnjgZ37fipfoGs07iZ_CD1PK0+k+ASon8tVF70L+3tS-SY-rA@mail.gmail.com> (raw)
In-Reply-To: <VI1PR04MB11663B56E8E463B99D4BB902881E0@VI1PR04MB1166.eurprd04.prod.outlook.com>
Hi Peng,
On 25 April 2017 at 14:51, Peng Fan <peng.fan@nxp.com> wrote:
> Hi Simon,
>
>> -----Original Message-----
>> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
>> Sent: Monday, April 24, 2017 11:38 AM
>> To: Peng Fan <peng.fan@nxp.com>
>> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Tom Rini
>> <trini@konsulko.com>; Eddie Cai <eddie.cai.linux@gmail.com>; Jagan Teki
>> <jteki@openedev.com>; york sun <york.sun@nxp.com>; Robert P. J. Day
>> <rpjday@crashcourse.ca>; Michal Simek <michal.simek@xilinx.com>
>> Subject: Re: [PATCH 2/2] asm-generic: global_data: change timebase_l/h to
>> unsigned int
>>
>> Hi Peng,
>>
>> On 19 April 2017 at 19:10, Peng Fan <peng.fan@nxp.com> wrote:
>> > Change type of timebase_l/h to unsigned int.
>>
>> What is the motivation for this, please?
>
> From lib/time.c: ((uint64_t)gd->timebase_h << 32) | gd->timebase_l;
>
> This piece code is based on that timebase_h and timebase_l are 32bits width, I think.
> But unsigned long are 64bits width on ARM64. I am not sure, but I suppose same case
> on other archs.
OK I see. I suspect it would make more sense to have a single 64-bit
value on 64-bit machines, but perhaps that is a separate point.
Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Thanks,
> Peng.
>
>>
>> >
>> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> > Cc: Simon Glass <sjg@chromium.org>
>> > Cc: Eddie Cai <eddie.cai.linux@gmail.com>
>> > Cc: Jagan Teki <jteki@openedev.com>
>> > Cc: York Sun <york.sun@nxp.com>
>> > Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>
>> > Cc: Michal Simek <michal.simek@xilinx.com>
>> > Cc: Tom Rini <trini@konsulko.com>
>> > ---
>> >
>> > Buildman shows the following build failure, but not related this patch.
>> > aarch64: + orangepi_pc2
>> > x86: + qemu-x86_64 qemu-x86_efi_payload64 chromebook_link64
>> >
>> > include/asm-generic/global_data.h | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>>
>> Regards,
>> Simon
next prev parent reply other threads:[~2017-05-02 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 1:10 [U-Boot] [PATCH 1/2] arm: change tbu/l type to unsigned int Peng Fan
2017-04-20 1:10 ` [U-Boot] [PATCH 2/2] asm-generic: global_data: change timebase_l/h " Peng Fan
2017-04-24 3:38 ` Simon Glass
2017-04-25 20:51 ` Peng Fan
2017-05-02 11:27 ` Simon Glass [this message]
2017-04-24 3:38 ` [U-Boot] [PATCH 1/2] arm: change tbu/l type " Simon Glass
2017-05-08 9:58 ` Peng Fan
2017-05-08 13:47 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ37fipfoGs07iZ_CD1PK0+k+ASon8tVF70L+3tS-SY-rA@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.