From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E264C433EF for ; Mon, 31 Jan 2022 17:27:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 97C5883076; Mon, 31 Jan 2022 18:27:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ViaCqqCW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CB3ED83678; Mon, 31 Jan 2022 18:27:55 +0100 (CET) Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 33CCE83076 for ; Mon, 31 Jan 2022 18:27:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa29.google.com with SMTP id 48so8775060vki.0 for ; Mon, 31 Jan 2022 09:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pDzOpSqc+1BvY6rxhaOx3YChCwN8OnfKh39RCJUqiG8=; b=ViaCqqCWu5LwScT+OYRSAjgFwUgQL13wsv8uhqxlGSpqdEMJy7SuvuBlnK+GK7FGP/ 279vdTo1JjO9K1FXVAiseOBylZ1u0sp4AxhygR8e74r+7CtT7JNBU4K2WMWLhn2d6a9j cUTt8O0QLS0BwOd3Tu8tSxnBOYW1CJGNQ5Kh0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pDzOpSqc+1BvY6rxhaOx3YChCwN8OnfKh39RCJUqiG8=; b=GEZVQujSeD3dyEyeP5oumUBM5ds5dEepHMUzlok1BWRMxdP1D0la0CuHNawbsdfu7r H5PRr4+ABa/AXgvcGOKlqMhETL3iR0O7iR2MpnQ0yLmCX1/wAURq7ytCGsxBVeKNcFR1 4u4vSfizeieL3zWW7kYl0n4Camav790xWQpfg6OA2hs90Hw+gXM93WmtzQ6xBVTNqC5/ 58GDd6/Z+NHQht6P1ViI8yr4pHA7CM5P+qeaceFpwAiOtvKFBIkMKm0VrWEfv0Qn96ex nxV2LkKVq66sYkav2CpcDv00P5op6N6LT0wS5bw18ZYD+J17HhtWgofygmcYDHTMs6kF NDaw== X-Gm-Message-State: AOAM533gpqgUIBz07GQIzUv7Pi8O9B5MkOkHqmBLvvPwlnbzowy3M8+4 7qv0eL8sZnwlHOAj0Q6NkzDgYlniswuRplQyEMM/mg== X-Google-Smtp-Source: ABdhPJyVg3DRWnOlj2tUTdl/Ijr417agu3cpKShlbdFU3PUSmd09yaIGe+ASJYYXlWHN0nt7JlNq3ad48CBb1H6Icl0= X-Received: by 2002:a05:6122:c98:: with SMTP id ba24mr8349389vkb.8.1643650071657; Mon, 31 Jan 2022 09:27:51 -0800 (PST) MIME-Version: 1.0 References: <20220130155225.726890-1-sjg@chromium.org> <20220131142402.GG7515@bill-the-cat> <20220131162138.GA7515@bill-the-cat> In-Reply-To: <20220131162138.GA7515@bill-the-cat> From: Simon Glass Date: Mon, 31 Jan 2022 10:27:38 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] Makefile: Create a file to indicate the config To: Tom Rini Cc: U-Boot Mailing List , Michal Simek , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , "NXP i . MX U-Boot Team" , Masahiro Yamada , Wolfgang Denk Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Mon, 31 Jan 2022 at 09:21, Tom Rini wrote: > > On Mon, Jan 31, 2022 at 09:13:07AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 31 Jan 2022 at 07:24, Tom Rini wrote: > > > > > > On Sun, Jan 30, 2022 at 08:52:24AM -0700, Simon Glass wrote: > > > > > > > At present it is not actually possible to discover the defconfig file that > > > > was used to build U-Boot, so far as I can tell. Write this out to a file > > > > in the build directory, so this is visible. > > > > > > > > Signed-off-by: Simon Glass > > > > > > I don't think we need this really normally, it's just for the follow-up > > > patch. > > > > I'd argue that it is helpful to have this somewhere. Is there anywhere > > else in the build directory where it can be discovered? > > It's not a guarantee to exist is my first problem. My minor problems Do you mean there might not be a defconfig file? Yes I see. But generally there is, e.g. with buildman. > are this needs to be in .gitignore and also I think this wasn't ensuring > output directory not source directory. But I don't see the use case > this is filling. If you're in-tree, you should know what you configured > and are working on. If you're out of tree and didn't do any sort of > naming convention to your objdirs, did you also really care what > defconfig exactly (I use a mix of named and garbage-named temp dirs)? > And if you're a tool of some sort, you were told what to use at some > point I would assume. Which all gets back to I don't see the use case > exactly for it. I was just surprised that there was no way to find it out, that's all. It seems like a gap. But I agree that if we don't have a specific use case (e.g. we figure out another way of doing the next patch) then we could wait. Regards, Simon