[U-Boot] [PATCH 1/2] NS16550: buffer reads

[Simon Glass <sjg@chromium.org>]

Hi Kumar,

On Wed, Oct 12, 2011 at 6:08 PM, Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Oct 12, 2011, at 4:23 PM, Simon Glass wrote:
>
>> Hi Scott,
>>
>> On Fri, May 6, 2011 at 1:28 PM, Scott Wood <scottwood@freescale.com> wrote:
>>> On Wed, 4 May 2011 16:30:00 -0700
>>> Simon Glass <sjg@chromium.org> wrote:
>>>
>>>> Hi Scott,
>>>>
>>>> This is a very useful patch and it works well. I have taken the liberty of
>>>> modifying it slightly, because I think you should subtract 1 from the port
>>>> number that you pass to NS16550. For some reason the 'COM' ports are
>>>> numbered from 1 instead of 0.
>>>
>>> Thanks for spotting!
>>>
>>>> Please see below, and sorry if the patch doesn't come through cleanly.
>>>
>>> The whitespace got mangled.
>>>
>>> There's another thing that needs to be fixed -- the signatures
>>> of the 16550 functions should not change when the feature is disabled (see
>>> the discussion on http://patchwork.ozlabs.org/patch/90066/), or it'll
>>> break boards like linkstation.
>>>
>>> I'll include both fixes in my respin.
>>
>> Are you planning a respin of this? If not I will take this up as it is
>> pretty important for Tegra.
>
> Scott's on vacation for next 2 weeks so guessing he'd be fine w/you respining.

OK I have sent it to the list, just fixing two checkpatch warnings.

It is pretty-much essential on Tegra since otherwise pasting stuff
into the terminal hardly works at all.

Regards,
Simon

>
> - k