All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board_f: skip timer_init() on Coldfire archs
Date: Wed, 10 May 2017 16:03:09 -0600	[thread overview]
Message-ID: <CAPnjgZ39VROn4YSHs0prVUrZKriDKpWmO=sdm6BV-YrL2Rxv-A@mail.gmail.com> (raw)
In-Reply-To: <20170510215806.31659-1-angelo@sysam.it>

Hi Angelo,

On 10 May 2017 at 15:58, Angelo Dureghello <angelo@sysam.it> wrote:
> Coldfire arch is not happy with timer_init since interrupt handlers
> are still not set at that stage, and the boot hangs silently.
>
> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
> ---
>  common/board_f.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/common/board_f.c b/common/board_f.c
> index d9431ee79a..30e588e213 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -740,7 +740,9 @@ static const init_fnc_t init_sequence_f[] = {
>         /* get CPU and bus clocks according to the environment variable */
>         get_clocks,             /* get CPU and bus clocks (etc.) */
>  #endif
> +#if !defined(CONFIG_M68K)
>         timer_init,             /* initialize timer */
> +#endif
>  #if defined(CONFIG_BOARD_POSTCLK_INIT)
>         board_postclk_init,
>  #endif
> --
> 2.11.0
>

I'm really hoping we can get rid of all arch-specific things from the
init sequence.

Is there no way that m68k can init its timer here? Or perhaps it could
be a nop function?

Regards,
Simon

  reply	other threads:[~2017-05-10 22:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 21:58 [U-Boot] [PATCH] board_f: skip timer_init() on Coldfire archs Angelo Dureghello
2017-05-10 22:03 ` Simon Glass [this message]
2017-05-10 22:36   ` Angelo Dureghello
2017-05-17  1:38     ` Simon Glass
2017-05-19  7:49       ` Angelo Dureghello
2017-05-15 23:18 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ39VROn4YSHs0prVUrZKriDKpWmO=sdm6BV-YrL2Rxv-A@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.