From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 207A0C433EF for ; Tue, 11 Jan 2022 18:19:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C687C81B4B; Tue, 11 Jan 2022 19:19:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="NDdTK4Yp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9352E82EBB; Tue, 11 Jan 2022 19:19:19 +0100 (CET) Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E35F281A03 for ; Tue, 11 Jan 2022 19:19:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x932.google.com with SMTP id m90so164078uam.2 for ; Tue, 11 Jan 2022 10:19:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=So8o0HjzXmSQg2/oNqeflx5qBcC2SG1udmas4/YAOks=; b=NDdTK4Yp2Ll/qqqOKlttyNXQSv+wWhR8yFA3G6G8Xoy+1UP35IRXBTIbzidn76hZaT tv0x1mZEfepeIBlXiFZP9CMKpYyxT00+2zfibXPzDE+GY/JS5dN+31OmJeZ2rJifUEi1 X1fzvBlOIgQVrLlCPwySRvh/Gxac0IN1hhxRs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=So8o0HjzXmSQg2/oNqeflx5qBcC2SG1udmas4/YAOks=; b=3A4BjvUcqvyBtFv79VHszaeYLVquzEt1qfYbHIhdys4ttPHQ+vtKzI2sisDgky7k3f w2uAKV6t3CVfC3fn708X9d2+kjEwHIbSKzmEEaX/m1tBcDzsXgt9gdfkT/+Oh3hW0/ia coSmGE3eOyoOcYvL4Q9de0xiICsH4BE5V3UWbhIInCjoKJw+6CvXQWCNAmcU2/Obw7QS oCrwul8YY3ROMltI9YF+OFkYoodScbrKT2k4d1bGUJvbWExjV4cFIc5HwQSxwQm1cwVK +KCu9gXEPnwxqb4NUCvDYufZaLjLpm2zULUpSaIEx+BD4Uao1ogB+80JDwDGr0tv6V9p VhVw== X-Gm-Message-State: AOAM531ufwf+Mlz90jtpGSSQpFsEMUKJega+T7sAOFWBMluPpurS4y7z hOkMZMNyVnndLFVk+NrquBGrGmdp545a+GUJKbvcPw== X-Google-Smtp-Source: ABdhPJx5SgY2Sp0z1EPvKfeq8cLtv+b0pWLeUiR6D+Uy8M96JiKk2IfAYu0m8S/HxwmScgKdFdJ/cYF7bWMITwo3nKI= X-Received: by 2002:a67:e252:: with SMTP id w18mr1340972vse.19.1641925155455; Tue, 11 Jan 2022 10:19:15 -0800 (PST) MIME-Version: 1.0 References: <20220111005024.179632-1-heinrich.schuchardt@canonical.com> In-Reply-To: <20220111005024.179632-1-heinrich.schuchardt@canonical.com> From: Simon Glass Date: Tue, 11 Jan 2022 11:19:04 -0700 Message-ID: Subject: Re: [PATCH 1/1] sandbox: compatibility of os_get_filesize() To: Heinrich Schuchardt Cc: U-Boot Mailing List , =?UTF-8?Q?Milan_P_=2E_Stani=C4=87?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, 10 Jan 2022 at 17:50, Heinrich Schuchardt wrote: > > U-Boot define loff_t as long long. But the header > /usr/include/linux/types.h may not define it. > This has lead to a build error on Alpine Linux. > > So let's use long long instead of loff_t for > the size parameter of function os_get_filesize(). > > Reported-by: Milan P. Stani=C4=87 > Signed-off-by: Heinrich Schuchardt > --- > arch/sandbox/cpu/os.c | 10 ++++++++-- > include/os.h | 2 +- > 2 files changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass