All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] dm: core: device: switch off power domain after device removal
Date: Thu, 18 Jul 2019 09:22:20 -0600	[thread overview]
Message-ID: <CAPnjgZ3ABpkum9GWZ5cnmhTeF4GnHWOW2AisRhYXTN6jrgbOiw@mail.gmail.com> (raw)
In-Reply-To: <AM0PR04MB4481081E77CBEFDDC1D4460088CF0@AM0PR04MB4481.eurprd04.prod.outlook.com>

Hi Anatolij,

On Sun, 14 Jul 2019 at 20:59, Peng Fan <peng.fan@nxp.com> wrote:
>
> > Subject: [PATCH v2 1/2] dm: core: device: switch off power domain after
> > device removal
> >
> > The power domain associated with a device is enabled when probing, but
> > currently the domain remains enabled when the device is removed.
> > Some boards started to disable power domains for selected devices via
> > custom board_quiesce_devices(), but it doesn't work in many cases, i. e.
> > because devices still can be accessed later in
> > .remove() callback on behalf of dm_remove_devices_flags().
> >
> > Utilize the DM core to power off the device power domain, but add a device
> > flag to be able to selectively let the power domain enabled after device
> > removal. This might be required for devices that must remain enabled when
> > booting OS, i. e. serial console for debug output, etc.
> >
> > Signed-off-by: Anatolij Gustschin <agust@denx.de>
> > ---
> > Changes in v2:
> >  - use CONFIG_IS_ENABLED(POWER_DOMAIN) to reduce code size
> >
> >  drivers/core/device-remove.c | 9 +++++++++
> >  include/dm/device.h          | 6 ++++++
> >  2 files changed, 15 insertions(+)

Unfortunately this causes a test failure (make qcheck). Can you please
take a look?

Regards,
Simon

  reply	other threads:[~2019-07-18 15:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-14 19:57 [U-Boot] [PATCH v2 1/2] dm: core: device: switch off power domain after device removal Anatolij Gustschin
2019-07-14 19:57 ` [U-Boot] [PATCH v2 2/2] serial: lpuart: request dm device removal when booting OS Anatolij Gustschin
2019-07-15  3:02   ` Peng Fan
2019-07-31 13:11     ` Anatolij Gustschin
2019-07-15  2:59 ` [U-Boot] [PATCH v2 1/2] dm: core: device: switch off power domain after device removal Peng Fan
2019-07-18 15:22   ` Simon Glass [this message]
2019-07-31 16:01     ` Anatolij Gustschin
2019-07-31 16:29       ` Simon Glass
2019-07-31 17:02         ` Anatolij Gustschin
2019-07-23 14:05 ` Lokesh Vutla
2019-07-31 13:13   ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3ABpkum9GWZ5cnmhTeF4GnHWOW2AisRhYXTN6jrgbOiw@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.