From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 166F8C433F5 for ; Mon, 13 Dec 2021 12:53:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C87A68379E; Mon, 13 Dec 2021 13:53:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="AhcHh5zX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B4F2C83776; Mon, 13 Dec 2021 13:52:13 +0100 (CET) Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9E01A83774 for ; Mon, 13 Dec 2021 13:52:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x929.google.com with SMTP id p2so28898422uad.11 for ; Mon, 13 Dec 2021 04:52:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kfjfx2KYLndZ1ixcmQGUPuQ/pGE7mJT9R/fsCd0piKM=; b=AhcHh5zXuYFACQmnkqAmZOJjjotUJYlxJz7F3wbqt+Sv7f2BUJyxdSyo8a1h4BWcEq WLXzIIZuOPJMwV9W9WgjjdsqIyGGA0iyGHIJCX5LQm/sGzkcX+ppIv8kv9lTSE68ymcH PjY6vHraejUHmjB47wkFuu0JrvxiZ81pplCbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kfjfx2KYLndZ1ixcmQGUPuQ/pGE7mJT9R/fsCd0piKM=; b=S7x153GTNUEsqP9CuIuMGwS3xrVJL0q2hTZPdc8XPRXjRFjCjyVE8uHuHw/FvCS+ir Fnvd6OZRrG6CKESdKhOpNYZ7jv1BtXCUHmaeduXdjYt0IovYtzgwSpEZlrBASmd2CRx0 CYYWzd3XRHDS3YMvWvBhkf1NzWd8fwK4+1omSRzkV156wKrkT/IuQxCbKJKSOjJNoAoi 0JTj08tBDz3narzC9SVWV/vMi/2qOUVtEzPCkNMP2FiF0mtSBuGNTj+LcsBlP1w+GM/W MOUVJA6fLE3AAC1HtebHx2xmKovFhIJ6YussnI0oGA74hw6QnPUEDO34lcQCg236vUei sxxw== X-Gm-Message-State: AOAM533wr57A9IBMF51wGBV3TIOdSLefjJHMR7Sn/93qhnab+3N/N9XD kMI1ZOUJUtQTf6cuiAlZD4Mso4gRch6+BoKaRWQ8jw== X-Google-Smtp-Source: ABdhPJy+iRSO/ehE5E/gSGdG8tWeT1iCae4pZXBrQTfPnWcBJeC7B0PcF8+TyuLEHBYR4venepInt9vJporSMWrMclc= X-Received: by 2002:ab0:7784:: with SMTP id x4mr40930996uar.143.1639399919956; Mon, 13 Dec 2021 04:51:59 -0800 (PST) MIME-Version: 1.0 References: <20211210064947.73361-1-takahiro.akashi@linaro.org> <20211210064947.73361-19-takahiro.akashi@linaro.org> In-Reply-To: <20211210064947.73361-19-takahiro.akashi@linaro.org> From: Simon Glass Date: Mon, 13 Dec 2021 05:51:49 -0700 Message-ID: Subject: Re: [RFC v2 18/20] efi_loader: disk: use udevice instead of blk_desc To: AKASHI Takahiro Cc: xypron.glpk@gmx.de, agraf@csgraf.de, ilias.apalodimas@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 9 Dec 2021 at 23:58, AKASHI Takahiro wrote: > > In most of all cases, we can avoid using blk_desc which is expected > to be private to udevice(UCLASS_BLK), that is, the data should not > be manupulated outside the device driver unless really needed. > > Now efi_disk's internally use dev_read/write() interfaces. > > Signed-off-by: AKASHI Takahiro > --- > lib/efi_loader/efi_disk.c | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) Reviewed-by: Simon Glass