All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Philippe Reynes <philippe.reynes@softathome.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/2] tools: binman: main.py: add build-sandbox in sys.path
Date: Sat, 26 Feb 2022 11:36:37 -0700	[thread overview]
Message-ID: <CAPnjgZ3C-bHZaaRys6aXVLL7B5LhOR9ufGCzDBWcjWOrTSm_4g@mail.gmail.com> (raw)
In-Reply-To: <20220127140314.10264-1-philippe.reynes@softathome.com>

Hi Philippe

On Thu, 27 Jan 2022 at 07:03, Philippe Reynes
<philippe.reynes@softathome.com> wrote:
>
> Adds build-sandbox in sys.path to look for libfdt,
> otherwise py_test can't use binman.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
> ---
>  tools/binman/main.py | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/tools/binman/main.py b/tools/binman/main.py
> index 35944f314a..f62394043d 100755
> --- a/tools/binman/main.py
> +++ b/tools/binman/main.py
> @@ -40,6 +40,7 @@ from patman import test_util
>  # Bring in the libfdt module
>  sys.path.insert(2, 'scripts/dtc/pylibfdt')
>  sys.path.insert(2, os.path.join(srctree, 'scripts/dtc/pylibfdt'))
> +sys.path.insert(2, os.path.join(srctree, 'build-sandbox/scripts/dtc/pylibfdt'))
>  sys.path.insert(2, os.path.join(srctree, 'build-sandbox_spl/scripts/dtc/pylibfdt'))
>
>  # When running under python-coverage on Ubuntu 16.04, the dist-packages
> --
> 2.17.1
>

The build-sandbox_spl path should be enough though, shouldn't it? Have
you not built that?

Regards,
Simon

      parent reply	other threads:[~2022-02-26 18:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 14:03 [PATCH 1/2] tools: binman: main.py: add build-sandbox in sys.path Philippe Reynes
2022-01-27 14:03 ` [PATCH 2/2] tools: binman: main.py: add /tmp/sandbox sys.path Philippe Reynes
2022-01-27 15:06   ` Simon Glass
2022-01-27 15:15     ` Philippe REYNES
2022-02-26 18:36       ` Simon Glass
2022-02-26 18:36 ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3C-bHZaaRys6aXVLL7B5LhOR9ufGCzDBWcjWOrTSm_4g@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=philippe.reynes@softathome.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.