All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	 AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Masahisa Kojima <masahisa.kojima@linaro.org>,
	 U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/2] dm: blk: assign media ID to block devices
Date: Thu, 15 Sep 2022 19:30:48 -0600	[thread overview]
Message-ID: <CAPnjgZ3CckCc+EezPB=GDJ0Z152W02_Cdre1PkVuXQoc_u=e3Q@mail.gmail.com> (raw)
In-Reply-To: <20220915200242.18358-2-heinrich.schuchardt@canonical.com>

Hi Heinrich,

On Thu, 15 Sept 2022 at 14:02, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Currently block devices are only identified by uclass_id and device number.
> When dealing with removable media this is not enough to uniquely identify
> the medium.
>
> E.g. after host unbind, host bind we can have the same device number but a
> different backing file.
>
> The EFI specification uses a 32bit number media ID to identify media. Add a
> matching field to the block device descriptor.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  drivers/block/blk-uclass.c | 16 +++++++++++++++-
>  include/blk.h              | 11 +++++++++++
>  2 files changed, 26 insertions(+), 1 deletion(-)

Shouldn't this be handled by connecting the  EFI data to its udevice.
I think Takahiro has been looking at this?

NAK to any EFI fields in blk_desc, in any case

Regards,
Simon

  reply	other threads:[~2022-09-16  1:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 20:02 [PATCH 0/2] efi_loader: provide media ID Heinrich Schuchardt
2022-09-15 20:02 ` [PATCH 1/2] dm: blk: assign media ID to block devices Heinrich Schuchardt
2022-09-16  1:30   ` Simon Glass [this message]
2022-09-16  6:41     ` Heinrich Schuchardt
2022-09-16 20:29       ` Simon Glass
2022-09-15 20:02 ` [PATCH 2/2] efi_loader: fill media_id from block device descriptor Heinrich Schuchardt
2022-09-23  7:07   ` Ilias Apalodimas
2022-09-25 14:15     ` Simon Glass
2022-09-26  0:05       ` AKASHI Takahiro
2022-09-16  0:58 ` [PATCH 0/2] efi_loader: provide media ID AKASHI Takahiro
2022-09-26  6:06   ` Heinrich Schuchardt
2022-09-27  1:51     ` AKASHI Takahiro
2022-09-27  6:53       ` Heinrich Schuchardt
2022-09-28  1:54         ` Simon Glass
2022-09-28  6:57           ` Heinrich Schuchardt
2022-09-28  7:24             ` AKASHI Takahiro
2022-09-28 16:27               ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ3CckCc+EezPB=GDJ0Z152W02_Cdre1PkVuXQoc_u=e3Q@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=masahisa.kojima@linaro.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.