All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: test/image/test-imagetools.sh: Broken by 3f04db89
Date: Thu, 25 Mar 2021 13:38:23 +1300	[thread overview]
Message-ID: <CAPnjgZ3F-ADjdY-WN67kcwvzGJKkhpMrNq2qCxqXSanCeCqwfg@mail.gmail.com> (raw)
In-Reply-To: <87k0qjsxzi.fsf@yucca>

Hi Vagrant,

On Sun, 7 Mar 2021 at 11:50, Vagrant Cascadian <vagrant@debian.org> wrote:
>
> It seems like commit:
>
> 3f04db891a353f4b127ed57279279f851c6b4917 image: Check for unit addresses in FIT
>
> Broke test/image/test-imagetools.sh.
>
> I get the impression test-imagetools.sh is more-or-less unmaintained and
> deprecated. Does test-imagetools.sh perform tests that are not covered
> elsewhere? If it is not maintained (and especially otherwise covered),
> it might be worth removing entirely.
>
>
> Thanks for all your work on u-boot!

It looks like is has useful tests. We should convert it to a python
test in test/py/tests and we already have test_vboot.py which does FIT
things so it should be easy enough.

Regards,
Simon

      reply	other threads:[~2021-03-25  0:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06 22:45 test/image/test-imagetools.sh: Broken by 3f04db89 Vagrant Cascadian
2021-03-25  0:38 ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3F-ADjdY-WN67kcwvzGJKkhpMrNq2qCxqXSanCeCqwfg@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.