From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A5E1C433F5 for ; Mon, 14 Mar 2022 22:21:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A706D83B90; Mon, 14 Mar 2022 23:21:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="NmWXXDSZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F19EA8380F; Mon, 14 Mar 2022 23:21:03 +0100 (CET) Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 304708399C for ; Mon, 14 Mar 2022 23:20:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92f.google.com with SMTP id 63so7230414uaw.10 for ; Mon, 14 Mar 2022 15:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E0mtjv0UFmbyOGtdL50NmYhAqEP4yavdvOgeIszfxGY=; b=NmWXXDSZXqun1qGlZzxUNCuqe9HYsC0O3YPEb0es0k+ydol2WiNSKFBb4ZL3u+YmTm AQG9IB8PqbCnuPCNIpVN9r5n5DcbwZH/z0NAAfDO16k26HAFyBE93Ozs8aPApmQ4nOGw fDSBFkKwFIBZyiiZmeAsDXDmtJ7PGm+xO/5hU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E0mtjv0UFmbyOGtdL50NmYhAqEP4yavdvOgeIszfxGY=; b=zR5ziF188sBqWJNRORBghDQO2SgpKdRoXH7irviG3uZaUFtvUqcAZb147e0xXUc+6n A19jJ8DSVuTYmUxDaic2a+hoJNr/OsUwEyOJIfq/M7gkVwG6d0b7M1Vbm7yJO6gNGXvv hkCkxW4k4bEe2Bc6WeFO+ABX+QXIF3dhmokusnj0FKJW4Sp+RTarqmHeh2chQ4Liscih cA8F/sof6Vz648U8nZHlLX1SjmI1CV6jmCc/sc26a3LnFX2acnfBjGhY8Ghwrog1I7Dv XQSl93TnwsbWdFFz1VnH9pyu+n3GNJA8WnJpucWgrwxvSVh39vjrRo8sAfKfQtSN0VCK UghQ== X-Gm-Message-State: AOAM531PWJS96eQgYwnF/WI2mTkID5fUvWLJyhQ7u+7oa81hWZiM9CR6 KtFYFfHNKWpaGXqRAcErrjnCBmitfIBtPEg3bZCu5qiODhizk+7n X-Google-Smtp-Source: ABdhPJy/q4OUpJaopDodkG+xqvhahu07tA0ocWKkL4XfB34YTDxPjr1CqkT0kbTLH030RJRSIuagJWDAsdadzZca0Pg= X-Received: by 2002:ab0:754b:0:b0:349:1e49:cb97 with SMTP id k11-20020ab0754b000000b003491e49cb97mr9824264uaq.92.1647296453803; Mon, 14 Mar 2022 15:20:53 -0700 (PDT) MIME-Version: 1.0 References: <20220223230040.159317-1-sjg@chromium.org> <20220223230040.159317-13-sjg@chromium.org> <22d5d296-65b4-2a97-5879-d038d400efc5@gmail.com> <263b8679-75dd-ada5-7d1f-409702320d27@gmail.com> <5a67bbf5-c305-025b-0834-28ac1afa24b6@gmail.com> In-Reply-To: <5a67bbf5-c305-025b-0834-28ac1afa24b6@gmail.com> From: Simon Glass Date: Mon, 14 Mar 2022 16:20:41 -0600 Message-ID: Subject: Re: [PATCH v2 12/25] binman: Change how faked blobs are created To: Alper Nebi Yasak Cc: Ivan Mikhaylov , Tom Rini , Philippe Reynes , huang lin , Jeffy Chen , Kever Yang , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Alper, On Mon, 14 Mar 2022 at 15:31, Alper Nebi Yasak wrote: > > On 12/03/2022 08:02, Simon Glass wrote: > > On Thu, 10 Mar 2022 at 12:36, Alper Nebi Yasak wrote: > >> On 06/03/2022 06:08, Simon Glass wrote: > >>> On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak wrote: > >>>> Do we need to create actual files, or is it a convenience thing for blob > >>>> entry types (because they already read their contents from files)? > >>> > >>> We need the files for mkimage. > >> > >> But the mkimage etype creates its own files to pass to mkimage anyway, > >> using entry.GetData() in collect_contents_to_file() without reaching > >> into subentries' files. > >> > >> More specifically, what I'm thinking of is removing check_fake_fname() > >> entirely, instead of managing/removing the files it creates. At a > >> cursory glance, only blob and blob-ext-list seem to use that directly. > > > > OK, but if the files don't get created, then mkimage will fail, right? > > I don't think it will, but maybe it's better that I try removing it to > see if anything breaks. Yes, the reason for adding faked blobs was needing to run mkimage which expects files (in the .its or elsewhere) to be present. Regards, Simon